-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Safe version nullable #629
Comments
We've decided it's OK to fail on the CGW side for null versions since incorrect contract deployments (L2/nonL2 misalignment) won't be supported. For special cases, the Safe Core team would add the contracts on demand. |
Reopened as Safe{Core} team took the decision to make Safe |
Since the |
Problem
Validation errors are not being handled in the frontend. So when the service retrieves a Safe with a
null
version from the Transaction Service, the call to/chains/:chainId/safes/:safeAddress
fails and the frontend is not capable of managing the error.Failing when an incorrect Safe entity (with
version: null
) is retrieved is the correct behavior, but it's not the expected one right now.Short-term solution
version
a nullable field for aSafe
. The web UI already has some logic to managenull
Safe versions: https://github.com/safe-global/safe-wallet-web/blob/consistent-provider/src/hooks/coreSDK/safeCoreSDK.ts#L56Long-term solution
The text was updated successfully, but these errors were encountered: