Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Safe version nullable #629

Closed
hectorgomezv opened this issue Aug 8, 2023 · 3 comments · Fixed by #764
Closed

Make Safe version nullable #629

hectorgomezv opened this issue Aug 8, 2023 · 3 comments · Fixed by #764
Assignees

Comments

@hectorgomezv
Copy link
Member

Problem
Validation errors are not being handled in the frontend. So when the service retrieves a Safe with a null version from the Transaction Service, the call to /chains/:chainId/safes/:safeAddress fails and the frontend is not capable of managing the error.

Failing when an incorrect Safe entity (with version: null) is retrieved is the correct behavior, but it's not the expected one right now.

Short-term solution

Long-term solution

  • Push the implementation of a validation error view in the clients, so they can manage this kind of scenario.
@hectorgomezv hectorgomezv self-assigned this Aug 8, 2023
@hectorgomezv hectorgomezv linked a pull request Aug 9, 2023 that will close this issue
@hectorgomezv
Copy link
Member Author

We've decided it's OK to fail on the CGW side for null versions since incorrect contract deployments (L2/nonL2 misalignment) won't be supported.

For special cases, the Safe Core team would add the contracts on demand.

@hectorgomezv
Copy link
Member Author

Reopened as Safe{Core} team took the decision to make Safe version nullable. See: safe-global/safe-transaction-service#1571

@hectorgomezv hectorgomezv reopened this Oct 13, 2023
@fmrsabino
Copy link
Contributor

Reopened as Safe{Core} team took the decision to make Safe version nullable. See: safe-global/safe-transaction-service#1571

Since the version is already null on the API level I would say that we can move forward and remove this validation. The respective SDK also considers the version as null: https://github.com/safe-global/safe-gateway-typescript-sdk/blob/93dcd18a2738e5ccd30f803b9e39d55b9486210a/src/types/safe-info.ts#L20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants