An attempt to fix flaky zksync test #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgraded several development dependencies related to Hardhat and zkSync: - `@matterlabs/hardhat-zksync-deploy` from `^1.5.0` to `^1.6.0` - `@matterlabs/hardhat-zksync-node` from `^1.1.1` to `^1.2.1` - `@matterlabs/hardhat-zksync-verify` from `^1.6.0` to `^1.7.1` - `zksync-ethers` from `6.12.1` to `6.15.3` - Refactored the test setup in `SafeToL2Setup.spec.ts` to retrieve the deployed contract instance using `getContractAt` instead of deploying a new instance, enhancing test reliability and efficiency.
|
nhờ mọi người giúp đỡ |
mmv08
force-pushed
the
zksync-failing-test
branch
from
aba436d to
2f4704c
Compare
remedcu
approved these changes
Jan 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@matterlabs/hardhat-zksync-deployfrom^1.5.0to^1.6.0@matterlabs/hardhat-zksync-nodefrom^1.1.1to^1.2.1@matterlabs/hardhat-zksync-verifyfrom^1.6.0to^1.7.1zksync-ethersfrom6.12.1to6.15.3SafeToL2Setup.spec.tsto retrieve the deployed contract instance usinggetContractAtinstead of deploying a new instance, enhancing test reliability and efficiency.