Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command to update safe logos #1636

Closed
moisses89 opened this issue Aug 23, 2023 · 3 comments · Fixed by #1657
Closed

Command to update safe logos #1636

moisses89 opened this issue Aug 23, 2023 · 3 comments · Fixed by #1657
Assignees
Labels
enhancement New feature or request

Comments

@moisses89
Copy link
Member

moisses89 commented Aug 23, 2023

What is needed?

We would like to include an easy way to update the logos of safe contract in the Contracts model.
An approach could be take the addresses of safe contract by version from every chain from https://github.com/safe-global/safe-deployments and update the logo addresses with the new logo.

Endpoints related

https://safe-transaction-mainnet.safe.global/api/v1/contracts/0xd9Db270c1B5E3Bd161E8c8503c55cEABeE709552/

@moisses89 moisses89 added the enhancement New feature or request label Aug 23, 2023
@tschubotz
Copy link
Member

@moisses89 when touching all Safe related known addresses/contracts, please also remove the word "gnosis" everywhere :)

image

@moisses89
Copy link
Member Author

@Uxio0 I'm considering to expand the purpose of this issue to also create the missing contracts that are necessary by chain as multisend, what do you think?

@Uxio0
Copy link
Member

Uxio0 commented Oct 10, 2023

@Uxio0 I'm considering to expand the purpose of this issue to also create the missing contracts that are necessary by chain as multisend, what do you think?

Yes please, if they are available on the network we should create them if not (and also add their names)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants