Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to allow decoding of call data for contracts that are proxies/diamonds #1709

Closed
startswithaj opened this issue Oct 17, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@startswithaj
Copy link

startswithaj commented Oct 17, 2023

What is needed?

For Users that use proxy contracts or diamonds ERC-2535 the SAFE UI does not decode the transaction data. This is a known issue. Users are also not able to upload the abi for these contracts in anyway.

Feature:

  1. In the address book allow users to configure an ABI for the address.
  2. In the transaction panel (pictured below) add a button [Decode Data With Custom ABI].

This has been a problem for years for many users. Currently we must use a tool like https://lab.miguelmota.com/ethereum-input-data-decoder/example/ to verify call data or other custom tooling

Alternative:

Add a button that uses the https://www.4byte.directory/ or https://openchain.xyz/signatures api to check if there is a result for the function signature and if found use it to decode the call data.

Background

Screenshot 2023-10-17 at 2 37 59 pm

URL

https://app.safe.global/transactions/

@startswithaj startswithaj added the enhancement New feature or request label Oct 17, 2023
@Uxio0
Copy link
Member

Uxio0 commented Oct 18, 2023

You are proposing web related fixes, so this issue belongs to https://github.com/safe-global/safe-wallet-web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants