From ff79f53e517885cd2d6b0186c282ea742653b734 Mon Sep 17 00:00:00 2001
From: Will Harney <62956339+wjhsf@users.noreply.github.com>
Date: Tue, 3 Dec 2024 09:54:55 -0500
Subject: [PATCH 01/12] test: better snapshot errors (#4985)

* fix(ssr): adjacent text in `<template>`s

Co-Authored-By: Will Harney <62956339+wjhsf@users.noreply.github.com>
Co-Authored-By: John Hefferman <jhefferman@salesforce.com>

* test: fix expected failures

* test(snapshots): add helpfuler message when error/expected swap

---------

Co-authored-by: Nolan Lawson <nlawson@salesforce.com>
Co-authored-by: John Hefferman <jhefferman@salesforce.com>
---
 scripts/test-utils/test-fixture-dir.ts | 54 +++++++++++++++++++++++++-
 1 file changed, 52 insertions(+), 2 deletions(-)

diff --git a/scripts/test-utils/test-fixture-dir.ts b/scripts/test-utils/test-fixture-dir.ts
index 7da24fd186..c362d73721 100644
--- a/scripts/test-utils/test-fixture-dir.ts
+++ b/scripts/test-utils/test-fixture-dir.ts
@@ -5,8 +5,9 @@
  * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
  */
 
-import fs from 'node:fs';
+import fs, { readFileSync } from 'node:fs';
 import path from 'node:path';
+import { AssertionError } from 'node:assert';
 import { test } from 'vitest';
 import * as glob from 'glob';
 import type { Config as StyleCompilerConfig } from '@lwc/style-compiler';
@@ -145,7 +146,9 @@ export function testFixtureDir<T extends TestFixtureConfig>(
                 );
             }
 
-            for (const [outputName, content] of Object.entries(outputs)) {
+            const outputsList = Object.entries(outputs);
+
+            for (const [outputName, content] of outputsList) {
                 const outputPath = path.resolve(dirname, outputName);
                 try {
                     await expect(content ?? '').toMatchFileSnapshot(outputPath);
@@ -156,6 +159,53 @@ export function testFixtureDir<T extends TestFixtureConfig>(
                         Error.captureStackTrace(err, testFixtureDir);
                     }
 
+                    const isErrorSnapshot = outputName.startsWith('error');
+                    const isSuccessSnapshot = outputName.startsWith('expected');
+
+                    // If we change from a successful result to an error (or vice versa),
+                    // then either the snapshot or content for the failing file is empty,
+                    // and the diff printed in the error message isn't helpful. Here, we check for
+                    // that case, and then check if the other file has flipped the other way.
+                    // If it has, we throw a more helpful error message.
+                    if (isErrorSnapshot || isSuccessSnapshot) {
+                        const brokenResult = outputs[outputName];
+                        const brokenResultHasContent = Boolean(brokenResult);
+                        const brokenSnapshot = readFileSync(outputPath, 'utf8');
+                        const brokenSnapshotHasContent = Boolean(brokenSnapshot);
+                        if (brokenResultHasContent !== brokenSnapshotHasContent) {
+                            // This file flipped from content to empty, or vice versa
+                            const otherType = isErrorSnapshot ? 'expected' : 'error';
+                            const otherName = outputsList.find(([name]) =>
+                                name.startsWith(otherType)
+                            )![0];
+                            const otherResult = outputs[otherName];
+                            const otherResultHasContent = Boolean(otherResult);
+                            const otherSnapshot = readFileSync(
+                                path.resolve(dirname, otherName),
+                                'utf8'
+                            );
+                            const otherSnapshotHasContent = Boolean(otherSnapshot);
+                            if (otherResultHasContent !== otherSnapshotHasContent) {
+                                // The other file has flipped from content to empty, or vice versa
+                                const expectedContentName = brokenSnapshotHasContent
+                                    ? outputName
+                                    : otherName;
+                                const actualContentName = brokenResultHasContent
+                                    ? outputName
+                                    : otherName;
+                                const contentErr = new AssertionError({
+                                    message: `Expected content in ${expectedContentName}, but found content in ${actualContentName}.`,
+                                    expected: brokenSnapshotHasContent
+                                        ? brokenSnapshot
+                                        : otherSnapshot,
+                                    actual: brokenResultHasContent ? brokenResult : otherResult,
+                                });
+                                Error.captureStackTrace(contentErr, testFixtureDir);
+                                throw contentErr;
+                            }
+                        }
+                    }
+
                     throw err;
                 }
             }

From dc25372657e59206feee23d13c7c94abb0540e64 Mon Sep 17 00:00:00 2001
From: Will Harney <62956339+wjhsf@users.noreply.github.com>
Date: Tue, 3 Dec 2024 11:29:50 -0500
Subject: [PATCH 02/12] test(ssr): add fixture for computed prop exploding
 (#4989)

* test(ssr): add fixture for computed prop exploding

* chore: update text content to not be bad copy/paste
---
 .../errors/throws-on-computed-key/error.txt   |  1 +
 .../throws-on-computed-key/expected.html      |  0
 .../errors/throws-on-computed-key/index.js    |  3 +++
 .../modules/x/wire/adapter.js                 | 13 +++++++++++++
 .../modules/x/wire/wire.html                  |  3 +++
 .../modules/x/wire/wire.js                    | 19 +++++++++++++++++++
 6 files changed, 39 insertions(+)
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/error.txt
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/expected.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/index.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/modules/x/wire/adapter.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/modules/x/wire/wire.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/modules/x/wire/wire.js

diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/error.txt
new file mode 100644
index 0000000000..b2dc26d469
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/error.txt
@@ -0,0 +1 @@
+getter should not be called
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/expected.html
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/index.js
new file mode 100644
index 0000000000..fafb890973
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/index.js
@@ -0,0 +1,3 @@
+export const tagName = 'x-wire';
+export { default } from 'x/wire';
+export * from 'x/wire';
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/modules/x/wire/adapter.js b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/modules/x/wire/adapter.js
new file mode 100644
index 0000000000..b212b22d3f
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/modules/x/wire/adapter.js
@@ -0,0 +1,13 @@
+export class adapter {
+    constructor(dataCallback) {
+        this.dc = dataCallback;
+    }
+
+    connect() {}
+
+    update(config) {
+        this.dc(config.name);
+    }
+
+    disconnect() {}
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/modules/x/wire/wire.html b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/modules/x/wire/wire.html
new file mode 100644
index 0000000000..3981f33b93
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/modules/x/wire/wire.html
@@ -0,0 +1,3 @@
+<template>
+    {exposedSymbol}
+</template>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/modules/x/wire/wire.js b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/modules/x/wire/wire.js
new file mode 100644
index 0000000000..723fb3bb05
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-on-computed-key/modules/x/wire/wire.js
@@ -0,0 +1,19 @@
+import { LightningElement, wire } from 'lwc';
+import { adapter } from './adapter';
+const sym = Symbol('computed prop');
+
+export default class Wire extends LightningElement {
+    @wire(adapter, { name: 'symbol' })
+    get [sym]() {
+        throw new Error('getter should not be called');
+    }
+
+    @wire(adapter, { name: 'symbol' })
+    set [sym](v) {
+        throw new Error('setter should not be called');
+    }
+
+    get exposedSymbol() {
+        return this[sym];
+    }
+}

From 91bcaf2d41d3827dd145817423136116eb64d7c7 Mon Sep 17 00:00:00 2001
From: Will Harney <62956339+wjhsf@users.noreply.github.com>
Date: Tue, 3 Dec 2024 15:00:03 -0500
Subject: [PATCH 03/12] test(ssr): add fixture for lwc:if and comment with no
 text nodes (#4993)

---
 .../preserve-comments-on/empty copy/error.txt            | 0
 .../preserve-comments-on/empty copy/expected.html        | 9 +++++++++
 .../preserve-comments-on/empty copy/index.js             | 3 +++
 .../modules/x/comments-text/comments-text.html           | 6 ++++++
 .../empty copy/modules/x/comments-text/comments-text.js  | 9 +++++++++
 5 files changed, 27 insertions(+)
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-on/empty copy/error.txt
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-on/empty copy/expected.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-on/empty copy/index.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-on/empty copy/modules/x/comments-text/comments-text.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-on/empty copy/modules/x/comments-text/comments-text.js

diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-on/empty copy/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-on/empty copy/error.txt
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-on/empty copy/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-on/empty copy/expected.html
new file mode 100644
index 0000000000..79ceaa13f4
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-on/empty copy/expected.html	
@@ -0,0 +1,9 @@
+<x-comments-text>
+  <template shadowrootmode="open">
+    <!---->
+    ‍
+    <!---->
+    <!-- preserved comment after true -->
+    <!-- preserved comment after false -->
+  </template>
+</x-comments-text>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-on/empty copy/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-on/empty copy/index.js
new file mode 100644
index 0000000000..4bd94488e9
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-on/empty copy/index.js	
@@ -0,0 +1,3 @@
+export const tagName = 'x-comments-text';
+export { default } from 'x/comments-text';
+export * from 'x/comments-text';
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-on/empty copy/modules/x/comments-text/comments-text.html b/packages/@lwc/engine-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-on/empty copy/modules/x/comments-text/comments-text.html
new file mode 100644
index 0000000000..1138d4e911
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-on/empty copy/modules/x/comments-text/comments-text.html	
@@ -0,0 +1,6 @@
+<template lwc:preserve-comments>
+    <template lwc:if={isTrue}>{foo}{bar}{baz}</template>
+    <!-- preserved comment after true -->
+    <template lwc:if={isFalse}>{foo}{bar}{baz}</template>
+    <!-- preserved comment after false -->
+</template>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-on/empty copy/modules/x/comments-text/comments-text.js b/packages/@lwc/engine-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-on/empty copy/modules/x/comments-text/comments-text.js
new file mode 100644
index 0000000000..4f3a42e964
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/adjacent-text-nodes/preserve-comments-on/empty copy/modules/x/comments-text/comments-text.js	
@@ -0,0 +1,9 @@
+import { LightningElement } from 'lwc';
+
+export default class extends LightningElement {
+    isTrue = true;
+    isFalse = false;
+    foo = '';
+    bar = undefined;
+    baz = null;
+}

From 7f44840e1fb3b2bb61e9d07838afe38f77fbe021 Mon Sep 17 00:00:00 2001
From: Nolan Lawson <nlawson@salesforce.com>
Date: Tue, 3 Dec 2024 12:00:20 -0800
Subject: [PATCH 04/12] refactor(ssr): share node types in traversal (#4987)

Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
---
 .../@lwc/ssr-compiler/src/transmogrify.ts     | 47 +++++++++----------
 1 file changed, 23 insertions(+), 24 deletions(-)

diff --git a/packages/@lwc/ssr-compiler/src/transmogrify.ts b/packages/@lwc/ssr-compiler/src/transmogrify.ts
index 952095992c..6a3a89a579 100644
--- a/packages/@lwc/ssr-compiler/src/transmogrify.ts
+++ b/packages/@lwc/ssr-compiler/src/transmogrify.ts
@@ -42,32 +42,31 @@ const isWithinFn = (pattern: RegExp, nodePath: NodePath): boolean => {
     return false;
 };
 
-function transformFunction(
-    path: NodePath<FunctionDeclaration | FunctionExpression, EstreeToolkitNode>,
-    state: TransmogrificationState
-): undefined {
-    const { node } = path;
-    if (!node?.async || !node?.generator) {
-        return;
-    }
-
-    // Component authors might conceivably use async generator functions in their own code. Therefore,
-    // when traversing & transforming written+generated code, we need to disambiguate generated async
-    // generator functions from those that were written by the component author.
-    if (
-        !isWithinFn(GEN_MARKUP_OR_GEN_SLOTTED_CONTENT_PATTERN, path) &&
-        !isWithinFn(TMPL_FN_PATTERN, path)
+const visitors: Visitors = {
+    // @ts-expect-error types for `traverse` do not support sharing a visitor between node types:
+    // https://github.com/sarsamurmu/estree-toolkit/issues/20
+    'FunctionDeclaration|FunctionExpression'(
+        path: NodePath<FunctionDeclaration | FunctionExpression, EstreeToolkitNode>,
+        state: TransmogrificationState
     ) {
-        return;
-    }
-    node.generator = false;
-    node.async = state.mode === 'async';
-    node.params.unshift(EMIT_IDENT);
-}
+        const { node } = path;
+        if (!node?.async || !node?.generator) {
+            return;
+        }
 
-const visitors: Visitors = {
-    FunctionDeclaration: transformFunction,
-    FunctionExpression: transformFunction,
+        // Component authors might conceivably use async generator functions in their own code. Therefore,
+        // when traversing & transforming written+generated code, we need to disambiguate generated async
+        // generator functions from those that were written by the component author.
+        if (
+            !isWithinFn(GEN_MARKUP_OR_GEN_SLOTTED_CONTENT_PATTERN, path) &&
+            !isWithinFn(TMPL_FN_PATTERN, path)
+        ) {
+            return;
+        }
+        node.generator = false;
+        node.async = state.mode === 'async';
+        node.params.unshift(EMIT_IDENT);
+    },
     YieldExpression(path, state) {
         const { node } = path;
         if (!node) {

From e937815c85ba5be01653818e5618636fbea2873d Mon Sep 17 00:00:00 2001
From: Nolan Lawson <nlawson@salesforce.com>
Date: Tue, 3 Dec 2024 12:00:36 -0800
Subject: [PATCH 05/12] fix(ssr): fix rendering scoped variables in iterators
 (#4990)

---
 .../for-each-block/{ => basic}/config.json    |  0
 .../for-each-block/{ => basic}/error.txt      |  0
 .../for-each-block/{ => basic}/expected.html  |  0
 .../for-each-block/{ => basic}/index.js       |  0
 .../x/for-each-block/for-each-block.html      |  0
 .../x/for-each-block/for-each-block.js        |  0
 .../child-nested}/config.json                 |  0
 .../child-nested}/error.txt                   |  0
 .../child-nested}/expected.html               |  0
 .../child-nested}/index.js                    |  0
 .../child-nested}/modules/x/child/child.html  |  0
 .../child-nested}/modules/x/child/child.js    |  0
 .../for-each-child-nested.html                |  0
 .../for-each-child-nested.js                  |  0
 .../item-and-index}/error.txt                 |  0
 .../item-and-index/expected.html              | 36 ++++++++++++++++
 .../item-and-index}/index.js                  |  0
 .../item-and-index/modules/x/child/child.html |  3 ++
 .../item-and-index/modules/x/child/child.js   |  3 ++
 .../modules/x/container/container.html        | 12 ++++++
 .../modules/x/container/container.js          |  5 +++
 .../nested}/config.json                       |  0
 .../nested}/error.txt                         |  0
 .../nested}/expected.html                     |  0
 .../nested}/index.js                          |  0
 .../x/for-each-nested/for-each-nested.html    |  0
 .../x/for-each-nested/for-each-nested.js      |  0
 .../static-content}/error.txt                 |  0
 .../static-content}/expected.html             |  0
 .../for-each-block/static-content/index.js    |  3 ++
 .../modules/x/container/container.html        |  0
 .../modules/x/container/container.js          |  0
 .../iterator-block/{ => basic}/config.json    |  0
 .../iterator-block/{ => basic}/error.txt      |  0
 .../iterator-block/{ => basic}/expected.html  |  0
 .../basic}/index.js                           |  0
 .../x/iterator-block/iterator-block.html      |  0
 .../x/iterator-block/iterator-block.js        |  0
 .../missing-value}/error.txt                  |  0
 .../missing-value}/expected.html              |  0
 .../{ => missing-value}/index.js              |  0
 .../x/iterator-block/iterator-block.html      |  0
 .../x/iterator-block/iterator-block.js        |  0
 .../multiple}/config.json                     |  0
 .../iterator-block/multiple/error.txt         |  0
 .../multiple}/expected.html                   |  0
 .../multiple}/index.js                        |  0
 .../x/iterator-block/iterator-block.html      |  0
 .../x/iterator-block/iterator-block.js        |  0
 .../iterator-block/variables/error.txt        |  0
 .../iterator-block/variables/expected.html    | 36 ++++++++++++++++
 .../iterator-block/variables/index.js         |  3 ++
 .../variables/modules/x/child/child.html      |  3 ++
 .../variables/modules/x/child/child.js        |  3 ++
 .../modules/x/container/container.html        | 12 ++++++
 .../modules/x/container/container.js          |  5 +++
 .../src/__tests__/utils/expected-failures.ts  |  2 -
 .../src/compile-template/index.ts             |  6 ++-
 .../src/compile-template/shared.ts            | 41 +++++++++++++++----
 .../src/compile-template/types.ts             |  1 +
 60 files changed, 164 insertions(+), 10 deletions(-)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/{ => basic}/config.json (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/{ => basic}/error.txt (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/{ => basic}/expected.html (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/{ => basic}/index.js (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/{ => basic}/modules/x/for-each-block/for-each-block.html (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/{ => basic}/modules/x/for-each-block/for-each-block.js (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{for-each-child-nested => for-each-block/child-nested}/config.json (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{for-each-child-nested => for-each-block/child-nested}/error.txt (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{for-each-child-nested => for-each-block/child-nested}/expected.html (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{for-each-child-nested => for-each-block/child-nested}/index.js (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{for-each-child-nested => for-each-block/child-nested}/modules/x/child/child.html (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{for-each-child-nested => for-each-block/child-nested}/modules/x/child/child.js (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{for-each-child-nested => for-each-block/child-nested}/modules/x/for-each-child-nested/for-each-child-nested.html (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{for-each-child-nested => for-each-block/child-nested}/modules/x/for-each-child-nested/for-each-child-nested.js (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{for-each-nested => for-each-block/item-and-index}/error.txt (100%)
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/expected.html
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{for-static-content => for-each-block/item-and-index}/index.js (100%)
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/modules/x/child/child.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/modules/x/child/child.js
 create mode 100755 packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/modules/x/container/container.html
 create mode 100755 packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/modules/x/container/container.js
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{for-each-nested => for-each-block/nested}/config.json (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{for-static-content => for-each-block/nested}/error.txt (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{for-each-nested => for-each-block/nested}/expected.html (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{for-each-nested => for-each-block/nested}/index.js (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{for-each-nested => for-each-block/nested}/modules/x/for-each-nested/for-each-nested.html (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{for-each-nested => for-each-block/nested}/modules/x/for-each-nested/for-each-nested.js (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{iterator-block-missing-value => for-each-block/static-content}/error.txt (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{for-static-content => for-each-block/static-content}/expected.html (100%)
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/static-content/index.js
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{for-static-content => for-each-block/static-content}/modules/x/container/container.html (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{for-static-content => for-each-block/static-content}/modules/x/container/container.js (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/{ => basic}/config.json (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/{ => basic}/error.txt (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/{ => basic}/expected.html (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{iterator-block-missing-value => iterator-block/basic}/index.js (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/{ => basic}/modules/x/iterator-block/iterator-block.html (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{iterator-block-missing-value => iterator-block/basic}/modules/x/iterator-block/iterator-block.js (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{iterator-blocks-multiple => iterator-block/missing-value}/error.txt (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{iterator-block-missing-value => iterator-block/missing-value}/expected.html (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/{ => missing-value}/index.js (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{iterator-block-missing-value => iterator-block/missing-value}/modules/x/iterator-block/iterator-block.html (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/{ => missing-value}/modules/x/iterator-block/iterator-block.js (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{iterator-blocks-multiple => iterator-block/multiple}/config.json (100%)
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/multiple/error.txt
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{iterator-blocks-multiple => iterator-block/multiple}/expected.html (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{iterator-blocks-multiple => iterator-block/multiple}/index.js (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{iterator-blocks-multiple => iterator-block/multiple}/modules/x/iterator-block/iterator-block.html (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/{iterator-blocks-multiple => iterator-block/multiple}/modules/x/iterator-block/iterator-block.js (100%)
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/error.txt
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/expected.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/index.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/modules/x/child/child.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/modules/x/child/child.js
 create mode 100755 packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/modules/x/container/container.html
 create mode 100755 packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/modules/x/container/container.js

diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/config.json b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/basic/config.json
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/config.json
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/basic/config.json
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/basic/error.txt
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/error.txt
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/basic/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/basic/expected.html
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/expected.html
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/basic/expected.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/basic/index.js
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/index.js
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/basic/index.js
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/modules/x/for-each-block/for-each-block.html b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/basic/modules/x/for-each-block/for-each-block.html
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/modules/x/for-each-block/for-each-block.html
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/basic/modules/x/for-each-block/for-each-block.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/modules/x/for-each-block/for-each-block.js b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/basic/modules/x/for-each-block/for-each-block.js
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/modules/x/for-each-block/for-each-block.js
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/basic/modules/x/for-each-block/for-each-block.js
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-child-nested/config.json b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/child-nested/config.json
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-each-child-nested/config.json
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/child-nested/config.json
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-child-nested/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/child-nested/error.txt
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-each-child-nested/error.txt
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/child-nested/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-child-nested/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/child-nested/expected.html
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-each-child-nested/expected.html
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/child-nested/expected.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-child-nested/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/child-nested/index.js
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-each-child-nested/index.js
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/child-nested/index.js
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-child-nested/modules/x/child/child.html b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/child-nested/modules/x/child/child.html
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-each-child-nested/modules/x/child/child.html
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/child-nested/modules/x/child/child.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-child-nested/modules/x/child/child.js b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/child-nested/modules/x/child/child.js
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-each-child-nested/modules/x/child/child.js
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/child-nested/modules/x/child/child.js
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-child-nested/modules/x/for-each-child-nested/for-each-child-nested.html b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/child-nested/modules/x/for-each-child-nested/for-each-child-nested.html
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-each-child-nested/modules/x/for-each-child-nested/for-each-child-nested.html
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/child-nested/modules/x/for-each-child-nested/for-each-child-nested.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-child-nested/modules/x/for-each-child-nested/for-each-child-nested.js b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/child-nested/modules/x/for-each-child-nested/for-each-child-nested.js
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-each-child-nested/modules/x/for-each-child-nested/for-each-child-nested.js
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/child-nested/modules/x/for-each-child-nested/for-each-child-nested.js
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-nested/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/error.txt
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-each-nested/error.txt
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/expected.html
new file mode 100644
index 0000000000..8e5795078d
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/expected.html
@@ -0,0 +1,36 @@
+<x-container>
+  <template shadowrootmode="open">
+    <ul>
+      <li data-index="0" data-item="one">
+        0 - one
+      </li>
+      <x-child data-index="0" data-item="one">
+        <template shadowrootmode="open">
+          <slot>
+          </slot>
+        </template>
+        0 - one
+      </x-child>
+      <li data-index="1" data-item="two">
+        1 - two
+      </li>
+      <x-child data-index="1" data-item="two">
+        <template shadowrootmode="open">
+          <slot>
+          </slot>
+        </template>
+        1 - two
+      </x-child>
+      <li data-index="2" data-item="three">
+        2 - three
+      </li>
+      <x-child data-index="2" data-item="three">
+        <template shadowrootmode="open">
+          <slot>
+          </slot>
+        </template>
+        2 - three
+      </x-child>
+    </ul>
+  </template>
+</x-container>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-static-content/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/index.js
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-static-content/index.js
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/index.js
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/modules/x/child/child.html b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/modules/x/child/child.html
new file mode 100644
index 0000000000..6806310398
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/modules/x/child/child.html
@@ -0,0 +1,3 @@
+<template>
+    <slot></slot>
+</template>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/modules/x/child/child.js b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/modules/x/child/child.js
new file mode 100644
index 0000000000..3f0d7e7e52
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/modules/x/child/child.js
@@ -0,0 +1,3 @@
+import { LightningElement } from 'lwc';
+
+export default class Child extends LightningElement {}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/modules/x/container/container.html b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/modules/x/container/container.html
new file mode 100755
index 0000000000..4b5dd8d38b
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/modules/x/container/container.html
@@ -0,0 +1,12 @@
+<template>
+    <ul>
+        <template for:each={items} for:item="item" for:index="index">
+            <li key={item} data-index={index} data-item={item}>
+                {index} - {item}
+            </li>
+            <x-child key={item} data-index={index} data-item={item}>
+                {index} - {item}
+            </x-child>
+        </template>
+    </ul>
+</template>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/modules/x/container/container.js b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/modules/x/container/container.js
new file mode 100755
index 0000000000..c45de77ad3
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/item-and-index/modules/x/container/container.js
@@ -0,0 +1,5 @@
+import { LightningElement } from 'lwc';
+
+export default class Container extends LightningElement {
+    items = ['one', 'two', 'three'];
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-nested/config.json b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/nested/config.json
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-each-nested/config.json
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/nested/config.json
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-static-content/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/nested/error.txt
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-static-content/error.txt
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/nested/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-nested/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/nested/expected.html
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-each-nested/expected.html
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/nested/expected.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-nested/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/nested/index.js
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-each-nested/index.js
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/nested/index.js
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-nested/modules/x/for-each-nested/for-each-nested.html b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/nested/modules/x/for-each-nested/for-each-nested.html
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-each-nested/modules/x/for-each-nested/for-each-nested.html
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/nested/modules/x/for-each-nested/for-each-nested.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-nested/modules/x/for-each-nested/for-each-nested.js b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/nested/modules/x/for-each-nested/for-each-nested.js
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-each-nested/modules/x/for-each-nested/for-each-nested.js
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/nested/modules/x/for-each-nested/for-each-nested.js
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block-missing-value/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/static-content/error.txt
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block-missing-value/error.txt
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/static-content/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-static-content/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/static-content/expected.html
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-static-content/expected.html
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/static-content/expected.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/static-content/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/static-content/index.js
new file mode 100644
index 0000000000..9763122105
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/static-content/index.js
@@ -0,0 +1,3 @@
+export const tagName = 'x-container';
+export { default } from 'x/container';
+export * from 'x/container';
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-static-content/modules/x/container/container.html b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/static-content/modules/x/container/container.html
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-static-content/modules/x/container/container.html
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/static-content/modules/x/container/container.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/for-static-content/modules/x/container/container.js b/packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/static-content/modules/x/container/container.js
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/for-static-content/modules/x/container/container.js
rename to packages/@lwc/engine-server/src/__tests__/fixtures/for-each-block/static-content/modules/x/container/container.js
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/config.json b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/basic/config.json
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/config.json
rename to packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/basic/config.json
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/basic/error.txt
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/error.txt
rename to packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/basic/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/basic/expected.html
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/expected.html
rename to packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/basic/expected.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block-missing-value/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/basic/index.js
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block-missing-value/index.js
rename to packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/basic/index.js
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/modules/x/iterator-block/iterator-block.html b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/basic/modules/x/iterator-block/iterator-block.html
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/modules/x/iterator-block/iterator-block.html
rename to packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/basic/modules/x/iterator-block/iterator-block.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block-missing-value/modules/x/iterator-block/iterator-block.js b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/basic/modules/x/iterator-block/iterator-block.js
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block-missing-value/modules/x/iterator-block/iterator-block.js
rename to packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/basic/modules/x/iterator-block/iterator-block.js
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-blocks-multiple/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/missing-value/error.txt
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/iterator-blocks-multiple/error.txt
rename to packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/missing-value/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block-missing-value/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/missing-value/expected.html
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block-missing-value/expected.html
rename to packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/missing-value/expected.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/missing-value/index.js
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/index.js
rename to packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/missing-value/index.js
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block-missing-value/modules/x/iterator-block/iterator-block.html b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/missing-value/modules/x/iterator-block/iterator-block.html
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block-missing-value/modules/x/iterator-block/iterator-block.html
rename to packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/missing-value/modules/x/iterator-block/iterator-block.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/modules/x/iterator-block/iterator-block.js b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/missing-value/modules/x/iterator-block/iterator-block.js
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/modules/x/iterator-block/iterator-block.js
rename to packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/missing-value/modules/x/iterator-block/iterator-block.js
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-blocks-multiple/config.json b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/multiple/config.json
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/iterator-blocks-multiple/config.json
rename to packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/multiple/config.json
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/multiple/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/multiple/error.txt
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-blocks-multiple/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/multiple/expected.html
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/iterator-blocks-multiple/expected.html
rename to packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/multiple/expected.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-blocks-multiple/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/multiple/index.js
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/iterator-blocks-multiple/index.js
rename to packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/multiple/index.js
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-blocks-multiple/modules/x/iterator-block/iterator-block.html b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/multiple/modules/x/iterator-block/iterator-block.html
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/iterator-blocks-multiple/modules/x/iterator-block/iterator-block.html
rename to packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/multiple/modules/x/iterator-block/iterator-block.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-blocks-multiple/modules/x/iterator-block/iterator-block.js b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/multiple/modules/x/iterator-block/iterator-block.js
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/iterator-blocks-multiple/modules/x/iterator-block/iterator-block.js
rename to packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/multiple/modules/x/iterator-block/iterator-block.js
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/error.txt
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/expected.html
new file mode 100644
index 0000000000..e3ddeb9697
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/expected.html
@@ -0,0 +1,36 @@
+<x-container>
+  <template shadowrootmode="open">
+    <ul>
+      <li data-first="true" data-index="0" data-item="one" data-last="false">
+        0 - one - true - false
+      </li>
+      <x-child data-first="true" data-index="0" data-item="one" data-last="false">
+        <template shadowrootmode="open">
+          <slot>
+          </slot>
+        </template>
+        0 - one - true - false
+      </x-child>
+      <li data-first="false" data-index="1" data-item="two" data-last="false">
+        1 - two - false - false
+      </li>
+      <x-child data-first="false" data-index="1" data-item="two" data-last="false">
+        <template shadowrootmode="open">
+          <slot>
+          </slot>
+        </template>
+        1 - two - false - false
+      </x-child>
+      <li data-first="false" data-index="2" data-item="three" data-last="true">
+        2 - three - false - true
+      </li>
+      <x-child data-first="false" data-index="2" data-item="three" data-last="true">
+        <template shadowrootmode="open">
+          <slot>
+          </slot>
+        </template>
+        2 - three - false - true
+      </x-child>
+    </ul>
+  </template>
+</x-container>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/index.js
new file mode 100644
index 0000000000..9763122105
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/index.js
@@ -0,0 +1,3 @@
+export const tagName = 'x-container';
+export { default } from 'x/container';
+export * from 'x/container';
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/modules/x/child/child.html b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/modules/x/child/child.html
new file mode 100644
index 0000000000..6806310398
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/modules/x/child/child.html
@@ -0,0 +1,3 @@
+<template>
+    <slot></slot>
+</template>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/modules/x/child/child.js b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/modules/x/child/child.js
new file mode 100644
index 0000000000..3f0d7e7e52
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/modules/x/child/child.js
@@ -0,0 +1,3 @@
+import { LightningElement } from 'lwc';
+
+export default class Child extends LightningElement {}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/modules/x/container/container.html b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/modules/x/container/container.html
new file mode 100755
index 0000000000..fb26a708a1
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/modules/x/container/container.html
@@ -0,0 +1,12 @@
+<template>
+    <ul>
+        <template iterator:it={items}>
+            <li key={it.value} data-index={it.index} data-item={it.value} data-first={it.first} data-last={it.last}>
+                {it.index} - {it.value} - {it.first} - {it.last}
+            </li>
+            <x-child key={it.value} data-index={it.index} data-item={it.value} data-first={it.first} data-last={it.last}>
+                {it.index} - {it.value} - {it.first} - {it.last}
+            </x-child>
+        </template>
+    </ul>
+</template>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/modules/x/container/container.js b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/modules/x/container/container.js
new file mode 100755
index 0000000000..c45de77ad3
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/iterator-block/variables/modules/x/container/container.js
@@ -0,0 +1,5 @@
+import { LightningElement } from 'lwc';
+
+export default class Container extends LightningElement {
+    items = ['one', 'two', 'three'];
+}
diff --git a/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts b/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts
index 8a090f1ecc..fd8726a702 100644
--- a/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts
+++ b/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts
@@ -8,7 +8,6 @@
 // We should slowly drive down these test failures or at least document where we expect the failures
 // TODO [#4815]: enable all SSR v2 tests
 export const expectedFailures = new Set([
-    'adjacent-text-nodes/preserve-comments-off/deep-for-each-with-rendered-item/index.js',
     'attribute-aria/dynamic/index.js',
     'attribute-class/with-scoped-styles-only-in-child/dynamic/index.js',
     'attribute-class/with-scoped-styles/dynamic/index.js',
@@ -25,7 +24,6 @@ export const expectedFailures = new Set([
     'render-dynamic-value/index.js',
     'scoped-slots/advanced/index.js',
     'scoped-slots/expression/index.js',
-    'scoped-slots/for-each/index.js',
     'scoped-slots/mixed-with-light-dom-slots-inside/index.js',
     'scoped-slots/mixed-with-light-dom-slots-outside/index.js',
     'slot-forwarding/scoped-slots/index.js',
diff --git a/packages/@lwc/ssr-compiler/src/compile-template/index.ts b/packages/@lwc/ssr-compiler/src/compile-template/index.ts
index 2af47535ac..eec7275312 100644
--- a/packages/@lwc/ssr-compiler/src/compile-template/index.ts
+++ b/packages/@lwc/ssr-compiler/src/compile-template/index.ts
@@ -107,8 +107,12 @@ export default function compileTemplate(
     const preserveComments = !!root.directives.find(
         (directive) => directive.name === 'PreserveComments'
     )?.value?.value;
+    const experimentalComplexExpressions = Boolean(options.experimentalComplexExpressions);
 
-    const { addImport, getImports, statements } = templateIrToEsTree(root!, { preserveComments });
+    const { addImport, getImports, statements } = templateIrToEsTree(root!, {
+        preserveComments,
+        experimentalComplexExpressions,
+    });
     addImport(['renderStylesheets', 'hasScopedStaticStylesheets']);
     for (const [imports, source] of getStylesheetImports(filename)) {
         addImport(imports, source);
diff --git a/packages/@lwc/ssr-compiler/src/compile-template/shared.ts b/packages/@lwc/ssr-compiler/src/compile-template/shared.ts
index ed21898c47..37569670a6 100644
--- a/packages/@lwc/ssr-compiler/src/compile-template/shared.ts
+++ b/packages/@lwc/ssr-compiler/src/compile-template/shared.ts
@@ -7,7 +7,6 @@
 
 import { builders as b, is } from 'estree-toolkit';
 import { normalizeStyleAttributeValue, StringReplace, StringTrim } from '@lwc/shared';
-
 import { isValidES3Identifier } from '@babel/types';
 import { expressionIrToEs } from './expression';
 import type { TransformerContext } from './types';
@@ -74,9 +73,20 @@ function getRootMemberExpression(node: EsMemberExpression): EsMemberExpression {
     return node.object.type === 'MemberExpression' ? getRootMemberExpression(node.object) : node;
 }
 
-function getRootIdentifier(node: EsMemberExpression): EsIdentifier | null {
+function getRootIdentifier(node: EsMemberExpression, cxt: TransformerContext): EsIdentifier | null {
     const rootMemberExpression = getRootMemberExpression(node);
-    return is.identifier(rootMemberExpression?.object) ? rootMemberExpression.object : null;
+    if (is.identifier(rootMemberExpression.object)) {
+        return rootMemberExpression.object;
+    }
+    if (cxt.templateOptions.experimentalComplexExpressions) {
+        // TODO [#3370]: Implement complex template expressions
+        return null;
+    }
+    // Should be impossible to hit, at least until we implement complex template expressions
+    /* v8 ignore next */
+    throw new Error(
+        `Invalid expression, must be an Identifier, found type="${rootMemberExpression.type}": \`${JSON.stringify(rootMemberExpression)}\``
+    );
 }
 
 /**
@@ -85,12 +95,29 @@ function getRootIdentifier(node: EsMemberExpression): EsIdentifier | null {
  * inside a `for:each` block then the `foo` variable may refer to the scoped `foo`,
  * e.g. `<template for:each={foos} for:item="foo">`
  * @param expression
+ * @param cxt
  */
 export function getScopedExpression(expression: EsExpression, cxt: TransformerContext) {
-    const scopeReferencedId = is.memberExpression(expression)
-        ? getRootIdentifier(expression)
-        : null;
-    return cxt.isLocalVar(scopeReferencedId?.name)
+    let scopeReferencedId: EsExpression | null = null;
+    if (is.memberExpression(expression)) {
+        // e.g. `foo.bar` -> scopeReferencedId is `foo`
+        scopeReferencedId = getRootIdentifier(expression, cxt);
+    } else if (is.identifier(expression)) {
+        // e.g. `foo` -> scopeReferencedId is `foo`
+        scopeReferencedId = expression;
+    }
+    if (scopeReferencedId === null) {
+        if (cxt.templateOptions.experimentalComplexExpressions) {
+            // TODO [#3370]: Implement complex template expressions
+            return expression;
+        }
+        // Should be impossible to hit, at least until we implement complex template expressions
+        /* v8 ignore next */
+        throw new Error(
+            `Invalid expression, must be a MemberExpression or Identifier, found type="${expression.type}": \`${JSON.stringify(expression)}\``
+        );
+    }
+    return cxt.isLocalVar(scopeReferencedId.name)
         ? expression
         : b.memberExpression(b.identifier('instance'), expression);
 }
diff --git a/packages/@lwc/ssr-compiler/src/compile-template/types.ts b/packages/@lwc/ssr-compiler/src/compile-template/types.ts
index 4f344d58e0..de6629b221 100644
--- a/packages/@lwc/ssr-compiler/src/compile-template/types.ts
+++ b/packages/@lwc/ssr-compiler/src/compile-template/types.ts
@@ -28,4 +28,5 @@ export interface TransformerContext {
 
 export interface TemplateOpts {
     preserveComments: boolean;
+    experimentalComplexExpressions: boolean;
 }

From b3e5ca45304367c3578e53447973eb4423b85381 Mon Sep 17 00:00:00 2001
From: Nolan Lawson <nlawson@salesforce.com>
Date: Tue, 3 Dec 2024 12:16:45 -0800
Subject: [PATCH 06/12] refactor(ssr): reduce duplicated text rendering logic
 (#4991)

Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
---
 .../src/compile-template/transformers/text.ts    | 16 +++++++---------
 packages/@lwc/ssr-runtime/src/index.ts           |  1 +
 .../@lwc/ssr-runtime/src/render-text-content.ts  | 16 ++++++++++++++++
 3 files changed, 24 insertions(+), 9 deletions(-)
 create mode 100644 packages/@lwc/ssr-runtime/src/render-text-content.ts

diff --git a/packages/@lwc/ssr-compiler/src/compile-template/transformers/text.ts b/packages/@lwc/ssr-compiler/src/compile-template/transformers/text.ts
index baa7a01afc..f55d9ed6e2 100644
--- a/packages/@lwc/ssr-compiler/src/compile-template/transformers/text.ts
+++ b/packages/@lwc/ssr-compiler/src/compile-template/transformers/text.ts
@@ -10,7 +10,10 @@ import { esTemplateWithYield } from '../../estemplate';
 import { expressionIrToEs } from '../expression';
 
 import { bYieldTextContent, isLastConcatenatedNode } from '../adjacent-text-nodes';
-import type { Statement as EsStatement } from 'estree';
+import type {
+    Statement as EsStatement,
+    ExpressionStatement as EsExpressionStatement,
+} from 'estree';
 import type {
     ComplexExpression as IrComplexExpression,
     Expression as IrExpression,
@@ -21,20 +24,15 @@ import type { Transformer } from '../types';
 
 const bBufferTextContent = esTemplateWithYield`
     didBufferTextContent = true;
-    {
-        const value = ${/* string value */ is.expression};
-        // Using non strict equality to align with original implementation (ex. undefined == null)
-        // See: https://github.com/salesforce/lwc/blob/348130f/packages/%40lwc/engine-core/src/framework/api.ts#L548
-        textContentBuffer += value == null ? '' : String(value);
-    }
-`<EsStatement[]>;
+    textContentBuffer += massageTextContent(${/* string value */ is.expression});
+`<EsExpressionStatement[]>;
 
 function isLiteral(node: IrLiteral | IrExpression | IrComplexExpression): node is IrLiteral {
     return node.type === 'Literal';
 }
 
 export const Text: Transformer<IrText> = function Text(node, cxt): EsStatement[] {
-    cxt.import('htmlEscape');
+    cxt.import(['htmlEscape', 'massageTextContent']);
 
     const isLastInSeries = isLastConcatenatedNode(cxt);
 
diff --git a/packages/@lwc/ssr-runtime/src/index.ts b/packages/@lwc/ssr-runtime/src/index.ts
index ef329a2097..6c9a734774 100644
--- a/packages/@lwc/ssr-runtime/src/index.ts
+++ b/packages/@lwc/ssr-runtime/src/index.ts
@@ -31,6 +31,7 @@ export {
     // renderComponent is an alias for serverSideRenderComponent
     serverSideRenderComponent as renderComponent,
 } from './render';
+export { massageTextContent } from './render-text-content';
 export { hasScopedStaticStylesheets, renderStylesheets } from './styles';
 export { toIteratorDirective } from './to-iterator-directive';
 export { validateStyleTextContents } from './validate-style-text-contents';
diff --git a/packages/@lwc/ssr-runtime/src/render-text-content.ts b/packages/@lwc/ssr-runtime/src/render-text-content.ts
new file mode 100644
index 0000000000..4151f18db5
--- /dev/null
+++ b/packages/@lwc/ssr-runtime/src/render-text-content.ts
@@ -0,0 +1,16 @@
+/*
+ * Copyright (c) 2024, Salesforce, Inc.
+ * All rights reserved.
+ * SPDX-License-Identifier: MIT
+ * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
+ */
+
+/**
+ * Given an object, render it for use as a text content node.
+ * @param value
+ */
+export function massageTextContent(value: unknown): string {
+    // Using non strict equality to align with original implementation (ex. undefined == null)
+    // See: https://github.com/salesforce/lwc/blob/348130f/packages/%40lwc/engine-core/src/framework/api.ts#L548
+    return value == null ? '' : String(value);
+}

From 9dbafa855c464e5ab7e7caa8b046cc870c97a93f Mon Sep 17 00:00:00 2001
From: Will Harney <62956339+wjhsf@users.noreply.github.com>
Date: Tue, 3 Dec 2024 15:26:57 -0500
Subject: [PATCH 07/12] fix(perf): avoid creating unnecessary sets @W-17361878
 (#4996)

* fix(perf): avoid creating unnecessary sets

* Update packages/@lwc/engine-core/src/framework/hydration.ts

* Revert "Update packages/@lwc/engine-core/src/framework/hydration.ts"

This reverts commit d33d20c1a7c5eec5f55099a93c0299eba6ade99a.

* refactor: remove unnecessary else block nesting

* chore: call classes classes, not nodes
---
 .../engine-core/src/framework/hydration.ts    | 63 +++++++++++--------
 1 file changed, 38 insertions(+), 25 deletions(-)

diff --git a/packages/@lwc/engine-core/src/framework/hydration.ts b/packages/@lwc/engine-core/src/framework/hydration.ts
index e04f1d9f73..1a924a3071 100644
--- a/packages/@lwc/engine-core/src/framework/hydration.ts
+++ b/packages/@lwc/engine-core/src/framework/hydration.ts
@@ -63,6 +63,11 @@ import type {
 import type { VM } from './vm';
 import type { RendererAPI } from './renderer';
 
+type Classes = Omit<Set<string>, 'add'>;
+
+// Used as a perf optimization to avoid creating and discarding sets unnecessarily.
+const EMPTY_SET: Classes = new Set<string>();
+
 // These values are the ones from Node.nodeType (https://developer.mozilla.org/en-US/docs/Web/API/Node/nodeType)
 const enum EnvNodeTypes {
     ELEMENT = 1,
@@ -618,6 +623,23 @@ function validateAttrs(
     return nodesAreCompatible;
 }
 
+function checkClassesCompatibility(first: Classes, second: Classes): boolean {
+    if (first.size !== second.size) {
+        return false;
+    }
+    for (const f of first) {
+        if (!second.has(f)) {
+            return false;
+        }
+    }
+    for (const s of second) {
+        if (!first.has(s)) {
+            return false;
+        }
+    }
+    return true;
+}
+
 function validateClassAttr(
     vnode: VBaseElement | VStatic,
     elm: Element,
@@ -634,16 +656,18 @@ function validateClassAttr(
 
     // Use a Set because we don't care to validate mismatches for 1) different ordering in SSR vs CSR, or 2)
     // duplicated class names. These don't have an effect on rendered styles.
-    const elmClasses = new Set(ArrayFrom(elm.classList));
-    let vnodeClasses: Set<string>;
+    const elmClasses = elm.classList.length ? new Set(ArrayFrom(elm.classList)) : EMPTY_SET;
+    let vnodeClasses: Classes;
 
     if (!isUndefined(className)) {
         // ignore empty spaces entirely, filter them out using `filter(..., Boolean)`
-        vnodeClasses = new Set(ArrayFilter.call(StringSplit.call(className, /\s+/), Boolean));
+        const classes = ArrayFilter.call(StringSplit.call(className, /\s+/), Boolean);
+        vnodeClasses = classes.length ? new Set(classes) : EMPTY_SET;
     } else if (!isUndefined(classMap)) {
-        vnodeClasses = new Set(keys(classMap));
+        const classes = keys(classMap);
+        vnodeClasses = classes.length ? new Set(classes) : EMPTY_SET;
     } else {
-        vnodeClasses = new Set();
+        vnodeClasses = EMPTY_SET;
     }
 
     // ---------- Step 2: handle the scope tokens
@@ -658,7 +682,11 @@ function validateClassAttr(
     // Consequently, hydration mismatches will occur if scoped CSS token classnames
     // are rendered during SSR. This needs to be accounted for when validating.
     if (!isNull(scopeToken)) {
-        vnodeClasses.add(scopeToken);
+        if (vnodeClasses === EMPTY_SET) {
+            vnodeClasses = new Set([scopeToken]);
+        } else {
+            (vnodeClasses as Set<string>).add(scopeToken);
+        }
     }
 
     // This tells us which `*-host` scope token was rendered to the element's class.
@@ -672,25 +700,10 @@ function validateClassAttr(
 
     // ---------- Step 3: check for compatibility
 
-    let nodesAreCompatible = true;
+    const classesAreCompatible = checkClassesCompatibility(vnodeClasses, elmClasses);
 
-    if (vnodeClasses.size !== elmClasses.size) {
-        nodesAreCompatible = false;
-    } else {
-        for (const vnodeClass of vnodeClasses) {
-            if (!elmClasses.has(vnodeClass)) {
-                nodesAreCompatible = false;
-            }
-        }
-        for (const elmClass of elmClasses) {
-            if (!vnodeClasses.has(elmClass)) {
-                nodesAreCompatible = false;
-            }
-        }
-    }
-
-    if (process.env.NODE_ENV !== 'production' && !nodesAreCompatible) {
-        const prettyPrint = (set: Set<string>) =>
+    if (process.env.NODE_ENV !== 'production' && !classesAreCompatible) {
+        const prettyPrint = (set: Classes) =>
             JSON.stringify(ArrayJoin.call(ArraySort.call(ArrayFrom(set)), ' '));
         logWarn(
             `Mismatch hydrating element <${getProperty(
@@ -703,7 +716,7 @@ function validateClassAttr(
         );
     }
 
-    return nodesAreCompatible;
+    return classesAreCompatible;
 }
 
 function validateStyleAttr(

From 71b929eae0deea658323469f13350307e5067e0c Mon Sep 17 00:00:00 2001
From: Will Harney <62956339+wjhsf@users.noreply.github.com>
Date: Tue, 3 Dec 2024 16:39:47 -0500
Subject: [PATCH 08/12] fix(ssr): slightly address slots not at top level
 (#4997)

slightly break context providers
---
 .../ssr-compiler/src/__tests__/utils/expected-failures.ts    | 5 +----
 packages/@lwc/ssr-compiler/src/compile-template/index.ts     | 4 +---
 .../transformers/component/slotted-content.ts                | 5 +----
 3 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts b/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts
index fd8726a702..f46b15291e 100644
--- a/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts
+++ b/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts
@@ -17,9 +17,8 @@ export const expectedFailures = new Set([
     'attribute-namespace/index.js',
     'attribute-style/basic/index.js',
     'attribute-style/dynamic/index.js',
-    'dynamic-slots/index.js',
+    'context-slotted/index.js',
     'exports/component-as-default/index.js',
-    'if-conditional-slot-content/index.js',
     'known-boolean-attributes/default-def-html-attributes/static-on-component/index.js',
     'render-dynamic-value/index.js',
     'scoped-slots/advanced/index.js',
@@ -27,10 +26,8 @@ export const expectedFailures = new Set([
     'scoped-slots/mixed-with-light-dom-slots-inside/index.js',
     'scoped-slots/mixed-with-light-dom-slots-outside/index.js',
     'slot-forwarding/scoped-slots/index.js',
-    'slot-not-at-top-level/advanced/ifTrue/shadow/index.js',
     'slot-not-at-top-level/advanced/lwcIf/light/index.js',
     'slot-not-at-top-level/advanced/lwcIf/shadow/index.js',
-    'slot-not-at-top-level/ifTrue/shadow/index.js',
     'slot-not-at-top-level/lwcIf/light/index.js',
     'slot-not-at-top-level/lwcIf/shadow/index.js',
     'superclass/render-in-superclass/no-template-in-subclass/index.js',
diff --git a/packages/@lwc/ssr-compiler/src/compile-template/index.ts b/packages/@lwc/ssr-compiler/src/compile-template/index.ts
index eec7275312..f99eaccba0 100644
--- a/packages/@lwc/ssr-compiler/src/compile-template/index.ts
+++ b/packages/@lwc/ssr-compiler/src/compile-template/index.ts
@@ -55,9 +55,7 @@ const bExportTemplate = esTemplate`
         if (!isLightDom) {
             yield '</template>';
             if (shadowSlottedContent) {
-                // instance must be passed in; this is used to establish the contextful relationship
-                // between context provider (aka parent component) and context consumer (aka slotted content)
-                yield* shadowSlottedContent(instance);
+                yield* shadowSlottedContent();
             }
         }
     }
diff --git a/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/slotted-content.ts b/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/slotted-content.ts
index 5e981b7029..ef30633ec3 100644
--- a/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/slotted-content.ts
+++ b/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/slotted-content.ts
@@ -34,10 +34,7 @@ import type { TransformerContext } from '../../types';
 
 const bGenerateSlottedContent = esTemplateWithYield`
         const shadowSlottedContent = ${/* hasShadowSlottedContent */ is.literal}
-            ? async function* generateSlottedContent(instance) {
-                // The 'instance' variable is shadowed here so that a contextful relationship
-                // is established between components rendered in slotted content & the "parent"
-                // component that contains the <slot>.
+            ? async function* generateShadowSlottedContent() {
                 ${/* shadow slot content */ is.statement}
             } 
             // Avoid creating the object unnecessarily

From 6283e34f882c76caffb5f3183ef873038040df02 Mon Sep 17 00:00:00 2001
From: Will Harney <62956339+wjhsf@users.noreply.github.com>
Date: Wed, 4 Dec 2024 12:26:13 -0500
Subject: [PATCH 09/12] feat(ssr): enable `@wire` on getters/setters (#4986)

* fix(ssr): adjacent text in `<template>`s

Co-Authored-By: Will Harney <62956339+wjhsf@users.noreply.github.com>
Co-Authored-By: John Hefferman <jhefferman@salesforce.com>

* test: fix expected failures

* test(snapshots): add helpfuler message when error/expected swap

* fix(ssr): support @wire-decorated getters/setters

* chore: add test for edge case

* test(ssr): add test for differently-wired getter/setter

* Update packages/@lwc/ssr-compiler/src/compile-js/index.ts

Co-authored-by: Nolan Lawson <nlawson@salesforce.com>

* fix(ssr): use structured clone when converting wired getter to prop

* test: add tests

* chore: add comment

---------

Co-authored-by: Nolan Lawson <nlawson@salesforce.com>
Co-authored-by: John Hefferman <jhefferman@salesforce.com>
---
 .../fixtures/wire/collision/get-set/error.txt |  0
 .../wire/collision/get-set/expected.html      |  7 ++++
 .../fixtures/wire/collision/get-set/index.js  |  3 ++
 .../get-set/modules/x/adapter/adapter.js      | 13 ++++++
 .../get-set/modules/x/wire/wire.html          |  3 ++
 .../collision/get-set/modules/x/wire/wire.js  | 13 ++++++
 .../wire/collision/method-prop/error.txt      |  0
 .../wire/collision/method-prop/expected.html  |  5 +++
 .../wire/collision/method-prop/index.js       |  3 ++
 .../method-prop/modules/x/wire/adapter.js     | 13 ++++++
 .../method-prop/modules/x/wire/wire.html      |  3 ++
 .../method-prop/modules/x/wire/wire.js        | 12 ++++++
 .../wire/collision/prop-method/error.txt      |  0
 .../wire/collision/prop-method/expected.html  |  5 +++
 .../wire/collision/prop-method/index.js       |  3 ++
 .../prop-method/modules/x/wire/adapter.js     | 13 ++++++
 .../prop-method/modules/x/wire/wire.html      |  3 ++
 .../prop-method/modules/x/wire/wire.js        | 12 ++++++
 .../error.txt                                 |  1 +
 .../expected.html                             |  0
 .../index.js                                  |  3 ++
 .../modules/x/adapter/adapter.js              | 13 ++++++
 .../modules/x/wire/wire.html                  |  4 ++
 .../modules/x/wire/wire.js                    | 13 ++++++
 .../__tests__/fixtures/wire/get-set/error.txt |  0
 .../fixtures/wire/get-set/expected.html       |  5 +++
 .../__tests__/fixtures/wire/get-set/index.js  |  3 ++
 .../wire/get-set/modules/x/wire/adapter.js    | 13 ++++++
 .../wire/get-set/modules/x/wire/wire.html     |  3 ++
 .../wire/get-set/modules/x/wire/wire.js       | 41 +++++++++++++++++++
 .../src/__tests__/utils/expected-failures.ts  |  2 +
 .../@lwc/ssr-compiler/src/compile-js/index.ts | 34 ++++++++++-----
 32 files changed, 236 insertions(+), 10 deletions(-)
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/error.txt
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/expected.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/index.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/modules/x/adapter/adapter.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/modules/x/wire/wire.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/modules/x/wire/wire.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/error.txt
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/expected.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/index.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/modules/x/wire/adapter.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/modules/x/wire/wire.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/modules/x/wire/wire.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/error.txt
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/expected.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/index.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/modules/x/wire/adapter.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/modules/x/wire/wire.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/modules/x/wire/wire.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/error.txt
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/expected.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/index.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/modules/x/adapter/adapter.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/modules/x/wire/wire.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/modules/x/wire/wire.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/error.txt
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/expected.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/index.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/modules/x/wire/adapter.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/modules/x/wire/wire.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/modules/x/wire/wire.js

diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/error.txt
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/expected.html
new file mode 100644
index 0000000000..430f214a18
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/expected.html
@@ -0,0 +1,7 @@
+<x-wire>
+  <template shadowrootmode="open">
+    <div>
+      Wired? set
+    </div>
+  </template>
+</x-wire>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/index.js
new file mode 100644
index 0000000000..fafb890973
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/index.js
@@ -0,0 +1,3 @@
+export const tagName = 'x-wire';
+export { default } from 'x/wire';
+export * from 'x/wire';
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/modules/x/adapter/adapter.js b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/modules/x/adapter/adapter.js
new file mode 100644
index 0000000000..796bad8624
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/modules/x/adapter/adapter.js
@@ -0,0 +1,13 @@
+export class Adapter {
+    constructor(dataCallback) {
+        this.callback = dataCallback;
+    }
+
+    connect() {}
+
+    update(cfg) {
+        this.callback(cfg.value);
+    }
+
+    disconnect() {}
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/modules/x/wire/wire.html b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/modules/x/wire/wire.html
new file mode 100644
index 0000000000..54ed2a3a60
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/modules/x/wire/wire.html
@@ -0,0 +1,3 @@
+<template>
+  <div>Wired? {wired}</div>
+</template>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/modules/x/wire/wire.js b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/modules/x/wire/wire.js
new file mode 100644
index 0000000000..b390928c83
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/get-set/modules/x/wire/wire.js
@@ -0,0 +1,13 @@
+import { wire, LightningElement } from 'lwc';
+import { Adapter } from 'x/adapter';
+export default class Test extends LightningElement {
+    @wire(Adapter, { value: 'get' })
+    get wired() {
+        throw new Error('get wired!');
+    }
+
+    @wire(Adapter, { value: 'set' })
+    set wired(val) {
+        throw new Error('set wired!');
+    }
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/error.txt
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/expected.html
new file mode 100644
index 0000000000..ca77f1f1f5
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/expected.html
@@ -0,0 +1,5 @@
+<x-wire>
+  <template shadowrootmode="open">
+    propAndMethod
+  </template>
+</x-wire>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/index.js
new file mode 100644
index 0000000000..fafb890973
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/index.js
@@ -0,0 +1,3 @@
+export const tagName = 'x-wire';
+export { default } from 'x/wire';
+export * from 'x/wire';
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/modules/x/wire/adapter.js b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/modules/x/wire/adapter.js
new file mode 100644
index 0000000000..b212b22d3f
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/modules/x/wire/adapter.js
@@ -0,0 +1,13 @@
+export class adapter {
+    constructor(dataCallback) {
+        this.dc = dataCallback;
+    }
+
+    connect() {}
+
+    update(config) {
+        this.dc(config.name);
+    }
+
+    disconnect() {}
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/modules/x/wire/wire.html b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/modules/x/wire/wire.html
new file mode 100644
index 0000000000..517a242640
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/modules/x/wire/wire.html
@@ -0,0 +1,3 @@
+<template>
+    {propAndMethod}
+</template>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/modules/x/wire/wire.js b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/modules/x/wire/wire.js
new file mode 100644
index 0000000000..cf88ee0998
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/method-prop/modules/x/wire/wire.js
@@ -0,0 +1,12 @@
+import { LightningElement, wire } from 'lwc';
+
+import { adapter } from './adapter';
+
+export default class Wire extends LightningElement {
+    propAndMethod() {
+        throw new Error('should not be called');
+    }
+
+    @wire(adapter, { name: 'propAndMethod' })
+    propAndMethod;
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/error.txt
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/expected.html
new file mode 100644
index 0000000000..ca77f1f1f5
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/expected.html
@@ -0,0 +1,5 @@
+<x-wire>
+  <template shadowrootmode="open">
+    propAndMethod
+  </template>
+</x-wire>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/index.js
new file mode 100644
index 0000000000..fafb890973
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/index.js
@@ -0,0 +1,3 @@
+export const tagName = 'x-wire';
+export { default } from 'x/wire';
+export * from 'x/wire';
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/modules/x/wire/adapter.js b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/modules/x/wire/adapter.js
new file mode 100644
index 0000000000..b212b22d3f
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/modules/x/wire/adapter.js
@@ -0,0 +1,13 @@
+export class adapter {
+    constructor(dataCallback) {
+        this.dc = dataCallback;
+    }
+
+    connect() {}
+
+    update(config) {
+        this.dc(config.name);
+    }
+
+    disconnect() {}
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/modules/x/wire/wire.html b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/modules/x/wire/wire.html
new file mode 100644
index 0000000000..517a242640
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/modules/x/wire/wire.html
@@ -0,0 +1,3 @@
+<template>
+    {propAndMethod}
+</template>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/modules/x/wire/wire.js b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/modules/x/wire/wire.js
new file mode 100644
index 0000000000..1e06f98e48
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/collision/prop-method/modules/x/wire/wire.js
@@ -0,0 +1,12 @@
+import { LightningElement, wire } from 'lwc';
+
+import { adapter } from './adapter';
+
+export default class Wire extends LightningElement {
+    @wire(adapter, { name: 'propAndMethod' })
+    propAndMethod;
+
+    propAndMethod() {
+        throw new Error('should not be called');
+    }
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/error.txt
new file mode 100644
index 0000000000..cefaa71e41
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/error.txt
@@ -0,0 +1 @@
+Cannot assign to read only property 'wired' of object '[object Object]'
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/expected.html
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/index.js
new file mode 100644
index 0000000000..fafb890973
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/index.js
@@ -0,0 +1,3 @@
+export const tagName = 'x-wire';
+export { default } from 'x/wire';
+export * from 'x/wire';
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/modules/x/adapter/adapter.js b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/modules/x/adapter/adapter.js
new file mode 100644
index 0000000000..2259041fc5
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/modules/x/adapter/adapter.js
@@ -0,0 +1,13 @@
+export class Adapter {
+    constructor(dataCallback) {
+        this.callback = dataCallback;
+    }
+
+    connect() {}
+
+    update() {
+        this.callback(true);
+    }
+
+    disconnect() {}
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/modules/x/wire/wire.html b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/modules/x/wire/wire.html
new file mode 100644
index 0000000000..fc94c85c96
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/modules/x/wire/wire.html
@@ -0,0 +1,4 @@
+<template>
+  <div>Wired? {wiredProp}</div>
+  <div>Using method? {methodUsed}</div>
+</template>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/modules/x/wire/wire.js b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/modules/x/wire/wire.js
new file mode 100644
index 0000000000..470b160776
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/errors/throws-when-colliding-prop-then-method/modules/x/wire/wire.js
@@ -0,0 +1,13 @@
+import { wire, LightningElement } from 'lwc';
+import { Adapter } from 'x/adapter';
+export default class Test extends LightningElement {
+    methodUsed = false;
+
+    @wire(Adapter, { key1: '$prop1', key2: ['fixed', 'array'] })
+    wired;
+
+    @wire(Adapter, { key1: '$prop1', key2: ['fixed', 'array'] })
+    wired(val) {
+        this.methodUsed = val;
+    }
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/error.txt
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/expected.html
new file mode 100644
index 0000000000..ed0cb1dd75
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/expected.html
@@ -0,0 +1,5 @@
+<x-wire>
+  <template shadowrootmode="open">
+    getterOnly setterOnly getterWithSetter setterWithGetter bothDecorated
+  </template>
+</x-wire>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/index.js
new file mode 100644
index 0000000000..fafb890973
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/index.js
@@ -0,0 +1,3 @@
+export const tagName = 'x-wire';
+export { default } from 'x/wire';
+export * from 'x/wire';
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/modules/x/wire/adapter.js b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/modules/x/wire/adapter.js
new file mode 100644
index 0000000000..b212b22d3f
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/modules/x/wire/adapter.js
@@ -0,0 +1,13 @@
+export class adapter {
+    constructor(dataCallback) {
+        this.dc = dataCallback;
+    }
+
+    connect() {}
+
+    update(config) {
+        this.dc(config.name);
+    }
+
+    disconnect() {}
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/modules/x/wire/wire.html b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/modules/x/wire/wire.html
new file mode 100644
index 0000000000..4eb032a5af
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/modules/x/wire/wire.html
@@ -0,0 +1,3 @@
+<template>
+    {getterOnly} {setterOnly} {getterWithSetter} {setterWithGetter} {bothDecorated}
+</template>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/modules/x/wire/wire.js b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/modules/x/wire/wire.js
new file mode 100644
index 0000000000..8dca98f127
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/get-set/modules/x/wire/wire.js
@@ -0,0 +1,41 @@
+import { LightningElement, wire } from 'lwc';
+
+import { adapter } from './adapter';
+
+export default class Wire extends LightningElement {
+    @wire(adapter, { name: 'getterOnly' })
+    get getterOnly() {
+        throw new Error('get getterOnly should not be called');
+    }
+
+    @wire(adapter, { name: 'setterOnly' })
+    set setterOnly(v) {
+        throw new Error('set setterOnly should not be called');
+    }
+
+    @wire(adapter, { name: 'getterWithSetter' })
+    get getterWithSetter() {
+        throw new Error('get getterWithSetter should not be called');
+    }
+    set getterWithSetter(v) {
+        throw new Error('set getterWithSetter should not be called');
+    }
+
+    @wire(adapter, { name: 'setterWithGetter' })
+    get setterWithGetter() {
+        throw new Error('get setterWithGetter should not be called');
+    }
+    set setterWithGetter(v) {
+        throw new Error('set setterWithGetter should not be called');
+    }
+
+    @wire(adapter, { name: 'bothDecorated' })
+    get bothDecorated() {
+        throw new Error('get bothDecorated should not be called');
+    }
+
+    @wire(adapter, { name: 'bothDecorated' })
+    set bothDecorated(v) {
+        throw new Error('set bothDecorated should not be called');
+    }
+}
diff --git a/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts b/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts
index f46b15291e..25aff4fb1c 100644
--- a/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts
+++ b/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts
@@ -34,6 +34,8 @@ export const expectedFailures = new Set([
     'superclass/render-in-superclass/unused-default-in-subclass/index.js',
     'superclass/render-in-superclass/unused-default-in-superclass/index.js',
     'svgs/index.js',
+    'wire/errors/throws-on-computed-key/index.js',
+    'wire/errors/throws-when-colliding-prop-then-method/index.js',
     'wire/errors/throws-when-computed-prop-is-expression/index.js',
     'wire/errors/throws-when-computed-prop-is-let-variable/index.js',
     'wire/errors/throws-when-computed-prop-is-regexp-literal/index.js',
diff --git a/packages/@lwc/ssr-compiler/src/compile-js/index.ts b/packages/@lwc/ssr-compiler/src/compile-js/index.ts
index 6cf09a27cc..a48b2246e0 100644
--- a/packages/@lwc/ssr-compiler/src/compile-js/index.ts
+++ b/packages/@lwc/ssr-compiler/src/compile-js/index.ts
@@ -17,13 +17,9 @@ import { addGenerateMarkupFunction } from './generate-markup';
 import { catalogWireAdapters } from './wire';
 
 import { removeDecoratorImport } from './remove-decorator-import';
-import type { Identifier as EsIdentifier, Program as EsProgram, Expression } from 'estree';
+import type { Identifier as EsIdentifier, Program as EsProgram } from 'estree';
 import type { Visitors, ComponentMetaState } from './types';
 import type { CompilationMode } from '@lwc/shared';
-import type {
-    PropertyDefinition as DecoratatedPropertyDefinition,
-    MethodDefinition as DecoratatedMethodDefinition,
-} from 'meriyah/dist/src/estree';
 
 const visitors: Visitors = {
     $: { scope: true },
@@ -72,8 +68,8 @@ const visitors: Visitors = {
             return;
         }
 
-        const decorators = (node as DecoratatedPropertyDefinition).decorators;
-        const decoratedExpression = decorators?.[0]?.expression as Expression;
+        const { decorators } = node;
+        const decoratedExpression = decorators?.[0]?.expression;
         if (is.identifier(decoratedExpression) && decoratedExpression.name === 'api') {
             state.publicFields.push(node.key.name);
         } else if (
@@ -111,14 +107,32 @@ const visitors: Visitors = {
             return;
         }
 
-        const decorators = (node as DecoratatedMethodDefinition).decorators;
-        const decoratedExpression = decorators?.[0]?.expression as Expression;
+        const { decorators } = node;
+        // The real type is a subset of `Expression`, which doesn't work with the `is` validators
+        const decoratedExpression = decorators?.[0]?.expression;
         if (
             is.callExpression(decoratedExpression) &&
             is.identifier(decoratedExpression.callee) &&
             decoratedExpression.callee.name === 'wire'
         ) {
-            catalogWireAdapters(path, state);
+            // Getters and setters are methods in the AST, but treated as properties by @wire
+            // Note that this means that their implementations are ignored!
+            if (node.kind === 'get' || node.kind === 'set') {
+                const methodAsProp = b.propertyDefinition(
+                    structuredClone(node.key),
+                    null,
+                    node.computed,
+                    node.static
+                );
+                methodAsProp.decorators = structuredClone(decorators);
+                path.replaceWith(methodAsProp);
+                // We do not need to call `catalogWireAdapters()` because, by replacing the current
+                // node, `traverse()` will visit it again automatically, so we will just call
+                // `catalogWireAdapters()` later anyway.
+                return;
+            } else {
+                catalogWireAdapters(path, state);
+            }
         }
 
         switch (node.key.name) {

From e829c8b006f8af2ad21b5139823d044245fc10d6 Mon Sep 17 00:00:00 2001
From: Matheus Cardoso <matheus@cardo.so>
Date: Wed, 4 Dec 2024 14:44:39 -0300
Subject: [PATCH 10/12] chore: use eslint cache (#5001)

---
 .gitignore   | 1 +
 package.json | 6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/.gitignore b/.gitignore
index 2bb8dea3c8..897d95d676 100644
--- a/.gitignore
+++ b/.gitignore
@@ -8,6 +8,7 @@ coverage/
 .project/
 .nx
 .nx-cache
+.eslintcache
 
 lib/
 __benchmarks_results__/
diff --git a/package.json b/package.json
index 2147bd0d9d..a05a372f86 100644
--- a/package.json
+++ b/package.json
@@ -9,7 +9,7 @@
     },
     "scripts": {
         "prepare": "husky && yarn build",
-        "lint": "eslint .",
+        "lint": "eslint . --cache",
         "format": "prettier --write .",
         "bundlesize": "node scripts/bundlesize/bundlesize.mjs",
         "build": "nx run-many --target=build --exclude=@lwc/perf-benchmarks,@lwc/perf-benchmarks-components,@lwc/integration-tests,lwc",
@@ -74,11 +74,11 @@
         "vitest": "^2.1.8"
     },
     "lint-staged": {
-        "*.{js,mjs,ts}": "eslint",
+        "*.{js,mjs,ts}": "eslint --cache",
         "*.{css,js,json,md,mjs,ts,yaml,yml}": "prettier --write",
         "{packages/**/package.json,scripts/tasks/check-and-rewrite-package-json.js}": "node ./scripts/tasks/check-and-rewrite-package-json.js",
         "{LICENSE-CORE.md,**/LICENSE.md,yarn.lock,scripts/tasks/generate-license-files.js,scripts/shared/bundled-dependencies.js}": "node ./scripts/tasks/generate-license-files.js",
-        "*.{only,skip}": "eslint --no-eslintrc --plugin '@lwc/eslint-plugin-lwc-internal' --rule '@lwc/lwc-internal/forbidden-filename: error'"
+        "*.{only,skip}": "eslint --cache --no-eslintrc --plugin '@lwc/eslint-plugin-lwc-internal' --rule '@lwc/lwc-internal/forbidden-filename: error'"
     },
     "workspaces": [
         "packages/@lwc/*",

From 6b40dc643a84d0a1225f0881b1f099250fa5184c Mon Sep 17 00:00:00 2001
From: James Tu <jmsjtu@gmail.com>
Date: Wed, 4 Dec 2024 11:50:41 -0800
Subject: [PATCH 11/12] refactor: partially fix slot forwarding in SSR (#4999)

---
 .../slot-forwarding/slots/dangling/error.txt  |  0
 .../slots/dangling/expected.html              | 16 ++++++++
 .../slot-forwarding/slots/dangling/index.js   |  4 ++
 .../modules/x/container/container.html        |  6 +++
 .../dangling/modules/x/container/container.js |  5 +++
 .../slots/dangling/modules/x/leaf/leaf.html   |  4 ++
 .../slots/dangling/modules/x/leaf/leaf.js     |  5 +++
 .../slots/dangling/modules/x/slot/slot.html   |  6 +++
 .../slots/dangling/modules/x/slot/slot.js     |  5 +++
 .../slot-forwarding/slots/light/error.txt     |  0
 .../slot-forwarding/slots/light/expected.html | 16 ++++++++
 .../slot-forwarding/slots/light/index.js      |  4 ++
 .../light/modules/x/container/container.html  |  6 +++
 .../light/modules/x/container/container.js    |  5 +++
 .../slots/light/modules/x/leaf/leaf.html      |  4 ++
 .../slots/light/modules/x/leaf/leaf.js        |  5 +++
 .../slots/light/modules/x/slot/slot.html      |  6 +++
 .../slots/light/modules/x/slot/slot.js        |  5 +++
 .../slot-forwarding/slots/mixed/error.txt     |  0
 .../slot-forwarding/slots/mixed/expected.html | 40 +++++++++++++++++++
 .../slot-forwarding/slots/mixed/index.js      |  4 ++
 .../mixed/modules/x/container/container.html  | 11 +++++
 .../mixed/modules/x/container/container.js    |  3 ++
 .../mixed/modules/x/lightLeaf/lightLeaf.html  |  4 ++
 .../mixed/modules/x/lightLeaf/lightLeaf.js    |  5 +++
 .../modules/x/lightParent/lightParent.html    |  6 +++
 .../modules/x/lightParent/lightParent.js      |  5 +++
 .../modules/x/shadowLeaf/shadowLeaf.html      |  4 ++
 .../mixed/modules/x/shadowLeaf/shadowLeaf.js  |  3 ++
 .../modules/x/shadowParent/shadowParent.html  |  6 +++
 .../modules/x/shadowParent/shadowParent.js    |  3 ++
 .../slot-forwarding/slots/shadow/error.txt    |  0
 .../slots/shadow/expected.html                | 26 ++++++++++++
 .../slot-forwarding/slots/shadow/index.js     |  4 ++
 .../shadow/modules/x/container/container.html |  6 +++
 .../shadow/modules/x/container/container.js   |  3 ++
 .../slots/shadow/modules/x/leaf/leaf.html     |  4 ++
 .../slots/shadow/modules/x/leaf/leaf.js       |  3 ++
 .../slots/shadow/modules/x/slot/slot.html     |  6 +++
 .../slots/shadow/modules/x/slot/slot.js       |  3 ++
 .../src/__tests__/utils/expected-failures.ts  |  3 ++
 .../transformers/component/component.ts       |  4 +-
 .../transformers/component/lwc-component.ts   |  4 +-
 .../transformers/component/slotted-content.ts | 10 +++--
 44 files changed, 264 insertions(+), 8 deletions(-)
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/error.txt
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/expected.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/index.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/container/container.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/container/container.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/leaf/leaf.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/leaf/leaf.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/slot/slot.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/slot/slot.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/error.txt
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/expected.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/index.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/container/container.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/container/container.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/leaf/leaf.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/leaf/leaf.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/slot/slot.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/slot/slot.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/error.txt
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/expected.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/index.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/container/container.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/container/container.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/lightLeaf/lightLeaf.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/lightLeaf/lightLeaf.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/lightParent/lightParent.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/lightParent/lightParent.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/shadowLeaf/shadowLeaf.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/shadowLeaf/shadowLeaf.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/shadowParent/shadowParent.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/shadowParent/shadowParent.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/error.txt
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/expected.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/index.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/container/container.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/container/container.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/leaf/leaf.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/leaf/leaf.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/slot/slot.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/slot/slot.js

diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/error.txt
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/expected.html
new file mode 100644
index 0000000000..aa23e8774b
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/expected.html
@@ -0,0 +1,16 @@
+<x-dangling-container>
+  <x-slot>
+    <x-leaf>
+      <!---->
+      <h1 slot="bottom">
+        bottom content
+      </h1>
+      <!---->
+      <!---->
+      <h1>
+        top content
+      </h1>
+      <!---->
+    </x-leaf>
+  </x-slot>
+</x-dangling-container>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/index.js
new file mode 100644
index 0000000000..b202a15a0a
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/index.js
@@ -0,0 +1,4 @@
+export const tagName = 'x-dangling-container';
+export { default } from 'x/container';
+export * from 'x/container';
+export const features = [];
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/container/container.html b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/container/container.html
new file mode 100644
index 0000000000..d6153f7e58
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/container/container.html
@@ -0,0 +1,6 @@
+<template lwc:render-mode="light">
+    <x-slot>
+        <h1 slot="top">top content</h1>
+        <h1 slot="bottom">bottom content</h1>
+    </x-slot>
+</template>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/container/container.js b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/container/container.js
new file mode 100644
index 0000000000..0679d2bc10
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/container/container.js
@@ -0,0 +1,5 @@
+import { LightningElement } from 'lwc';
+
+export default class extends LightningElement {
+    static renderMode = 'light';
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/leaf/leaf.html b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/leaf/leaf.html
new file mode 100644
index 0000000000..039365a7a7
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/leaf/leaf.html
@@ -0,0 +1,4 @@
+<template lwc:render-mode="light">
+    <slot name="top" slot="bottom"></slot>
+    <slot name="bottom"></slot>
+</template>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/leaf/leaf.js b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/leaf/leaf.js
new file mode 100644
index 0000000000..0679d2bc10
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/leaf/leaf.js
@@ -0,0 +1,5 @@
+import { LightningElement } from 'lwc';
+
+export default class extends LightningElement {
+    static renderMode = 'light';
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/slot/slot.html b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/slot/slot.html
new file mode 100644
index 0000000000..e641874967
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/slot/slot.html
@@ -0,0 +1,6 @@
+<template lwc:render-mode="light">
+    <x-leaf>
+        <slot name="top" slot="bottom"></slot>
+        <slot name="bottom" slot="top"></slot>
+    </x-leaf>
+</template>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/slot/slot.js b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/slot/slot.js
new file mode 100644
index 0000000000..0679d2bc10
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/dangling/modules/x/slot/slot.js
@@ -0,0 +1,5 @@
+import { LightningElement } from 'lwc';
+
+export default class extends LightningElement {
+    static renderMode = 'light';
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/error.txt
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/expected.html
new file mode 100644
index 0000000000..775c4c9602
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/expected.html
@@ -0,0 +1,16 @@
+<x-light-container>
+  <x-slot>
+    <x-leaf>
+      <!---->
+      <h1>
+        bottom content
+      </h1>
+      <!---->
+      <!---->
+      <h1>
+        top content
+      </h1>
+      <!---->
+    </x-leaf>
+  </x-slot>
+</x-light-container>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/index.js
new file mode 100644
index 0000000000..2230255735
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/index.js
@@ -0,0 +1,4 @@
+export const tagName = 'x-light-container';
+export { default } from 'x/container';
+export * from 'x/container';
+export const features = [];
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/container/container.html b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/container/container.html
new file mode 100644
index 0000000000..d6153f7e58
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/container/container.html
@@ -0,0 +1,6 @@
+<template lwc:render-mode="light">
+    <x-slot>
+        <h1 slot="top">top content</h1>
+        <h1 slot="bottom">bottom content</h1>
+    </x-slot>
+</template>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/container/container.js b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/container/container.js
new file mode 100644
index 0000000000..0679d2bc10
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/container/container.js
@@ -0,0 +1,5 @@
+import { LightningElement } from 'lwc';
+
+export default class extends LightningElement {
+    static renderMode = 'light';
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/leaf/leaf.html b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/leaf/leaf.html
new file mode 100644
index 0000000000..6bb058d068
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/leaf/leaf.html
@@ -0,0 +1,4 @@
+<template lwc:render-mode="light">
+    <slot name="top"></slot>
+    <slot name="bottom"></slot>
+</template>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/leaf/leaf.js b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/leaf/leaf.js
new file mode 100644
index 0000000000..0679d2bc10
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/leaf/leaf.js
@@ -0,0 +1,5 @@
+import { LightningElement } from 'lwc';
+
+export default class extends LightningElement {
+    static renderMode = 'light';
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/slot/slot.html b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/slot/slot.html
new file mode 100644
index 0000000000..e641874967
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/slot/slot.html
@@ -0,0 +1,6 @@
+<template lwc:render-mode="light">
+    <x-leaf>
+        <slot name="top" slot="bottom"></slot>
+        <slot name="bottom" slot="top"></slot>
+    </x-leaf>
+</template>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/slot/slot.js b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/slot/slot.js
new file mode 100644
index 0000000000..0679d2bc10
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/light/modules/x/slot/slot.js
@@ -0,0 +1,5 @@
+import { LightningElement } from 'lwc';
+
+export default class extends LightningElement {
+    static renderMode = 'light';
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/error.txt
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/expected.html
new file mode 100644
index 0000000000..320de2c749
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/expected.html
@@ -0,0 +1,40 @@
+<x-mixed-container>
+  <template shadowrootmode="open">
+    <x-light-parent>
+      <x-shadow-leaf>
+        <template shadowrootmode="open">
+          <slot name="top">
+          </slot>
+          <slot name="bottom">
+          </slot>
+        </template>
+        <div slot="bottom">
+          top of light parent
+        </div>
+        <div slot="top">
+          bottom of light parent
+        </div>
+      </x-shadow-leaf>
+    </x-light-parent>
+    <x-shadow-parent>
+      <template shadowrootmode="open">
+        <x-light-leaf>
+          <!---->
+          <slot name="bottom">
+          </slot>
+          <!---->
+          <!---->
+          <slot name="top">
+          </slot>
+          <!---->
+        </x-light-leaf>
+      </template>
+      <div slot="top">
+        top of shadow parent
+      </div>
+      <div slot="bottom">
+        bottom of shadow parent
+      </div>
+    </x-shadow-parent>
+  </template>
+</x-mixed-container>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/index.js
new file mode 100644
index 0000000000..278804639e
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/index.js
@@ -0,0 +1,4 @@
+export const tagName = 'x-mixed-container';
+export { default } from 'x/container';
+export * from 'x/container';
+export const features = [];
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/container/container.html b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/container/container.html
new file mode 100644
index 0000000000..553cc1064d
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/container/container.html
@@ -0,0 +1,11 @@
+<template>
+    <x-light-parent>
+        <div slot="top">top of light parent</div>
+        <div slot="bottom">bottom of light parent</div>
+    </x-light-parent>
+
+    <x-shadow-parent>
+        <div slot="top">top of shadow parent</div>
+        <div slot="bottom">bottom of shadow parent</div>
+    </x-shadow-parent>
+</template>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/container/container.js b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/container/container.js
new file mode 100644
index 0000000000..ca8dce94e0
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/container/container.js
@@ -0,0 +1,3 @@
+import { LightningElement } from 'lwc';
+
+export default class extends LightningElement {}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/lightLeaf/lightLeaf.html b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/lightLeaf/lightLeaf.html
new file mode 100644
index 0000000000..6bb058d068
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/lightLeaf/lightLeaf.html
@@ -0,0 +1,4 @@
+<template lwc:render-mode="light">
+    <slot name="top"></slot>
+    <slot name="bottom"></slot>
+</template>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/lightLeaf/lightLeaf.js b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/lightLeaf/lightLeaf.js
new file mode 100644
index 0000000000..0679d2bc10
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/lightLeaf/lightLeaf.js
@@ -0,0 +1,5 @@
+import { LightningElement } from 'lwc';
+
+export default class extends LightningElement {
+    static renderMode = 'light';
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/lightParent/lightParent.html b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/lightParent/lightParent.html
new file mode 100644
index 0000000000..cd365ffd8b
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/lightParent/lightParent.html
@@ -0,0 +1,6 @@
+<template lwc:render-mode="light">
+    <x-shadow-leaf>
+        <slot name="top" slot="bottom"></slot>
+        <slot name="bottom" slot="top"></slot>
+    </x-shadow-leaf>
+</template>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/lightParent/lightParent.js b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/lightParent/lightParent.js
new file mode 100644
index 0000000000..0679d2bc10
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/lightParent/lightParent.js
@@ -0,0 +1,5 @@
+import { LightningElement } from 'lwc';
+
+export default class extends LightningElement {
+    static renderMode = 'light';
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/shadowLeaf/shadowLeaf.html b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/shadowLeaf/shadowLeaf.html
new file mode 100644
index 0000000000..4bc6c14fb4
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/shadowLeaf/shadowLeaf.html
@@ -0,0 +1,4 @@
+<template>
+    <slot name="top"></slot>
+    <slot name="bottom"></slot>
+</template>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/shadowLeaf/shadowLeaf.js b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/shadowLeaf/shadowLeaf.js
new file mode 100644
index 0000000000..ca8dce94e0
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/shadowLeaf/shadowLeaf.js
@@ -0,0 +1,3 @@
+import { LightningElement } from 'lwc';
+
+export default class extends LightningElement {}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/shadowParent/shadowParent.html b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/shadowParent/shadowParent.html
new file mode 100644
index 0000000000..2e952f1af5
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/shadowParent/shadowParent.html
@@ -0,0 +1,6 @@
+<template>
+    <x-light-leaf>
+        <slot name="top" slot="bottom"></slot>
+        <slot name="bottom" slot="top"></slot>
+    </x-light-leaf>
+</template>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/shadowParent/shadowParent.js b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/shadowParent/shadowParent.js
new file mode 100644
index 0000000000..ca8dce94e0
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/mixed/modules/x/shadowParent/shadowParent.js
@@ -0,0 +1,3 @@
+import { LightningElement } from 'lwc';
+
+export default class extends LightningElement {}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/error.txt
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/expected.html
new file mode 100644
index 0000000000..c1af072344
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/expected.html
@@ -0,0 +1,26 @@
+<x-shadow-container>
+  <template shadowrootmode="open">
+    <x-slot>
+      <template shadowrootmode="open">
+        <x-leaf>
+          <template shadowrootmode="open">
+            <slot name="top">
+            </slot>
+            <slot name="bottom">
+            </slot>
+          </template>
+          <slot name="top" slot="bottom">
+          </slot>
+          <slot name="bottom" slot="top">
+          </slot>
+        </x-leaf>
+      </template>
+      <h1 slot="top">
+        top content
+      </h1>
+      <h1 slot="bottom">
+        bottom content
+      </h1>
+    </x-slot>
+  </template>
+</x-shadow-container>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/index.js
new file mode 100644
index 0000000000..8c80133fc7
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/index.js
@@ -0,0 +1,4 @@
+export const tagName = 'x-shadow-container';
+export { default } from 'x/container';
+export * from 'x/container';
+export const features = [];
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/container/container.html b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/container/container.html
new file mode 100644
index 0000000000..85b37d746c
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/container/container.html
@@ -0,0 +1,6 @@
+<template>
+    <x-slot>
+        <h1 slot="top">top content</h1>
+        <h1 slot="bottom">bottom content</h1>
+    </x-slot>
+</template>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/container/container.js b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/container/container.js
new file mode 100644
index 0000000000..ca8dce94e0
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/container/container.js
@@ -0,0 +1,3 @@
+import { LightningElement } from 'lwc';
+
+export default class extends LightningElement {}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/leaf/leaf.html b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/leaf/leaf.html
new file mode 100644
index 0000000000..4bc6c14fb4
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/leaf/leaf.html
@@ -0,0 +1,4 @@
+<template>
+    <slot name="top"></slot>
+    <slot name="bottom"></slot>
+</template>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/leaf/leaf.js b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/leaf/leaf.js
new file mode 100644
index 0000000000..ca8dce94e0
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/leaf/leaf.js
@@ -0,0 +1,3 @@
+import { LightningElement } from 'lwc';
+
+export default class extends LightningElement {}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/slot/slot.html b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/slot/slot.html
new file mode 100644
index 0000000000..a5d740912d
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/slot/slot.html
@@ -0,0 +1,6 @@
+<template>
+    <x-leaf>
+        <slot name="top" slot="bottom"></slot>
+        <slot name="bottom" slot="top"></slot>
+    </x-leaf>
+</template>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/slot/slot.js b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/slot/slot.js
new file mode 100644
index 0000000000..ca8dce94e0
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/slot-forwarding/slots/shadow/modules/x/slot/slot.js
@@ -0,0 +1,3 @@
+import { LightningElement } from 'lwc';
+
+export default class extends LightningElement {}
diff --git a/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts b/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts
index 25aff4fb1c..d0e362be48 100644
--- a/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts
+++ b/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts
@@ -26,6 +26,9 @@ export const expectedFailures = new Set([
     'scoped-slots/mixed-with-light-dom-slots-inside/index.js',
     'scoped-slots/mixed-with-light-dom-slots-outside/index.js',
     'slot-forwarding/scoped-slots/index.js',
+    'slot-forwarding/slots/mixed/index.js',
+    'slot-forwarding/slots/dangling/index.js',
+    'slot-forwarding/slots/light/index.js',
     'slot-not-at-top-level/advanced/lwcIf/light/index.js',
     'slot-not-at-top-level/advanced/lwcIf/shadow/index.js',
     'slot-not-at-top-level/lwcIf/light/index.js',
diff --git a/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/component.ts b/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/component.ts
index e0ed7e380a..0dc6512279 100644
--- a/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/component.ts
+++ b/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/component.ts
@@ -23,7 +23,7 @@ const bYieldFromChildGenerator = esTemplateWithYield`
             /*
                 Slotted content is inserted here.
                 Note that the slotted content will be stored in variables named 
-                `shadowSlottedContent`/`lightSlottedContent` which are used below 
+                `shadowSlottedContent`/`lightSlottedContentMap` which are used below 
                 when the child's generateMarkup function is invoked.
             */
             is.statement
@@ -37,7 +37,7 @@ const bYieldFromChildGenerator = esTemplateWithYield`
             childProps, 
             childAttrs, 
             shadowSlottedContent,
-            lightSlottedContent,
+            lightSlottedContentMap,
             instance,
             scopeToken,
         );
diff --git a/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/lwc-component.ts b/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/lwc-component.ts
index b1a5f8a5b6..645570dd31 100644
--- a/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/lwc-component.ts
+++ b/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/lwc-component.ts
@@ -29,7 +29,7 @@ const bYieldFromDynamicComponentConstructorGenerator = esTemplateWithYield`
             /*
                 Slotted content is inserted here.
                 Note that the slotted content will be stored in variables named 
-                `shadowSlottedContent`/`lightSlottedContent` which are used below 
+                `shadowSlottedContent`/`lightSlottedContentMap` which are used below 
                 when the child's generateMarkup function is invoked.
             */
             is.statement
@@ -42,7 +42,7 @@ const bYieldFromDynamicComponentConstructorGenerator = esTemplateWithYield`
             childProps,
             childAttrs,
             shadowSlottedContent,
-            lightSlottedContent,
+            lightSlottedContentMap,
             scopeToken
         );
     }
diff --git a/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/slotted-content.ts b/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/slotted-content.ts
index ef30633ec3..62a8ff2cd2 100644
--- a/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/slotted-content.ts
+++ b/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/slotted-content.ts
@@ -29,6 +29,7 @@ import type {
     LwcComponent as IrLwcComponent,
     ScopedSlotFragment as IrScopedSlotFragment,
     Text as IrText,
+    Slot as IrSlot,
 } from '@lwc/template-compiler';
 import type { TransformerContext } from '../../types';
 
@@ -40,17 +41,17 @@ const bGenerateSlottedContent = esTemplateWithYield`
             // Avoid creating the object unnecessarily
             : null;
 
-        const lightSlottedContent = ${/* hasLightSlottedContent */ is.literal} 
+        const lightSlottedContentMap = ${/* hasLightSlottedContent */ is.literal} 
             ? Object.create(null)
             // Avoid creating the object unnecessarily
             : null;
         
         function addLightContent(name, fn) {
-            let contentList = lightSlottedContent[name];
+            let contentList = lightSlottedContentMap[name];
             if (contentList) {
                 contentList.push(fn);
             } else {
-                lightSlottedContent[name] = [fn];
+                lightSlottedContentMap[name] = [fn];
             }
         }
 
@@ -97,7 +98,7 @@ const bAddLightContent = esTemplate`
 // relevant to slots (as mentioned above).
 function getLightSlottedContent(rootNodes: IrChildNode[], cxt: TransformerContext) {
     type SlottableAncestorIrType = IrIf | IrIfBlock | IrElseifBlock | IrElseBlock;
-    type SlottableLeafIrType = IrElement | IrText | IrComponent | IrExternalComponent;
+    type SlottableLeafIrType = IrElement | IrText | IrComponent | IrExternalComponent | IrSlot;
 
     const results: EsExpressionStatement[] = [];
 
@@ -140,6 +141,7 @@ function getLightSlottedContent(rootNodes: IrChildNode[], cxt: TransformerContex
                     break;
                 }
                 // SlottableLeafIrType
+                case 'Slot':
                 case 'Element':
                 case 'Text':
                 case 'Component':

From 77010690be2e23e42f1d03fd83f3a7dcd098428a Mon Sep 17 00:00:00 2001
From: Will Harney <62956339+wjhsf@users.noreply.github.com>
Date: Wed, 4 Dec 2024 17:07:27 -0500
Subject: [PATCH 12/12] fix(ssr): make context providers work again (#5004)

Co-authored-by: John Hefferman <jhefferman@salesforce.com>
Co-authored-by: Nolan Lawson <nlawson@salesforce.com>
---
 .../context-slotted/{ => light}/error.txt     |  0
 .../context-slotted/light/expected.html       | 11 +++++
 .../context-slotted/{ => light}/index.js      |  0
 .../light/modules/x/consumer/consumer.html    |  3 ++
 .../light/modules/x/consumer/consumer.js      |  7 +++
 .../light/modules/x/provider/provider.html    |  3 ++
 .../light/modules/x/provider/provider.js      | 15 +++++++
 .../light/modules/x/root/root.html            |  5 +++
 .../light/modules/x/root/root.js              |  5 +++
 .../{ => light}/wire-adapter.js               |  0
 .../fixtures/context-slotted/scoped/error.txt |  0
 .../context-slotted/scoped/expected.html      | 16 +++++++
 .../fixtures/context-slotted/scoped/index.js  |  3 ++
 .../scoped/modules/x/consumer/consumer.html   |  3 ++
 .../scoped/modules/x/consumer/consumer.js     |  7 +++
 .../scoped/modules/x/provider/provider.html   |  3 ++
 .../scoped/modules/x/provider/provider.js     | 19 ++++++++
 .../scoped/modules/x/root/root.html           |  8 ++++
 .../scoped/modules/x/root/root.js             |  5 +++
 .../context-slotted/scoped/wire-adapter.js    | 30 +++++++++++++
 .../fixtures/context-slotted/shadow/error.txt |  0
 .../{ => shadow}/expected.html                |  0
 .../fixtures/context-slotted/shadow/index.js  |  3 ++
 .../modules/x/consumer/consumer.html          |  0
 .../modules/x/consumer/consumer.js            |  0
 .../modules/x/provider/provider.html          |  0
 .../modules/x/provider/provider.js            |  0
 .../{ => shadow}/modules/x/root/root.html     |  0
 .../{ => shadow}/modules/x/root/root.js       |  0
 .../context-slotted/shadow/wire-adapter.js    | 30 +++++++++++++
 .../src/__tests__/utils/expected-failures.ts  |  1 -
 .../src/compile-js/generate-markup.ts         |  5 ++-
 .../src/compile-template/index.ts             |  8 +++-
 .../transformers/component/component.ts       |  1 +
 .../transformers/component/lwc-component.ts   |  4 +-
 .../transformers/component/slotted-content.ts |  8 +++-
 .../src/compile-template/transformers/slot.ts |  2 +-
 packages/@lwc/ssr-runtime/src/render.ts       | 43 ++++++++++++++++---
 38 files changed, 234 insertions(+), 14 deletions(-)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/{ => light}/error.txt (100%)
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/expected.html
 rename packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/{ => light}/index.js (100%)
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/consumer/consumer.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/consumer/consumer.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/provider/provider.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/provider/provider.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/root/root.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/root/root.js
 rename packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/{ => light}/wire-adapter.js (100%)
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/error.txt
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/expected.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/index.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/consumer/consumer.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/consumer/consumer.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/provider/provider.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/provider/provider.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/root/root.html
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/root/root.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/wire-adapter.js
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/error.txt
 rename packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/{ => shadow}/expected.html (100%)
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/index.js
 rename packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/{ => shadow}/modules/x/consumer/consumer.html (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/{ => shadow}/modules/x/consumer/consumer.js (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/{ => shadow}/modules/x/provider/provider.html (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/{ => shadow}/modules/x/provider/provider.js (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/{ => shadow}/modules/x/root/root.html (100%)
 rename packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/{ => shadow}/modules/x/root/root.js (100%)
 create mode 100644 packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/wire-adapter.js

diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/error.txt
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/error.txt
rename to packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/error.txt
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/expected.html
new file mode 100644
index 0000000000..61738a2a38
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/expected.html
@@ -0,0 +1,11 @@
+<x-root>
+  <x-provider>
+    <!---->
+    <x-consumer>
+      <div>
+        some context
+      </div>
+    </x-consumer>
+    <!---->
+  </x-provider>
+</x-root>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/index.js
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/index.js
rename to packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/index.js
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/consumer/consumer.html b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/consumer/consumer.html
new file mode 100644
index 0000000000..4b5b9a57ff
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/consumer/consumer.html
@@ -0,0 +1,3 @@
+<template lwc:render-mode="light">
+    <div>{foo}</div>
+</template>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/consumer/consumer.js b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/consumer/consumer.js
new file mode 100644
index 0000000000..6f1758b3b6
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/consumer/consumer.js
@@ -0,0 +1,7 @@
+import { LightningElement, wire } from 'lwc';
+import { WireAdapter } from '../../../wire-adapter';
+
+export default class SlottedConsumerComponent extends LightningElement {
+    static renderMode = 'light';
+    @wire(WireAdapter) foo;
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/provider/provider.html b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/provider/provider.html
new file mode 100644
index 0000000000..bf14f95bb9
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/provider/provider.html
@@ -0,0 +1,3 @@
+<template lwc:render-mode="light">
+    <slot></slot>
+</template>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/provider/provider.js b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/provider/provider.js
new file mode 100644
index 0000000000..0f1b9e95cc
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/provider/provider.js
@@ -0,0 +1,15 @@
+import { LightningElement } from 'lwc';
+import { contextualizer } from '../../../wire-adapter';
+
+export default class ProviderComponent extends LightningElement {
+    static renderMode = 'light';
+    connectedCallback() {
+        contextualizer(this, {
+            consumerConnectedCallback(consumer) {
+                consumer.provide({
+                    value: 'some context',
+                });
+            },
+        });
+    }
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/root/root.html b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/root/root.html
new file mode 100644
index 0000000000..b96157b4fd
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/root/root.html
@@ -0,0 +1,5 @@
+<template lwc:render-mode="light">
+    <x-provider>
+        <x-consumer></x-consumer>
+    </x-provider>
+</template>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/root/root.js b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/root/root.js
new file mode 100644
index 0000000000..c9df99d82a
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/modules/x/root/root.js
@@ -0,0 +1,5 @@
+import { LightningElement } from 'lwc';
+
+export default class Rootcomponent extends LightningElement {
+    static renderMode = 'light';
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/wire-adapter.js b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/wire-adapter.js
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/wire-adapter.js
rename to packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/light/wire-adapter.js
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/error.txt
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/expected.html
new file mode 100644
index 0000000000..a0c8f044b0
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/expected.html
@@ -0,0 +1,16 @@
+<x-root>
+  <x-provider>
+    <!---->
+    <!---->
+    <x-consumer>
+      <span>
+        some context
+      </span>
+    </x-consumer>
+    <span>
+      id - name
+    </span>
+    <!---->
+    <!---->
+  </x-provider>
+</x-root>
\ No newline at end of file
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/index.js
new file mode 100644
index 0000000000..64dd80573e
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/index.js
@@ -0,0 +1,3 @@
+export const tagName = 'x-root';
+export { default } from 'x/root';
+export * from 'x/root';
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/consumer/consumer.html b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/consumer/consumer.html
new file mode 100644
index 0000000000..dae115689d
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/consumer/consumer.html
@@ -0,0 +1,3 @@
+<template lwc:render-mode="light">
+    <span>{foo}</span>
+</template>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/consumer/consumer.js b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/consumer/consumer.js
new file mode 100644
index 0000000000..6f1758b3b6
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/consumer/consumer.js
@@ -0,0 +1,7 @@
+import { LightningElement, wire } from 'lwc';
+import { WireAdapter } from '../../../wire-adapter';
+
+export default class SlottedConsumerComponent extends LightningElement {
+    static renderMode = 'light';
+    @wire(WireAdapter) foo;
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/provider/provider.html b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/provider/provider.html
new file mode 100644
index 0000000000..2255b41438
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/provider/provider.html
@@ -0,0 +1,3 @@
+<template lwc:render-mode="light">
+    <slot lwc:slot-bind={item}></slot>
+</template>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/provider/provider.js b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/provider/provider.js
new file mode 100644
index 0000000000..4f3ad063b1
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/provider/provider.js
@@ -0,0 +1,19 @@
+import { LightningElement } from 'lwc';
+import { contextualizer } from '../../../wire-adapter';
+
+export default class ProviderComponent extends LightningElement {
+    static renderMode = 'light';
+    item = {
+        id: 'id',
+        name: 'name',
+    };
+    connectedCallback() {
+        contextualizer(this, {
+            consumerConnectedCallback(consumer) {
+                consumer.provide({
+                    value: 'some context',
+                });
+            },
+        });
+    }
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/root/root.html b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/root/root.html
new file mode 100644
index 0000000000..d4e2810804
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/root/root.html
@@ -0,0 +1,8 @@
+<template lwc:render-mode="light">
+    <x-provider>
+        <template lwc:slot-data="data">
+            <x-consumer></x-consumer>
+            <span>{data.id} - {data.name}</span>
+        </template>
+    </x-provider>
+</template>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/root/root.js b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/root/root.js
new file mode 100644
index 0000000000..c9df99d82a
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/modules/x/root/root.js
@@ -0,0 +1,5 @@
+import { LightningElement } from 'lwc';
+
+export default class Rootcomponent extends LightningElement {
+    static renderMode = 'light';
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/wire-adapter.js b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/wire-adapter.js
new file mode 100644
index 0000000000..89f914b7e2
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/scoped/wire-adapter.js
@@ -0,0 +1,30 @@
+import { createContextProvider } from 'lwc';
+
+export class WireAdapter {
+    contextValue = { value: 'missing' };
+    static contextSchema = { value: 'required' };
+
+    constructor(callback) {
+        this._callback = callback;
+    }
+
+    connect() {
+        // noop
+    }
+
+    disconnect() {
+        // noop
+    }
+
+    update(_config, context) {
+        if (context) {
+            if (!context.hasOwnProperty('value')) {
+                throw new Error(`Invalid context provided`);
+            }
+            this.contextValue = context.value;
+            this._callback(this.contextValue);
+        }
+    }
+}
+
+export const contextualizer = createContextProvider(WireAdapter);
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/error.txt b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/error.txt
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/expected.html
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/expected.html
rename to packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/expected.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/index.js b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/index.js
new file mode 100644
index 0000000000..64dd80573e
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/index.js
@@ -0,0 +1,3 @@
+export const tagName = 'x-root';
+export { default } from 'x/root';
+export * from 'x/root';
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/modules/x/consumer/consumer.html b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/modules/x/consumer/consumer.html
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/modules/x/consumer/consumer.html
rename to packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/modules/x/consumer/consumer.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/modules/x/consumer/consumer.js b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/modules/x/consumer/consumer.js
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/modules/x/consumer/consumer.js
rename to packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/modules/x/consumer/consumer.js
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/modules/x/provider/provider.html b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/modules/x/provider/provider.html
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/modules/x/provider/provider.html
rename to packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/modules/x/provider/provider.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/modules/x/provider/provider.js b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/modules/x/provider/provider.js
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/modules/x/provider/provider.js
rename to packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/modules/x/provider/provider.js
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/modules/x/root/root.html b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/modules/x/root/root.html
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/modules/x/root/root.html
rename to packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/modules/x/root/root.html
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/modules/x/root/root.js b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/modules/x/root/root.js
similarity index 100%
rename from packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/modules/x/root/root.js
rename to packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/modules/x/root/root.js
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/wire-adapter.js b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/wire-adapter.js
new file mode 100644
index 0000000000..89f914b7e2
--- /dev/null
+++ b/packages/@lwc/engine-server/src/__tests__/fixtures/context-slotted/shadow/wire-adapter.js
@@ -0,0 +1,30 @@
+import { createContextProvider } from 'lwc';
+
+export class WireAdapter {
+    contextValue = { value: 'missing' };
+    static contextSchema = { value: 'required' };
+
+    constructor(callback) {
+        this._callback = callback;
+    }
+
+    connect() {
+        // noop
+    }
+
+    disconnect() {
+        // noop
+    }
+
+    update(_config, context) {
+        if (context) {
+            if (!context.hasOwnProperty('value')) {
+                throw new Error(`Invalid context provided`);
+            }
+            this.contextValue = context.value;
+            this._callback(this.contextValue);
+        }
+    }
+}
+
+export const contextualizer = createContextProvider(WireAdapter);
diff --git a/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts b/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts
index d0e362be48..ac9356a663 100644
--- a/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts
+++ b/packages/@lwc/ssr-compiler/src/__tests__/utils/expected-failures.ts
@@ -17,7 +17,6 @@ export const expectedFailures = new Set([
     'attribute-namespace/index.js',
     'attribute-style/basic/index.js',
     'attribute-style/dynamic/index.js',
-    'context-slotted/index.js',
     'exports/component-as-default/index.js',
     'known-boolean-attributes/default-def-html-attributes/static-on-component/index.js',
     'render-dynamic-value/index.js',
diff --git a/packages/@lwc/ssr-compiler/src/compile-js/generate-markup.ts b/packages/@lwc/ssr-compiler/src/compile-js/generate-markup.ts
index c2e64bb0c3..2591b1d328 100644
--- a/packages/@lwc/ssr-compiler/src/compile-js/generate-markup.ts
+++ b/packages/@lwc/ssr-compiler/src/compile-js/generate-markup.ts
@@ -37,7 +37,8 @@ const bGenerateMarkup = esTemplate`
             shadowSlottedContent,
             lightSlottedContent, 
             parent, 
-            scopeToken
+            scopeToken,
+            contextfulParent
     ) {
         tagName = tagName ?? ${/*component tag name*/ is.literal};
         attrs = attrs ?? Object.create(null);
@@ -51,7 +52,7 @@ const bGenerateMarkup = esTemplate`
             tagName: tagName.toUpperCase(),
         });
 
-        __establishContextfulRelationship(parent, instance);
+        __establishContextfulRelationship(contextfulParent, instance);
         ${/*connect wire*/ is.statement}
 
         instance[__SYMBOL__SET_INTERNALS](props, attrs);
diff --git a/packages/@lwc/ssr-compiler/src/compile-template/index.ts b/packages/@lwc/ssr-compiler/src/compile-template/index.ts
index f99eaccba0..c5480b73eb 100644
--- a/packages/@lwc/ssr-compiler/src/compile-template/index.ts
+++ b/packages/@lwc/ssr-compiler/src/compile-template/index.ts
@@ -33,6 +33,10 @@ const bExportTemplate = esTemplate`
         let textContentBuffer = '';
         let didBufferTextContent = false;
 
+        // Establishes a contextual relationship between two components for ContextProviders.
+        // This variable will typically get overridden (shadowed) within slotted content.
+        const contextfulParent = instance;
+
         const isLightDom = Cmp.renderMode === 'light';
         if (!isLightDom) {
             yield \`<template shadowrootmode="open"\${Cmp.delegatesFocus ? ' shadowrootdelegatesfocus' : ''}>\`
@@ -55,7 +59,9 @@ const bExportTemplate = esTemplate`
         if (!isLightDom) {
             yield '</template>';
             if (shadowSlottedContent) {
-                yield* shadowSlottedContent();
+                // instance must be passed in; this is used to establish the contextful relationship
+                // between context provider (aka parent component) and context consumer (aka slotted content)
+                yield* shadowSlottedContent(contextfulParent);
             }
         }
     }
diff --git a/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/component.ts b/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/component.ts
index 0dc6512279..c0d367fba3 100644
--- a/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/component.ts
+++ b/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/component.ts
@@ -40,6 +40,7 @@ const bYieldFromChildGenerator = esTemplateWithYield`
             lightSlottedContentMap,
             instance,
             scopeToken,
+            contextfulParent
         );
     }
 `<EsBlockStatement>;
diff --git a/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/lwc-component.ts b/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/lwc-component.ts
index 645570dd31..a079c6521a 100644
--- a/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/lwc-component.ts
+++ b/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/lwc-component.ts
@@ -43,7 +43,9 @@ const bYieldFromDynamicComponentConstructorGenerator = esTemplateWithYield`
             childAttrs,
             shadowSlottedContent,
             lightSlottedContentMap,
-            scopeToken
+            instance,
+            scopeToken,
+            contextfulParent
         );
     }
 `<EsStatement[]>;
diff --git a/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/slotted-content.ts b/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/slotted-content.ts
index 62a8ff2cd2..43eb53061c 100644
--- a/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/slotted-content.ts
+++ b/packages/@lwc/ssr-compiler/src/compile-template/transformers/component/slotted-content.ts
@@ -35,7 +35,11 @@ import type { TransformerContext } from '../../types';
 
 const bGenerateSlottedContent = esTemplateWithYield`
         const shadowSlottedContent = ${/* hasShadowSlottedContent */ is.literal}
-            ? async function* generateShadowSlottedContent() {
+            ? async function* generateSlottedContent(contextfulParent) {
+                // The 'contextfulParent' variable is shadowed here so that a contextful relationship
+                // is established between components rendered in slotted content & the "parent"
+                // component that contains the <slot>.
+
                 ${/* shadow slot content */ is.statement}
             } 
             // Avoid creating the object unnecessarily
@@ -63,7 +67,7 @@ const bGenerateSlottedContent = esTemplateWithYield`
 // it may be repeated multiple times in the same scope, because it's a function _expression_ rather
 // than a function _declaration_, so it isn't available to be referenced anywhere.
 const bAddLightContent = esTemplate`
-    addLightContent(${/* slot name */ is.expression} ?? "", async function* generateSlottedContent(${
+    addLightContent(${/* slot name */ is.expression} ?? "", async function* generateSlottedContent(contextfulParent, ${
         /* scoped slot data variable */ isNullableOf(is.identifier)
     }) {
         // FIXME: make validation work again  
diff --git a/packages/@lwc/ssr-compiler/src/compile-template/transformers/slot.ts b/packages/@lwc/ssr-compiler/src/compile-template/transformers/slot.ts
index 9e6d5ff3ac..9a70ce4aec 100644
--- a/packages/@lwc/ssr-compiler/src/compile-template/transformers/slot.ts
+++ b/packages/@lwc/ssr-compiler/src/compile-template/transformers/slot.ts
@@ -35,7 +35,7 @@ const bConditionalSlot = esTemplateWithYield`
         const generators = lightSlottedContent?.[${/* slotName */ is.expression} ?? ""];
         if (generators) {
             for (const generator of generators) {
-                yield* generator(${/* scoped slot data */ isNullableOf(is.expression)});
+                yield* generator(contextfulParent, ${/* scoped slot data */ isNullableOf(is.expression)});
             }
         } else {
             // If we're in this else block, then the generator _must_ have yielded
diff --git a/packages/@lwc/ssr-runtime/src/render.ts b/packages/@lwc/ssr-runtime/src/render.ts
index b4f1fc87a9..0ac5429cb2 100644
--- a/packages/@lwc/ssr-runtime/src/render.ts
+++ b/packages/@lwc/ssr-runtime/src/render.ts
@@ -119,25 +119,40 @@ export type GenerateMarkupFn = (
     props: Properties | null,
     attrs: Attributes | null,
     shadowSlottedContent: AsyncGenerator<string> | null,
-    lightSlottedContent: Record<number | string, AsyncGenerator<string>> | null
+    lightSlottedContent: Record<number | string, AsyncGenerator<string>> | null,
+    // Not always null when invoked internally, but should always be
+    // null when invoked by ssr-runtime
+    parent: LightningElement | null,
+    scopeToken: string | null,
+    contextfulParent: LightningElement | null
 ) => AsyncGenerator<string>;
 
 export type GenerateMarkupFnAsyncNoGen = (
     emit: (segment: string) => void,
     tagName: string,
-    props: Record<string, any> | null,
+    props: Properties | null,
     attrs: Attributes | null,
     shadowSlottedContent: AsyncGenerator<string> | null,
-    lightSlottedContent: Record<number | string, AsyncGenerator<string>> | null
+    lightSlottedContent: Record<number | string, AsyncGenerator<string>> | null,
+    // Not always null when invoked internally, but should always be
+    // null when invoked by ssr-runtime
+    parent: LightningElement | null,
+    scopeToken: string | null,
+    contextfulParent: LightningElement | null
 ) => Promise<void>;
 
 export type GenerateMarkupFnSyncNoGen = (
     emit: (segment: string) => void,
     tagName: string,
-    props: Record<string, any> | null,
+    props: Properties | null,
     attrs: Attributes | null,
     shadowSlottedContent: AsyncGenerator<string> | null,
-    lightSlottedContent: Record<number | string, AsyncGenerator<string>> | null
+    lightSlottedContent: Record<number | string, AsyncGenerator<string>> | null,
+    // Not always null when invoked internally, but should always be
+    // null when invoked by ssr-runtime
+    parent: LightningElement | null,
+    scopeToken: string | null,
+    contextfulParent: LightningElement | null
 ) => void;
 
 type GenerateMarkupFnVariants =
@@ -172,6 +187,9 @@ export async function serverSideRenderComponent(
             props,
             null,
             null,
+            null,
+            null,
+            null,
             null
         )) {
             markup += segment;
@@ -183,10 +201,23 @@ export async function serverSideRenderComponent(
             props,
             null,
             null,
+            null,
+            null,
+            null,
             null
         );
     } else if (mode === 'sync') {
-        (generateMarkup as GenerateMarkupFnSyncNoGen)(emit, tagName, props, null, null, null);
+        (generateMarkup as GenerateMarkupFnSyncNoGen)(
+            emit,
+            tagName,
+            props,
+            null,
+            null,
+            null,
+            null,
+            null,
+            null
+        );
     } else {
         throw new Error(`Invalid mode: ${mode}`);
     }