Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run engine-server fixture tests with NODE_ENV=production #5134

Open
nolanlawson opened this issue Jan 13, 2025 · 1 comment
Open

Run engine-server fixture tests with NODE_ENV=production #5134

nolanlawson opened this issue Jan 13, 2025 · 1 comment

Comments

@nolanlawson
Copy link
Collaborator

I'm noticing that if I run the fixture tests in prod mode, I get different results than dev mode. This seems partially due to some dev-only accessors defined here:

function createAccessorThatWarns(propName: string) {

This is causing issues with global HTML properties/attributes in particular, but there seem to be some problems with outerHTML as well.

PoC: b890165

Copy link

git2gus bot commented Jan 13, 2025

This issue has been linked to a new work item: W-17592100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant