Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor : Customs plugins show the same icons #51

Open
BenoitPoulet opened this issue Oct 14, 2024 · 2 comments
Open

Editor : Customs plugins show the same icons #51

BenoitPoulet opened this issue Oct 14, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@BenoitPoulet
Copy link

Hello,

With you themes , in the editor, customs plugins show the same icon, difficult so see what are theses icons.
Look at the right of the icons.

image

Regards.

@saschaleib saschaleib self-assigned this Oct 19, 2024
@saschaleib saschaleib added enhancement New feature or request good first issue Good for newcomers labels Oct 19, 2024
@saschaleib
Copy link
Owner

Hello and thanks for the report. Indeed, that is a side-effect of trying to override the default DokuWiki icons with something a bit more, well, stylish and easier to recognize. But unfortunately, the code that DokuWiki generates is a bit limiting and requires me to do all kinds of workarounds to get the right icon in the right place.

There are already a couple of "special cases" for plugins in the code. If you let me know which plugins you are using here, maybe I can add a few more.

Alternatively, you can use the userstyle.css to add something in the style of:

  #tool__bar #tbbtn_customplugin {
    background-image: url('/custom/images/mypluginicon.svg');
  }

to load your own custom icons here (the ID of the button, and the URL to the icon need to be adapted, of course.

Generally, if the plugin is well supported and others are using it (and would benefit from a specialized icon) I am happy to include it in the template code, if it is rather a fringe use-case, then the custom code is probably the better solution.

@saschaleib
Copy link
Owner

I have provided a pull request for the DokuWiki core that will change the way that these toolbar items can be addressed in the CSS. If this gets accepted, it should also allow to resolve this issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants