Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Nova 4.0 #20

Open
doobie-droid opened this issue Jul 11, 2024 · 1 comment
Open

Upgrade to Nova 4.0 #20

doobie-droid opened this issue Jul 11, 2024 · 1 comment

Comments

@doobie-droid
Copy link

Hey there,

Are there any plans to upgrade the route viewer tool to be compatible with Nova 4.0 ? I followed the installation instructions as listed in the readme.md and landed upon the error

Upgrade to Nova 4.0 - PHP Fatal error: Class Sbine\RouteViewer\RouteViewer contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Laravel\Nova\Tool::menu)

I'm pretty sure the abstract method being referred to is the one in vendor/laravel/nova/src/Tool.php

/** 
* Build the menu that renders the navigation links for the tool. 
* 
* @param  \Illuminate\Http\Request  $request 
* @return mixed
*/
abstract public function menu(Request $request);

I would make a pr but it doesn't seem like there's much activity on the repo anymore given that the last pr made is unattended to

@sbine
Copy link
Owner

sbine commented Jul 19, 2024

I don't currently use Nova but would be happy to accept a PR for this (thanks for the nudge about the last one ;))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants