-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Conjugation] Create conjugation keyboard views XML files #267
Comments
CC @angrezichatterbox, @Linfye, @growabeard Let's have a discussion of how best to achieve the above. In initial discussions, @angrezichatterbox and I agreed that XML files for this would make sense. In iOS all of this is within a single Feedback very welcome! |
I think we would require one XML for each XML. But if are able to work around with the keyboard view we might be able to do in lesser XML files. |
assign |
Assigned :) Feel free to ask any queries in case of doubts. |
Note from the sync, we need to make a decision on how these layouts are structured in code. CC @angrezichatterbox and @akshayw1 :) |
I think it would be better to have separate files as you suggested. Because now thinking about it. If we try to dynamically load the XML for the different views we might have empty spaces as the XML would be loaded first and then the canvas would draw over it. If we work dynamically we would be removing the spaces during the canvas drawing I suppose which would leave empty areas. |
Terms
Description
This issue would add in the XML files for conjugation views for Scribe-Android. A conjugation view for Scribe-iOS can be seen below:
What it is that's pictured above is the keys from the 3x2 conjugation view along with their labels, which are positioned to the top left of each key.
We'll need the following, with the names of the fields coming from Scribe-iOS:
DisplayLeft
DisplayRight
This issue is completed once we have all of the above views, and then clicking the conjugate button will display the 3x2 conjugation view to prove that they can be reached within the keyboard interface.
Contribution
Happy to support as I can and review once a PR is up! 😊
The text was updated successfully, but these errors were encountered: