Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Conjugation] Create conjugation keyboard views XML files #267

Open
2 tasks done
andrewtavis opened this issue Dec 15, 2024 · 6 comments
Open
2 tasks done

[Conjugation] Create conjugation keyboard views XML files #267

andrewtavis opened this issue Dec 15, 2024 · 6 comments
Assignees
Labels
-priority- High priority feature New feature or request help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

This issue would add in the XML files for conjugation views for Scribe-Android. A conjugation view for Scribe-iOS can be seen below:

Simulator Screenshot - iPhone 16 Pro - 2024-12-15 at 18 29 44

What it is that's pictured above is the keys from the 3x2 conjugation view along with their labels, which are positioned to the top left of each key.

We'll need the following, with the names of the fields coming from Scribe-iOS:

  • A 3x2 table that is for first person singular, etc forms
FPSFormKey FPPFormKey
SPSFormKey SPPFormKey
TPSFormKey TPPFormKey
FPSFormLbl FPPFormLbl
SPSFormLbl SPPFormLbl
TPSFormLbl TPPFormLbl
  • A 2x2 table that is for cases where we have four options
TLFormKey TRFormKey
BLFormKey BRFormKey
TLFormLbl TRFormLbl
BLFormLbl BRFormLbl
  • A 1x3 table that is for cases where we have three options
TopFormKey
MiddleFormKey
BottomFormKey
TopFormLbl
MiddleFormLbl
BottomFormLbl
  • A 2x1 table that is for cases where we have two options
LeftFormKey RightFormKey
LeftFormLbl RightFormLbl
  • A 1x1 table that is for showing notifications to the user like when data is not in Wikidata
SingleFormKey
SingleFormLbl
  • We also need buttons for going left and right
    • DisplayLeft
    • DisplayRight

This issue is completed once we have all of the above views, and then clicking the conjugate button will display the 3x2 conjugation view to prove that they can be reached within the keyboard interface.

Contribution

Happy to support as I can and review once a PR is up! 😊

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed -priority- High priority labels Dec 15, 2024
@andrewtavis
Copy link
Member Author

CC @angrezichatterbox, @Linfye, @growabeard

Let's have a discussion of how best to achieve the above. In initial discussions, @angrezichatterbox and I agreed that XML files for this would make sense. In iOS all of this is within a single .xib file that also includes the relative positioning of all elements, but maybe we want XML files for each conjugation view that includes the keys and the labels for each?

Feedback very welcome!

@angrezichatterbox
Copy link
Member

CC @angrezichatterbox, @Linfye, @growabeard

Let's have a discussion of how best to achieve the above. In initial discussions, @angrezichatterbox and I agreed that XML files for this would make sense. In iOS all of this is within a single .xib file that also includes the relative positioning of all elements, but maybe we want XML files for each conjugation view that includes the keys and the labels for each?

Feedback very welcome!

I think we would require one XML for each XML. But if are able to work around with the keyboard view we might be able to do in lesser XML files.

@akshayw1
Copy link
Contributor

akshayw1 commented Jan 6, 2025

assign

@angrezichatterbox
Copy link
Member

Assigned :) Feel free to ask any queries in case of doubts.

@andrewtavis
Copy link
Member Author

Note from the sync, we need to make a decision on how these layouts are structured in code.

CC @angrezichatterbox and @akshayw1 :)

@angrezichatterbox
Copy link
Member

angrezichatterbox commented Jan 11, 2025

@akshayw1

I think it would be better to have separate files as you suggested. Because now thinking about it. If we try to dynamically load the XML for the different views we might have empty spaces as the XML would be loaded first and then the canvas would draw over it. If we work dynamically we would be removing the spaces during the canvas drawing I suppose which would leave empty areas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-priority- High priority feature New feature or request help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

3 participants