Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cursor with new characters in Scribe commands #286

Open
2 tasks done
andrewtavis opened this issue Jan 1, 2025 · 6 comments
Open
2 tasks done

Move cursor with new characters in Scribe commands #286

andrewtavis opened this issue Jan 1, 2025 · 6 comments
Assignees
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

In the current state of Scribe-Android the cursor for the command bar appears after the prompt for the command and before the placeholder text. When the user starts typing the placeholder text disappears as it should, but the cursor is behind the new text. Ideally the command bar cursor should function like a normal cursor and should be the right most character within the command bar text input. See the video below for how it works in Scribe-iOS:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-02.at.00.20.41.mp4

Contribution

Happy to assist with work on this and review it once it's finished! 😊

@andrewtavis andrewtavis added feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jan 1, 2025
@smalik2811
Copy link
Contributor

Hey @andrewtavis I would like to work on this issue 😊

@angrezichatterbox
Copy link
Member

Thanks for taking it up @smalik2811

Feel free to ask any queries you might have here :)

@andrewtavis
Copy link
Member Author

Thanks for your vested interest in the project, @smalik2811! :)

@smalik2811
Copy link
Contributor

Hi @andrewtavis ,

Thanks for your kind words! I'm really enjoying contributing to this project. It's been a fantastic learning experience, and I'm grateful for the support and guidance I've received from the community.

I'm excited to continue contributing and see where this project goes!

Best regards,

@andrewtavis
Copy link
Member Author

Feel free to start this one at your convenience, @smalik2811! Looking forward to getting this up and running so the command UX can start taking the next level :)

Here's the function that we use in iOS, btw:

func insertPriorToCursor(char: String) -> String {
    return substring(toIdx: count - 1) + char + commandCursor
  }

Let us know if there are any questions!

@smalik2811
Copy link
Contributor

Thanks for sharing the iOS code snippet. It's helpful to see how that's being handled. I'll use this as a starting point and let you know, if I run into any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

3 participants