Feature/add-ptp-protocol #4640
Feature/add-ptp-protocol #4640
Conversation
scapy/layers/ptp_v2.py
Outdated
| ByteField("logMessageInterval", 0) | ||
| ] | ||
|
|
||
| def guess_payload_class(self, payload): # type: (bytes) -> Type[Packet] |
There was a problem hiding this comment.
We typically reserve guess_payloaf for complex cases. Here a simpler approach with bind_layers is enough, and it also handles building.
There was a problem hiding this comment.
I removed classes for individual message types and integrated their fields directly as a Conditional Field. Because all these fields are part of the PTP layer rather than being separate layers
scapy/layers/ptp_v2.py
Outdated
| """ | ||
|
|
||
|
|
||
| class FollowUp(Packet): |
There was a problem hiding this comment.
If the packets really are empty, you don't need to include them. Having an enum in the parent that shows this type is enough.
There was a problem hiding this comment.
No, it's not empty., I have to implement fields in those packets.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4640 +/- ##
==========================================
+ Coverage 80.71% 81.62% +0.90%
==========================================
Files 359 360 +1
Lines 86052 86253 +201
==========================================
+ Hits 69461 70404 +943
+ Misses 16591 15849 -742
|
satveerbrar
force-pushed
the
feature/add-ptp-protocol
branch
from
4eb7a14 to
3c72f1a
Compare
@polybassa @gpotter2
Here is the draft PR to add PTP protocol.
Currently this includes basic PTP header and Sync message type.
Planned additions in future commits:
post_buildfunction to calculate and insert message length field.Let me know if I have followed the correct approach.
fixes #4637