Fixing various issues I found when running through the tutorial #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinKavik
reviewed
Jun 27, 2020
| @@ -11,7 +11,7 @@ Let's implement proper filter handling in our `view` functions. (We could do it | |||
| ```rust | |||
| fn view(model: &Model) -> Vec<Node<Msg>> { | |||
| ... | |||
| view_footer(&model.todos, model.filter), | |||
| view_main(&model.todos,model.selected_todo.as_ref(), model.filter), | |||
There was a problem hiding this comment.
I'm surprised that formatter didn't add a space between , and model.se.. => &model.todos,model.selected_todo.as_ref().
There was a problem hiding this comment.
Please just add a space and maybe try to find out why the formatter hasn't fixed it. And I'll merge it.
There was a problem hiding this comment.
Formatter doesn't do markdown files, right? I'll put the space in.
There was a problem hiding this comment.
Yeah you are right, I was thinking about the code in the repo, sorry for confusion. It looks like I copied the code before formatting, my bad.
|
Could you also fix |
…d a single space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59, Fixes #61, Fixes #62 and Fixes #66