Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browsers that both emits KeyPress and KeyDown events risk emitting an event twice #45

Open
Jegp opened this issue Jan 10, 2017 · 2 comments

Comments

@Jegp
Copy link
Member

Jegp commented Jan 10, 2017

I just lost a bunch of text here. Tears were shred. Bunnies died. Go home invisible links!

When browsers emits KeyDown events as well as KeyPress events, there is a risk that two KeyDown events will be emitted for the same event.
Solution: If the browser emits both, remove KeyDown events and convert at KeyPress to KeyUp :: KeyDown.

@ghoranyi
Copy link

Poor bunnies.

@Jegp
Copy link
Member Author

Jegp commented Jan 13, 2017

Right @ghoranyi ?! It took me at least 3 minutes to write a much richer ticket than this version. Naturally I have to take it out on kittens and bunnies to teach the universe a lessen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants