Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/hintboxes #383

Merged
merged 8 commits into from
Jan 22, 2025
Merged

Fix/hintboxes #383

merged 8 commits into from
Jan 22, 2025

Conversation

Thiemann96
Copy link
Contributor

@Thiemann96 Thiemann96 commented Jan 10, 2025

Put some styling on the hint box also updated all docu links for the sensors

grafik

Closes #372

@Thiemann96 Thiemann96 changed the base branch from main to development January 10, 2025 15:08
@BjoernLuig
Copy link
Contributor

I found a few minor things

  • There is still a console.log of the TooltipViewer
  • the new box seems disaligned at the bottom, has another corner roundnes then the other objects and its background color seems out of place (personal opinion)
    grafik
    grafik
  • switching to english language does not apply to all components
    grafik
  • after reload the english title is missing and the button is still in german
    grafik

@Thiemann96
Copy link
Contributor Author

I added english tarnslations, adjusted corner roundness and background color.

However, had my difficulties with the layout (making it aligned with the blockly window) and could not seem to get it to work without restructuring the layout completely. Would like to postpone this to a later date, if you have any idea how to do it, feel free to suggest something, otherwise I would merge and pick it up at a later date

@BjoernLuig
Copy link
Contributor

BjoernLuig commented Jan 21, 2025

Looks good and can be merged in my opinion

@Thiemann96 Thiemann96 merged commit 26fb62b into development Jan 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Hints to blocks
4 participants