Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If APPDATA resolves to a network path, the application might fail to launch #231

Open
dragetd opened this issue Mar 22, 2021 · 1 comment · May be fixed by #251
Open

If APPDATA resolves to a network path, the application might fail to launch #231

dragetd opened this issue Mar 22, 2021 · 1 comment · May be fixed by #251

Comments

@dragetd
Copy link
Member

dragetd commented Mar 22, 2021

We get the APPDATA path via the Windows API in places(_*).go. We found this to be more robust than using the environment variable itself.

But recently we have a customer who fails to launch the bundled application. Upon inspecting the logs, we noticed that APPDATA is resolved to a netowrk-path (starting with //... instead of a mapped drive) and suspect, this could be an issue.

We need to locally reproduce this issue somehow or fake it somehow, pretending that the APPDATA is a network drive. It might be enough to inject it for testing into trivrost at the point where it launches the bundle. If it fails on a network mapped drive, we got the culprit and need to fix/support it somehow.

EDIT: The current code also causes problems in goal determination if a Windows user has configured lower-case driver letters for APPDATA. (Fixed in 1.5.0-rc1)

@dragetd dragetd added this to the v1.5.x milestone Mar 22, 2021
@dragetd dragetd modified the milestones: v1.5.x, v1.5.0 Apr 14, 2021
@MMulthaupt
Copy link
Collaborator

Random idea: when restarting in target directory, pass a flag -isTargetDirRestart and skip the check if it is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants