You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks a lot for the hard work and the great library and sorry for the 2 issues opened in a short time!
Another thing I noticed is some incorrect scrolling behavior when using setReverseLayout and stackFromEnd.
One of the major places we tried to use ShimmerRecyclerView is inside a chat fragment.
The logic in this part is particularly complex concerning the scrolling part and we have to combine several settings of a RecyclerView, as well as doing some additional handling on top of it, to have an appropriate scrolling experience.
One of the things we have done is to combine setReverseLayout and stackFromEnd settings on a RecyclerView for some complex reasons.
However, when switching to ShimmerRecyclerView and keeping the exact same logic, the scrolling behavior is broken and I could not make it work accordingly.
One of the major issue is that it seems to always scroll to the top after loading items, even when forcing some scroll to the bottom.
Both this issue and #38 are not so critical for our project, to be honest.
Our alternative is to have both a RecyclerView and a ShimmerRecyclerView in our layout and to display the ShimmerRecyclerView with the shimmer effect enabled during loading, and to hide it in profit of the RecyclerView when items are loaded (the recyclerview being in charge of displaying the items, thus avoiding these issues).
However, would definitely be a nice to have to simply have the ShimmerRecyclerView and toggle the effect when necessary, rather than using both ShimmerRecyclerView and RecyclerView and switching between and the other.
The text was updated successfully, but these errors were encountered:
- Made demo app to open LIST only page
- Made main page to have two buttons to show normal and shimmer recycler view
- Made changes to support stackEnd and reverseLayout on shimmer view
@Cylix Thanks for raising the issue. Not an expert with both fromStackEnd and setReverseLayout but tried setting up the project as per your mentioned scenarios but to get no luck.
Here is my set up
Made two activities - one with normal RecyclerView and other with ShimmerRecyclerView
Both are LinearLayoutManager type
Enabled reverseLayout and fromStackEnd for the views
Made only one element to appear to check fromStackEnd
Fixed the card size to check reverseLayout
Both the activities showing the element from the top and from the left and I'm unable to infer how fromStackEnd and reverseLayout works
All my changes are in bug_39_no_rev_support and I would be glad if you set up the project to reproduce the issue. You can send PRs to the same branch.
Thanks a lot for the hard work and the great library and sorry for the 2 issues opened in a short time!
Another thing I noticed is some incorrect scrolling behavior when using setReverseLayout and stackFromEnd.
One of the major places we tried to use ShimmerRecyclerView is inside a chat fragment.
The logic in this part is particularly complex concerning the scrolling part and we have to combine several settings of a RecyclerView, as well as doing some additional handling on top of it, to have an appropriate scrolling experience.
One of the things we have done is to combine setReverseLayout and stackFromEnd settings on a RecyclerView for some complex reasons.
However, when switching to ShimmerRecyclerView and keeping the exact same logic, the scrolling behavior is broken and I could not make it work accordingly.
One of the major issue is that it seems to always scroll to the top after loading items, even when forcing some scroll to the bottom.
Both this issue and #38 are not so critical for our project, to be honest.
Our alternative is to have both a RecyclerView and a ShimmerRecyclerView in our layout and to display the ShimmerRecyclerView with the shimmer effect enabled during loading, and to hide it in profit of the RecyclerView when items are loaded (the recyclerview being in charge of displaying the items, thus avoiding these issues).
However, would definitely be a nice to have to simply have the ShimmerRecyclerView and toggle the effect when necessary, rather than using both ShimmerRecyclerView and RecyclerView and switching between and the other.
The text was updated successfully, but these errors were encountered: