Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaks on Node 22 #397

Open
kibertoad opened this issue Jan 18, 2025 · 4 comments
Open

Breaks on Node 22 #397

kibertoad opened this issue Jan 18, 2025 · 4 comments

Comments

@kibertoad
Copy link

kibertoad commented Jan 18, 2025 •
edited
Loading

When trying to install bundlesize 0.18.2 on Node 22, the following error is thrown:

npm error path /home/runner/work/app/node_modules/iltorb
npm error command failed
npm error command sh -c node ./scripts/install.js || node-gyp rebuild
npm error make: Entering directory '/home/runner/work/app/node_modules/iltorb/build'
npm error   CC(target) Release/obj.target/iltorb/brotli/c/common/dictionary.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/common/transform.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/dec/bit_reader.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/dec/decode.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/dec/huffman.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/dec/state.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/enc/backward_references.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/enc/backward_references_hq.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/enc/bit_cost.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/enc/block_splitter.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/enc/brotli_bit_stream.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/enc/cluster.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/enc/compress_fragment.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/enc/compress_fragment_two_pass.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/enc/dictionary_hash.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/enc/encode.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/enc/encoder_dict.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/enc/entropy_encode.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/enc/histogram.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/enc/literal_cost.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/enc/memory.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/enc/metablock.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/enc/static_dict.o
npm error   CC(target) Release/obj.target/iltorb/brotli/c/enc/utf8_util.o
npm error   CXX(target) Release/obj.target/iltorb/src/common/allocator.o
npm error make: Leaving directory '/home/runner/work/app/node_modules/iltorb/build'
npm error info install installing standalone, skipping download.
npm error gyp info it worked if it ends with ok
npm error gyp info using [email protected]
npm error gyp info using [email protected] | linux | x64
npm error gyp info find Python using Python version 3.12.3 found at "/usr/bin/python3"
npm error gyp http GET https://nodejs.org/download/release/v22.13.0/node-v22.13.0-headers.tar.gz
npm error gyp http 200 https://nodejs.org/download/release/v22.13.0/node-v22.13.0-headers.tar.gz
npm error gyp http GET https://nodejs.org/download/release/v22.13.0/SHASUMS256.txt
npm error gyp http 200 https://nodejs.org/download/release/v22.13.0/SHASUMS256.txt
npm error gyp info spawn /usr/bin/python3
npm error gyp info spawn args [
npm error gyp info spawn args '/opt/hostedtoolcache/node/22.13.0/x64/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
npm error gyp info spawn args 'binding.gyp',
npm error gyp info spawn args '-f',
npm error gyp info spawn args 'make',
npm error gyp info spawn args '-I',
npm error gyp info spawn args '/home/runner/work/lokalise-main/lokalise-main/services/app/lokalise-ui/node_modules/iltorb/build/config.gypi',
npm error gyp info spawn args '-I',
npm error gyp info spawn args '/opt/hostedtoolcache/node/22.13.0/x64/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
npm error gyp info spawn args '-I',
npm error gyp info spawn args '/home/runner/.cache/node-gyp/22.13.0/include/node/common.gypi',
npm error gyp info spawn args '-Dlibrary=shared_library',
npm error gyp info spawn args '-Dvisibility=default',
npm error gyp info spawn args '-Dnode_root_dir=/home/runner/.cache/node-gyp/22.13.0',
npm error gyp info spawn args '-Dnode_gyp_dir=/opt/hostedtoolcache/node/22.13.0/x64/lib/node_modules/npm/node_modules/node-gyp',
npm error gyp info spawn args '-Dnode_lib_file=/home/runner/.cache/node-gyp/22.13.0/<(target_arch)/node.lib',
npm error gyp info spawn args '-Dmodule_root_dir=/home/runner/work/app/node_modules/iltorb',
npm error gyp info spawn args '-Dnode_engine=v8',
npm error gyp info spawn args '--depth=.',
npm error gyp info spawn args '--no-parallel',
npm error gyp info spawn args '--generator-output',
npm error gyp info spawn args 'build',
npm error gyp info spawn args '-Goutput_dir=.'
npm error gyp info spawn args ]
npm error gyp info spawn make
npm error gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
npm error ../brotli/c/dec/decode.c:1954:41: warning: argument 2 of type ‘const uint8_t *’ {aka ‘const unsigned char *’} declared as a pointer [-Wvla-parameter]
npm error  1954 |     size_t encoded_size, const uint8_t* encoded_buffer, size_t* decoded_size,
npm error       |                          ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
npm error In file included from ../brotli/c/dec/decode.c:7:
npm error ../brotli/c/include/brotli/decode.h:204:19: note: previously declared as a variable length array ‘const uint8_t[encoded_size]’ {aka ‘const unsigned char[encoded_size]’}
npm error   204 |     const uint8_t encoded_buffer[BROTLI_ARRAY_PARAM(encoded_size)],
npm error       |     ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
npm error ../brotli/c/dec/decode.c:1955:14: warning: argument 4 of type ‘uint8_t *’ {aka ‘unsigned char *’} declared as a pointer [-Wvla-parameter]
npm error  1955 |     uint8_t* decoded_buffer) {
npm error       |     ~~~~~~~~~^~~~~~~~~~~~~~
npm error ../brotli/c/include/brotli/decode.h:206:13: note: previously declared as a variable length array ‘uint8_t[*decoded_size]’ {aka ‘unsigned char[*decoded_size]’}
npm error   206 |     uint8_t decoded_buffer[BROTLI_ARRAY_PARAM(*decoded_size)]);
npm error       |     ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
npm error ../brotli/c/enc/encode.c:1433:20: warning: argument 5 of type ‘const uint8_t *’ {aka ‘const unsigned char *’} declared as a pointer [-Wvla-parameter]
npm error  1433 |     const uint8_t* input_buffer, size_t* encoded_size,
npm error       |     ~~~~~~~~~~~~~~~^~~~~~~~~~~~
npm error In file included from ../brotli/c/enc/encode.c:9:
npm error ../brotli/c/include/brotli/encode.h:293:19: note: previously declared as a variable length array ‘const uint8_t[input_size]’ {aka ‘const unsigned char[input_size]’}
npm error   293 |     const uint8_t input_buffer[BROTLI_ARRAY_PARAM(input_size)],
npm error       |     ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
npm error ../brotli/c/enc/encode.c:1434:14: warning: argument 7 of type ‘uint8_t *’ {aka ‘unsigned char *’} declared as a pointer [-Wvla-parameter]
npm error  1434 |     uint8_t* encoded_buffer) {
npm error       |     ~~~~~~~~~^~~~~~~~~~~~~~
npm error ../brotli/c/include/brotli/encode.h:295:13: note: previously declared as a variable length array ‘uint8_t[*encoded_size]’ {aka ‘unsigned char[*encoded_size]’}
npm error   295 |     uint8_t encoded_buffer[BROTLI_ARRAY_PARAM(*encoded_size)]);
npm error       |     ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
npm error In file included from ../src/common/allocator.cc:1:
npm error ../../nan/nan.h: In function ‘void Nan::SetAccessor(v8::Local<v8::ObjectTemplate>, v8::Local<v8::String>, GetterCallback, SetterCallback, v8::Local<v8::Value>, v8::AccessControl, v8::PropertyAttribute, imp::Sig)’:
npm error ../../nan/nan.h:2546:19: error: no matching function for call to ‘v8::ObjectTemplate::SetAccessor(v8::Local<v8::String>&, void (*&)(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>&), void (*&)(v8::Local<v8::Name>, v8::Local<v8::Value>, const v8::PropertyCallbackInfo<void>&), v8::Local<v8::Object>&, v8::AccessControl&, v8::PropertyAttribute&)’
npm error  2546 |   tpl->SetAccessor(
npm error       |   ~~~~~~~~~~~~~~~~^
npm error  2547 |       name
npm error       |       ~~~~         
npm error  2548 |     , getter_
npm error       |     ~~~~~~~~~      
npm error  2549 |     , setter_
npm error       |     ~~~~~~~~~      
npm error  2550 |     , obj
npm error       |     ~~~~~          
npm error  2551 |     , settings
npm error       |     ~~~~~~~~~~     
npm error  2552 |     , attribute
npm error       |     ~~~~~~~~~~~    
npm error  2553 | #if (NODE_MODULE_VERSION < NODE_16_0_MODULE_VERSION)
npm error       | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
npm error  2554 |     , signature
npm error       |     ~~~~~~~~~~~    
npm error  2555 | #endif
npm error       | ~~~~~~             
npm error  2556 |   );
npm error       |   ~                
npm error In file included from /home/runner/.cache/node-gyp/22.13.0/include/node/v8-function.h:15,
npm error                  from /home/runner/.cache/node-gyp/22.13.0/include/node/v8.h:33,
npm error                  from /home/runner/.cache/node-gyp/22.13.0/include/node/node.h:73,
npm error                  from ../../nan/nan.h:60:
npm error /home/runner/.cache/node-gyp/22.13.0/include/node/v8-template.h:1049:8: note: candidate: ‘void v8::ObjectTemplate::SetAccessor(v8::Local<v8::String>, v8::AccessorGetterCallback, v8::AccessorSetterCallback, v8::Local<v8::Value>, v8::PropertyAttribute, v8::SideEffectType, v8::SideEffectType)’
npm error  1049 |   void SetAccessor(
npm error       |        ^~~~~~~~~~~
npm error /home/runner/.cache/node-gyp/22.13.0/include/node/v8-template.h:1052:61: note:   no known conversion for argument 5 from ‘v8::AccessControl’ to ‘v8::PropertyAttribute’
npm error  1052 |       Local<Value> data = Local<Value>(), PropertyAttribute attribute = None,
npm error       |                                           ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
npm error /home/runner/.cache/node-gyp/22.13.0/include/node/v8-template.h:1055:8: note: candidate: ‘void v8::ObjectTemplate::SetAccessor(v8::Local<v8::Name>, v8::AccessorNameGetterCallback, v8::AccessorNameSetterCallback, v8::Local<v8::Value>, v8::PropertyAttribute, v8::SideEffectType, v8::SideEffectType)’
npm error  1055 |   void SetAccessor(
npm error       |        ^~~~~~~~~~~
npm error /home/runner/.cache/node-gyp/22.13.0/include/node/v8-template.h:1058:61: note:   no known conversion for argument 5 from ‘v8::AccessControl’ to ‘v8::PropertyAttribute’
npm error  1058 |       Local<Value> data = Local<Value>(), PropertyAttribute attribute = None,
npm error       |                                           ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
npm error ../../nan/nan.h: In function ‘void Nan::SetAccessor(v8::Local<v8::ObjectTemplate>, v8::Local<v8::String>, GetterCallback, SetterCallback, v8::Local<v8::Value>, v8::AccessControl, v8::PropertyAttribute)’:
npm error ../../nan/nan.h:2592:19: error: no matching function for call to ‘v8::ObjectTemplate::SetAccessor(v8::Local<v8::String>&, void (*&)(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>&), void (*&)(v8::Local<v8::Name>, v8::Local<v8::Value>, const v8::PropertyCallbackInfo<void>&), v8::Local<v8::Object>&, v8::AccessControl&, v8::PropertyAttribute&)’
npm error  2592 |   tpl->SetAccessor(
npm error       |   ~~~~~~~~~~~~~~~~^
npm error  2593 |       name
npm error       |       ~~~~         
npm error  2594 |     , getter_
npm error       |     ~~~~~~~~~      
npm error  2595 |     , setter_
npm error       |     ~~~~~~~~~      
npm error  2596 |     , obj
npm error       |     ~~~~~          
npm error  2597 |     , settings
npm error       |     ~~~~~~~~~~     
npm error  2598 |     , attribute
npm error       |     ~~~~~~~~~~~    
npm error  2599 |   );
npm error       |   ~                
npm error /home/runner/.cache/node-gyp/22.13.0/include/node/v8-template.h:1049:8: note: candidate: ‘void v8::ObjectTemplate::SetAccessor(v8::Local<v8::String>, v8::AccessorGetterCallback, v8::AccessorSetterCallback, v8::Local<v8::Value>, v8::PropertyAttribute, v8::SideEffectType, v8::SideEffectType)’
npm error  1049 |   void SetAccessor(
npm error       |        ^~~~~~~~~~~
npm error /home/runner/.cache/node-gyp/22.13.0/include/node/v8-template.h:1052:61: note:   no known conversion for argument 5 from ‘v8::AccessControl’ to ‘v8::PropertyAttribute’
npm error  1052 |       Local<Value> data = Local<Value>(), PropertyAttribute attribute = None,
npm error       |                                           ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
npm error /home/runner/.cache/node-gyp/22.13.0/include/node/v8-template.h:1055:8: note: candidate: ‘void v8::ObjectTemplate::SetAccessor(v8::Local<v8::Name>, v8::AccessorNameGetterCallback, v8::AccessorNameSetterCallback, v8::Local<v8::Value>, v8::PropertyAttribute, v8::SideEffectType, v8::SideEffectType)’
npm error  1055 |   void SetAccessor(
npm error       |        ^~~~~~~~~~~
npm error /home/runner/.cache/node-gyp/22.13.0/include/node/v8-template.h:1058:61: note:   no known conversion for argument 5 from ‘v8::AccessControl’ to ‘v8::PropertyAttribute’
npm error  1058 |       Local<Value> data = Local<Value>(), PropertyAttribute attribute = None,
npm error       |                                           ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
npm error In file included from /home/runner/.cache/node-gyp/22.13.0/include/node/v8-array-buffer.h:12,
npm error                  from /home/runner/.cache/node-gyp/22.13.0/include/node/v8.h:24:
npm error /home/runner/.cache/node-gyp/22.13.0/include/node/v8-local-handle.h: In instantiation of ‘v8::Local<T>::Local(v8::Local<S>) [with S = v8::Data; T = v8::Value]’:
npm error ../../nan/nan_callbacks_12_inl.h:175:53:   required from here
npm error /home/runner/.cache/node-gyp/22.13.0/include/node/v8-local-handle.h:269:42: error: static assertion failed: type check
npm error   269 |     static_assert(std::is_base_of<T, S>::value, "type check");
npm error       |                                          ^~~~~
npm error /home/runner/.cache/node-gyp/22.13.0/include/node/v8-local-handle.h:269:42: note: ‘std::integral_constant<bool, false>::value’ evaluates to false
npm error make: *** [iltorb.target.mk:146: Release/obj.target/iltorb/src/common/allocator.o] Error 1
npm error gyp ERR! build error 
npm error gyp ERR! stack Error: `make` failed with exit code: 2
npm error gyp ERR! stack at ChildProcess.<anonymous> (/opt/hostedtoolcache/node/22.13.0/x64/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:216:23)
npm error gyp ERR! System Linux 6.8.0-1017-azure
npm error gyp ERR! command "/opt/hostedtoolcache/node/22.13.0/x64/bin/node" "/opt/hostedtoolcache/node/22.13.0/x64/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
npm error gyp ERR! cwd /home/runner/work/lokalise-main/lokalise-main/services/app/lokalise-ui/node_modules/iltorb
npm error gyp ERR! node -v v22.13.0
npm error gyp ERR! node-gyp -v v11.0.0
npm error gyp ERR! not ok
npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2025-01-18T10_57_38_873Z-debug-0.log
@kibertoad
Copy link
Author

Updating to newer brotli-size is likely to help

@kibertoad
Copy link
Author

related: #370

@siddharthkp
Copy link
Owner

Hey! Can you confirm if https://github.com/siddharthkp/bundlesize2 solves this for you?

@kibertoad
Copy link
Author

@siddharthkp yup, it does!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kibertoad @siddharthkp