Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default browser image icon with title = "Image not found" #1709

Open
sabina-talipova opened this issue Mar 14, 2024 · 5 comments
Open

Default browser image icon with title = "Image not found" #1709

sabina-talipova opened this issue Mar 14, 2024 · 5 comments

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Mar 14, 2024

Description

ENV: SC PHP8.3 Chrome Installer

I see default browser image icon with title = "Image not found" if I insert image in WYSIWYG editor and image is not published.

Screenshot_2024-03-13_at_10 33 43_AM (1)

Steps to reproduce issue

  • I insert image in Content field (WYSIWYG editor) on a Page
  • I publish the Page
  • I can see the image as unauthorized user
  • As admin I unpublish the image in CMS "Files" section
  • I cannot see the image as unauthorized user, but I see default image icon.
@GuySartorelli
Copy link
Member

What steps did you take to get into this condition?
I assume you unpublished the image after publishing the page?

Have you checked this behaviour locally in 5.1 to be sure it's a regression with Silverstripe CMS?

@sabina-talipova
Copy link
Contributor Author

What steps did you take to get into this condition?

I follow scenarios that we have in Cucumber Studio.

I assume you unpublished the image after publishing the page?

It is one of the step. Please, see this instruction (https://studio.cucumber.io/projects/301855/test-plan/folders/2145967/scenarios/7080337).

Have you checked this behaviour locally in 5.1 to be sure it's a regression with Silverstripe CMS?

I'll check, but I think it exists in CMS 5.1 as well, we just ignored it as an issue when did last regression tests. It's not a regression issue.
I think main question is it expected behaviour, that we show browser image icon like a message "here should be image, but something went wrong" or we should avoid any missing content.

@sabina-talipova sabina-talipova changed the title CMS 5.2.0-beta1. Regression test: Default browser image icon with title = "Image not found" Default browser image icon with title = "Image not found" Mar 15, 2024
@GuySartorelli
Copy link
Member

Yeah definitely something we need to decide how to handle - my main point is if it's not a regression we can handle it after 5.2.0, whereas if it's a regression we probably need to prioritise it sooner.

@maxime-rainville
Copy link
Contributor

I couldn't replicate this locally. Do we still have this issue in the sandbox?

@sabina-talipova
Copy link
Contributor Author

sabina-talipova commented Mar 18, 2024

I tested on 5.2 and 5.1 in my local. Issue exists.

Screenshot 2024-03-19 at 8 26 59 AM

I've updated the description with steps how to reproduce issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants