Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: customStyleBuilder is not accumulating styles #2447

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix: customStyleBuilder is not accumulating styles #2447

wants to merge 1 commit into from

Conversation

CatHood0
Copy link
Collaborator

@CatHood0 CatHood0 commented Jan 19, 2025 •
edited
Loading

Description

Fix issue where the customStyleBuilder does not accumulate styles when multiple attributes are applied to the same text.

Related Issues

Fix #2425

  • ✨ Feature: New functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Refactor: Code reorganization, no behavior change.
  • ❌ Breaking: Alters existing functionality and requires updates.
  • 🧪 Tests: New or modified tests
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • ✅ Build configuration change: Build/configuration changes.

@CatHood0 CatHood0 self-assigned this Jan 19, 2025
@CatHood0 CatHood0 marked this pull request as draft January 19, 2025 19:29
@CatHood0
Copy link
Collaborator Author

@manudicri can you test if these changes fix your issue? I cannot really reproduce your issue, but i think that, with these changes, it could be fixed.

EchoEllet
EchoEllet reviewed Jan 19, 2025
View reviewed changes
lib/src/editor/widgets/delegate.dart
Comment on lines -13 to +14
typedef CustomStyleBuilder = TextStyle Function(Attribute attribute);
typedef CustomStyleBuilder = TextStyle Function(
Attribute attribute, TextStyle style);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a breaking change if this is a public API?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm... Probably. It's difficult without change the CustomStyleBuilder. I'm waiting for the response of @manudicri to know if i need to made more changes.

@CatHood0 CatHood0 added bug Something isn't working in progress This issue or feature is currently being worked on by someone. minor Minimal impact or cosmetic issue. Can be resolved at a later time without affecting overall function awaiting response Pending additional information or feedback from the issue creator labels Jan 20, 2025
@manudicri
Copy link

Hi @CatHood0 ,
I think it could be fine, so I can add my custom styles by adding them to the TextStyle (even though I have to use .copyWith, I don't know if that could work).
Anyway, It's not urgent to me anymore since I found another workaround, but I thought it could be a problem to someone else, too.

@CatHood0 CatHood0 assigned CatHood0 and unassigned CatHood0 Jan 24, 2025
@CatHood0 CatHood0 removed the awaiting response Pending additional information or feedback from the issue creator label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EchoEllet EchoEllet EchoEllet left review comments

Assignees

@CatHood0 CatHood0

Labels
bug Something isn't working in progress This issue or feature is currently being worked on by someone. minor Minimal impact or cosmetic issue. Can be resolved at a later time without affecting overall function
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

customStyleBuilder Does Not Accumulate Styles for Multiple Attributes
3 participants
@CatHood0 @manudicri @EchoEllet