Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BoxDecoration for DefaultTextBlockStyle of header Attribute #2429

Open
1 task done
satotoshitaka11 opened this issue Jan 8, 2025 · 3 comments
Open
1 task done
Labels
enhancement New feature or request

Comments

@satotoshitaka11
Copy link

Is there an existing issue for this?

Use case

In the current implementation of Flutter Quill, it is not possible to apply a BoxDecoration to the header attribute's DefaultTextBlockStyle. This limitation prevents users from customizing the appearance of headers, such as adding borders, background colors, or other decorations.

Adding a BoxDecoration to the header block, as shown in the attached screenshots, would improve the flexibility of customization.

Current Desired

Proposal

Add support for BoxDecoration in the DefaultTextBlockStyle of the header attribute.

Refer to the images in the Use case section for a visual comparison.

@satotoshitaka11 satotoshitaka11 added the enhancement New feature or request label Jan 8, 2025
@satotoshitaka11
Copy link
Author

Since I am unable to push the changes directly, I have attached the modified files to this issue for your review.

Please kindly check the attached files for the necessary changes.

flutter_quill_header_style_update.zip

@EchoEllet EchoEllet self-assigned this Jan 8, 2025
@EchoEllet
Copy link
Collaborator

EchoEllet commented Jan 10, 2025

Since I am unable to push the changes directly

Thank you for your contribution. We can't use code that's not written by us as the commit history would register it under our name. The changes of the commit must be made by the contributor.

@EchoEllet EchoEllet removed their assignment Jan 10, 2025
@EchoEllet EchoEllet added the awaiting response Pending additional information or feedback from the issue creator label Jan 10, 2025
@satotoshitaka11
Copy link
Author

@EchoEllet
Please kindly check this PR.
#2438

@EchoEllet EchoEllet removed the awaiting response Pending additional information or feedback from the issue creator label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants