Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.1.2 docker image from master not working #32

Open
rogelio-telnyx opened this issue Oct 18, 2019 · 12 comments
Open

v0.1.2 docker image from master not working #32

rogelio-telnyx opened this issue Oct 18, 2019 · 12 comments

Comments

@rogelio-telnyx
Copy link

rogelio-telnyx commented Oct 18, 2019

Hello, we're trying to run the latest docker master image, but we're getting this error and then the container stops:

# docker run sipcapture/homer-view:master
Cannot match against 'undefined' or 'null'

If we change to the latest image (version 0.1.1) it works fine, any ideas what can be causing this?
Thanks.

@rogelio-telnyx rogelio-telnyx changed the title v0.1.1 docker image from master not working v0.1.2 docker image from master not working Oct 18, 2019
@lmangani
Copy link
Member

Hi @rogelio-telnyx have you tried building a local image? I'll try replicate this deeper

@lmangani
Copy link
Member

FYI Just pushed a new version from CI to test with

@rogelio-telnyx
Copy link
Author

@lmangani are there any updates on this issue?

@lmangani
Copy link
Member

@rogelio-telnyx have you tried using the latest images? There were no comments to my update on Oct 18th - just to be sure this is still the case. We also suggest you build your own images using the Dockerfiles included in the repository for consistency.

@rogelio-telnyx
Copy link
Author

@lmangani we tried with the official docker image and also building it from sources using the master branch from October 8th. On both cases we get the same error: Cannot match against 'undefined' or 'null'
Are we missing an env variable?

@lmangani
Copy link
Member

Are you launching it with a config file? See example here: https://github.com/sipcapture/homer-view-react/blob/master/example/docker-compose.yml

@enzoqtvf
Copy link

Hi @lmangani I was able to clearly reproduce the issue (I've been testing using a specific config file, but I don't think the issue is coming from there since it was working for us before)
Here is what I think is breaking the docker image when we are running it : 1752240

I've been making 2 branches to show that:

Let me know if I should be more specific there

cc @rogelio-telnyx

@lmangani
Copy link
Member

Thanks @enzoqtvf this would explain a lot. Let's roll it back and investigate in parallel.

@enzoqtvf
Copy link

Sounds good ! Thanks a lot @lmangani

@lmangani
Copy link
Member

Done - FYI to explain why the testing was not matching, deleting the existing package-lock should really have the same effect as the requirement is indeed, correct and that's how this is currently tested.

Let me know if we're out of the woods!

@enzoqtvf
Copy link

enzoqtvf commented Dec 2, 2019

Looking good, we can now build the image and run it :)
Thank you @lmangani !

@rogelio-telnyx
Copy link
Author

@lmangani we can now run it but it looks just like v0.1.1, without any of the expected changes for v0.1.2, can you please confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants