Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging according code guidelines #1755

Open
4 tasks
DmytroNazarenko opened this issue Dec 14, 2023 · 0 comments · May be fixed by #2076
Open
4 tasks

Improve logging according code guidelines #1755

DmytroNazarenko opened this issue Dec 14, 2023 · 0 comments · May be fixed by #2076
Assignees
@PropzSaladaz
Labels
Technical debt
Milestone
SKALE 4.1

Comments

@DmytroNazarenko
Copy link
Collaborator

We need to improve logging in skaled according code guidelines in all modules:

  • Use one logger instead of several ( preferable LOG( m_TYPElogger) )
  • Remove colors from logs
  • Remove std::endl in the end of logs
  • Fix typos
@DmytroNazarenko DmytroNazarenko added this to the SKALE 2.4 milestone Dec 14, 2023
@PolinaKiporenko PolinaKiporenko moved this from To Do to Ready For Pickup in SKALE Engineering 🚀 Jan 25, 2024
@PolinaKiporenko PolinaKiporenko moved this from Ready For Pickup to To Do in SKALE Engineering 🚀 Jan 25, 2024
@PolinaKiporenko PolinaKiporenko moved this from To Do to Ready For Pickup in SKALE Engineering 🚀 Jan 25, 2024
@PolinaKiporenko PolinaKiporenko modified the milestones: SKALE 2.4, SKALE 2.5 Apr 29, 2024
@DmytroNazarenko DmytroNazarenko modified the milestones: SKALE 2.5, SKALE 2.6 May 13, 2024
@PolinaKiporenko PolinaKiporenko moved this from Ready For Pickup to To Do in SKALE Engineering 🚀 Oct 10, 2024
PropzSaladaz added a commit that referenced this issue Jan 13, 2025
@PropzSaladaz
remove std::endl in the end of logs; #1755
262d29e
PropzSaladaz added a commit that referenced this issue Jan 13, 2025
@PropzSaladaz
update loggers to use LOG( m_typeLogger ); #1755
9562f70
PropzSaladaz added a commit that referenced this issue Jan 13, 2025
@PropzSaladaz
Remove colors from logs; #1755
3410635
PropzSaladaz added a commit that referenced this issue Jan 13, 2025
@PropzSaladaz
Refactor clogs; #1755
1e4f2a8
@PropzSaladaz PropzSaladaz linked a pull request Jan 13, 2025 that will close this issue
Open
olehnikolaiev added a commit that referenced this issue Jan 13, 2025
@olehnikolaiev
#1755 format code
990deca
olehnikolaiev added a commit that referenced this issue Jan 13, 2025
@olehnikolaiev
#1755 format code
dd0fbcc
PropzSaladaz added a commit that referenced this issue Jan 14, 2025
@PropzSaladaz
remove missed endl; rename loggers; #1755
adf143b
olehnikolaiev added a commit that referenced this issue Jan 15, 2025
@olehnikolaiev
#1755 format
1b1f42f
olehnikolaiev added a commit that referenced this issue Jan 15, 2025
@olehnikolaiev
#1755 format
1803b01
@PolinaKiporenko PolinaKiporenko moved this to In Progress in SKALE Engineering 🚀 Jan 15, 2025
PropzSaladaz added a commit that referenced this issue Jan 15, 2025
@PropzSaladaz
fix mis-deleted endl for std; remove unused code; #1755
1c2050d
PropzSaladaz added a commit that referenced this issue Jan 20, 2025
@PropzSaladaz
apply review changes; #1755
585c9d0
PropzSaladaz added a commit that referenced this issue Jan 21, 2025
@PropzSaladaz
remove unused commented code; improve logs; #1755
6627f8d
olehnikolaiev added a commit that referenced this issue Jan 23, 2025
@olehnikolaiev
#1755 format
7b349b4
PropzSaladaz added a commit that referenced this issue Jan 24, 2025
@PropzSaladaz
Revert "#1755 format"
f833e40 
This reverts commit 7b349b4.
PropzSaladaz added a commit that referenced this issue Jan 24, 2025
@PropzSaladaz
format; #1755
3320426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PropzSaladaz PropzSaladaz

Labels
Technical debt
Projects
SKALE Engineering 🚀
Status: In Progress
Milestone
SKALE 4.1
Development

Successfully merging a pull request may close this issue.

Enhancement/1755 Improve Logging skalenetwork/skaled
4 participants
@dimalit @DmytroNazarenko @PropzSaladaz @PolinaKiporenko