Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to run code quality checks on pull requests to development and main branches #92

Open
Akalanka47000 opened this issue Jul 29, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Akalanka47000
Copy link
Member

Akalanka47000 commented Jul 29, 2023

There'll be 3 jobs to be run in parallel

  • Run linter
  • Run prettier formatter and if there are changes left on complete, add them back and commit to the repo if there is enough permission or else fail the job with a suitable error message
  • Run commitlint and validate the commit message

All 3 can implemented as reusable actions under the following repo and consumed. Later these can be united under a resuable workflow. A new folder with a name of code-quality can be added for this purpose and registered under workspaces

The third needs to check if the repo already has a commitlint.config.js file and if it is not there, download one which is defined under the actions directory, the contents of the file will be the same as the ones in this repo. The necessary dependencies must be installed as well if not already available

@Akalanka47000 Akalanka47000 added the enhancement New feature or request label Jul 29, 2023
@Akalanka47000 Akalanka47000 changed the title Add workflow to run linter on pull requests to development and main branches Add workflow to run code quality checks on pull requests to development and main branches Jul 29, 2023
This was referenced Jul 30, 2023
@sithumonline
Copy link
Member

@Akalanka47000 we can close this right?

@Akalanka47000
Copy link
Member Author

@Akalanka47000 we can close this right?

There's some issue with the format action, doesn't commit back the code after formatting, would you be able to have a look pls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants