Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to Replace Sweave Vignettes with R Markdown #13

Open
sonali8434 opened this issue Jun 6, 2023 · 5 comments
Open

Request to Replace Sweave Vignettes with R Markdown #13

sonali8434 opened this issue Jun 6, 2023 · 5 comments

Comments

@sonali8434
Copy link
Contributor

sonali8434 commented Jun 6, 2023

Hello @smgogarten, I'm a Sweave2Rmd volunteer. @jwokaty and I are trying to replace Bioconductor Sweave vignettes with R Markdown. It has many advantages over Sweave vignettes, such as R Markdown converts to HTML, uses BiocStyle, and is easier to maintain.

Would you consider accepting pull requests for R Markdown versions of the following vignettes from one of our volunteers?
- GWASTools/vignettes/Affymetrix.Rnw
- GWASTools/vignettes/DataCleaning.Rnw

We'll ask you to review and accept the pull request. You'll also need to bump the version number in your DESCRIPTION file so that the Bioconductor build machines will recognize that a new version is available.

Thank you for your time, I look forward to your response.

@smgogarten
Copy link
Owner

Yes, absolutely! Thank you for doing this!

@sonali8434
Copy link
Contributor Author

Thank you!

@sonali8434
Copy link
Contributor Author

sonali8434 commented Jun 20, 2023

Hello, @smgogarten!

I wanted to inform you that I have submitted a pull request for the conversion of GWASTools/vignettes/Affymetrix.Rnw. Kindly take a look at it when you have some free time.

Thank you for your valuable time!

@jwokaty
Copy link
Contributor

jwokaty commented Aug 10, 2023

Hi @smgogarten

I work with Somali on Sweave2Rmd. I noticed that in DataCleaning.Rnw the URLs for the Geneva project at http://www.genevastudy.org/ and Genomic Data Structure at http://corearray.sourceforge.net/ are out of date. I know that information can get out of date so before we perform any further work, I want to ask if DataCleaning.Rnw is still a viable vignette and these URLs or this section should be updated? Or do you plan to deprecate this vignette in the future such that it should not be converted? I would appreciate your guidance. Thanks for working with us!

Jen

@smgogarten
Copy link
Owner

The vignette is still viable; when you do the Rmd conversion could you please update the URLs as follows:
http://www.genevastudy.org/ -> https://www.ncbi.nlm.nih.gov/pmc/articles/PMC2860056/
http://corearray.sourceforge.net/ -> https://github.com/zhengxwen/gdsfmt
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants