[bug] TagsInput x button does not trigger "value" callback

[ctdunc]

Hello,
Noticing that when using TagsInput removing an item with the delete button in the pill does not trigger callbacks taking the value prop as an input. Deleting it with the keyboard does trigger the callback.

Can be seen on the dmc documentation website.

[AnnMarieW]

Hi @ctdunc

Thanks for reporting - I could also replicate the issue in the docs

[ctdunc]

Done a bit more testing, I think this is probably my fault, but I'm not sure how I would go about fixing this upstream.

This is new in 0.14.6 and I think related to this commit (which I authored).

I've spent a bit of time messing with it this morning, but need to move on. Here's what I've found that may help someone with fewer skill issues (or more time) get started:

Clicking x on a pill triggers useDidUpdate for selected but not value. Deleting a pill with backspace or adding a pill triggers useDidUpdate for selected and then value. For some reason, it looks whatever is passed to setProps({value: selected}) does not appear to trigger value to actually change when using the delete button from a pill.

Hopefully can revisit this soon

[AnnMarieW]

Thanks for investigating, this is really helpful!

[AnnMarieW]

@ctdunc
dmc 0.14.6 uses Mantine 7.13.2.
The changes you made affected which versions of Mantine? Will the most recent changes fix this issue?

I also verified that this worked in 0.14.5 and broke in 0.14.6 Looks like an upstream issue

[ctdunc]

I do not believe the most recent changes fix it. I will have to look more closely once i am not traveling.

I think I made one of the classic "dont mutate state directly" blunders upstream trying to fix a different issue in the linked PR. unfortunately for whatever reason the mantine build install is blocked on my companies network so i wasnt able to look at work.

Rolling this back will break the removal of items when duplicates are enabled, but possibly worth?

[AnnMarieW]

Looks like there is a fix in the works mantinedev/mantine#7105 🎉
Thanks @ctdunc !

[AnnMarieW]

This was fixed in Mantine 7.14.1. I just ran the docs locally with the prerelease version of DMC 0.15.0 and confirmed that it works 🥳

Thanks for your help with this @ctdunc

Closing now :-)