diff --git a/composer.json b/composer.json index 1e187caf..e69508ce 100644 --- a/composer.json +++ b/composer.json @@ -52,7 +52,7 @@ "phpunit/phpunit": "^9.5", "psalm/plugin-phpunit": "^0.18", "psalm/plugin-symfony": "^5.0", - "rector/rector": "^0.17", + "rector/rector": "^0.18", "sonata-project/doctrine-orm-admin-bundle": "^4.0", "symfony/browser-kit": "^5.4 || ^6.2", "symfony/css-selector": "^5.4 || ^6.2", diff --git a/tests/Checker/TranslatableCheckerTest.php b/tests/Checker/TranslatableCheckerTest.php index 96dd00dd..32f8c8c3 100644 --- a/tests/Checker/TranslatableCheckerTest.php +++ b/tests/Checker/TranslatableCheckerTest.php @@ -33,7 +33,7 @@ protected function setUp(): void /** * @return iterable, array}> */ - public function provideTestIsTranslatable(): iterable + public function provideIsTranslatableCases(): iterable { yield 'object-by-model' => [ new ModelCustomTranslatable(), @@ -61,7 +61,7 @@ public function provideTestIsTranslatable(): iterable } /** - * @dataProvider provideTestIsTranslatable + * @dataProvider provideIsTranslatableCases * * @phpstan-param object|class-string $classOrObject * @phpstan-param class-string[] $supportedModels diff --git a/tests/Functional/GedmoCRUDTest.php b/tests/Functional/GedmoCRUDTest.php index fc9edfb8..0980e1fe 100644 --- a/tests/Functional/GedmoCRUDTest.php +++ b/tests/Functional/GedmoCRUDTest.php @@ -28,7 +28,7 @@ protected function setUp(): void } /** - * @dataProvider provideLocales + * @dataProvider provideListCases */ public function testList(string $locale, string $name): void { @@ -42,7 +42,7 @@ public function testList(string $locale, string $name): void /** * @return iterable */ - public function provideLocales(): iterable + public function provideListCases(): iterable { yield 'default english' => ['', 'Novel']; yield 'english' => ['en', 'Novel']; @@ -51,7 +51,7 @@ public function provideLocales(): iterable } /** - * @dataProvider provideLocalesToCreate + * @dataProvider provideCreateCases */ public function testCreate(string $locale, string $newName): void { @@ -87,7 +87,7 @@ public function testCreate(string $locale, string $newName): void /** * @return iterable */ - public function provideLocalesToCreate(): iterable + public function provideCreateCases(): iterable { yield 'default english' => ['', 'Default New Novel']; yield 'english' => ['en', 'New Novel']; @@ -96,7 +96,7 @@ public function provideLocalesToCreate(): iterable } /** - * @dataProvider provideLocalesToEdit + * @dataProvider provideEditCases */ public function testEdit(string $locale, string $editedName): void { @@ -128,7 +128,7 @@ public function testEdit(string $locale, string $editedName): void /** * @return iterable */ - public function provideLocalesToEdit(): iterable + public function provideEditCases(): iterable { yield 'default english' => ['', 'Edited Default Novel']; yield 'english' => ['en', 'Edited Novel']; diff --git a/tests/Functional/KnpCRUDTest.php b/tests/Functional/KnpCRUDTest.php index 033ee0d8..66833ee1 100644 --- a/tests/Functional/KnpCRUDTest.php +++ b/tests/Functional/KnpCRUDTest.php @@ -28,7 +28,7 @@ protected function setUp(): void } /** - * @dataProvider provideLocales + * @dataProvider provideListCases */ public function testList(string $locale, string $name): void { @@ -42,7 +42,7 @@ public function testList(string $locale, string $name): void /** * @return iterable */ - public function provideLocales(): iterable + public function provideListCases(): iterable { yield 'default english' => ['', 'Novel']; yield 'english' => ['en', 'Novel']; @@ -51,7 +51,7 @@ public function provideLocales(): iterable } /** - * @dataProvider provideLocalesToCreate + * @dataProvider provideCreateCases */ public function testCreate(string $locale, string $newName): void { @@ -87,7 +87,7 @@ public function testCreate(string $locale, string $newName): void /** * @return iterable */ - public function provideLocalesToCreate(): iterable + public function provideCreateCases(): iterable { yield 'default english' => ['', 'Default New Novel']; yield 'english' => ['en', 'New Novel']; @@ -96,7 +96,7 @@ public function provideLocalesToCreate(): iterable } /** - * @dataProvider provideLocalesToEdit + * @dataProvider provideEditCases */ public function testEdit(string $locale, string $editedName): void { @@ -128,7 +128,7 @@ public function testEdit(string $locale, string $editedName): void /** * @return iterable */ - public function provideLocalesToEdit(): iterable + public function provideEditCases(): iterable { yield 'default english' => ['', 'Edited Default Novel']; yield 'english' => ['en', 'Edited Novel']; diff --git a/tests/Provider/Knplabs/LocaleProviderTest.php b/tests/Provider/Knplabs/LocaleProviderTest.php index 6dad1509..b6b210a1 100644 --- a/tests/Provider/Knplabs/LocaleProviderTest.php +++ b/tests/Provider/Knplabs/LocaleProviderTest.php @@ -23,7 +23,7 @@ final class LocaleProviderTest extends TestCase { /** - * @dataProvider provideValues + * @dataProvider provideUsesTheProperProviderBasedOnRequestCases */ public function testUsesTheProperProviderBasedOnRequest( string $expectedLocale, @@ -53,7 +53,7 @@ public function testUsesTheProperProviderBasedOnRequest( /** * @return iterable */ - public function provideValues(): iterable + public function provideUsesTheProperProviderBasedOnRequestCases(): iterable { yield 'with sonata enabled it uses sonata provider' => ['en', 'es', 'en', true]; yield 'with sonata disabled it uses knp provider' => ['es', 'es', 'en', false];