Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat request: ability to restart a task via sonmcli #1868

Open
nikonov1101 opened this issue Mar 23, 2019 · 2 comments
Open

feat request: ability to restart a task via sonmcli #1868

nikonov1101 opened this issue Mar 23, 2019 · 2 comments
Assignees
Labels
P: low This PR/Issue has minor priority S: CLI This PR/Issue changes CLI T: Feedback This PR/Issue is for processing feedback from users

Comments

@nikonov1101
Copy link
Member

Received feedback from the tech support chat. User wants to have a handle in CLI to restart their tasks.
Consider something like sonmcli task restart <deal_id> <task_id>, which should stop the given task, remember the task's image name, and then start a new task with that image.

Note to teammates: how to deal with tasks which resources were restricted by the task.yaml?

@nikonov1101 nikonov1101 added S: CLI This PR/Issue changes CLI P: low This PR/Issue has minor priority T: Feedback This PR/Issue is for processing feedback from users labels Mar 23, 2019
@nikonov1101 nikonov1101 self-assigned this Mar 23, 2019
@3Hren
Copy link
Member

3Hren commented Mar 23, 2019

Without the atomic guarantee, it can be a situation when you stop the task and there isn't possible to start it again with updated resources. So the only way to do this properly is inside the worker.

@nikonov1101
Copy link
Member Author

Thanks for comments.
I'd mind to implement it as part of the worker, too. That must be more robust - we already have access to the docker API, thus can just restart existing container, moreover, we can keep same task ID which looks good at the user's point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: low This PR/Issue has minor priority S: CLI This PR/Issue changes CLI T: Feedback This PR/Issue is for processing feedback from users
Projects
None yet
Development

No branches or pull requests

2 participants