Handle rate limit 429 #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topiux
approved these changes
Apr 8, 2023
|
Just a note on this: as of Dec 2023, I observe that quip returns both 503's and 429's and for 503's it correctly sets x-ratelimit-reset but for 429's it sets it to 0. So, I ended up special casing 429 and just setting the wait time to 61s, otherwise the client code doesn't regulate itself for 429's |
|
Here's a working workaround for this issue: I've updated the README in that branch to help anyone wanting to run this. It will take A LOT longer to run, but it should complete and not miss any files.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed that Quip returns 429 on rate limit exceeded. I failed to export my Quip docs several times but it worked after changing this line to handle both 429 and 503 the same way (though I don't think the API returns 503 for rate limits).
It should close #43