Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installs wrong packages for more recent Debian #46

Open
taggart opened this issue Mar 28, 2024 · 0 comments
Open

Installs wrong packages for more recent Debian #46

taggart opened this issue Mar 28, 2024 · 0 comments

Comments

@taggart
Copy link

taggart commented Mar 28, 2024

I noticed something about how the wireguard module manages packages on Debian systems:

In wireguard::params:

  • the manage_repo parameter is set to false for version 11(aka Bullseye) but otherwise is true.
  • the manage_package parameter uses the default of true for all debian releases.
  • the package_name parameter on 11(Bullseye) is just 'wireguard' but defaults to 'wireguard', 'wireguard-dkms', 'wireguard-tools for other debian releases.

Then in wireguard::install:

  • For the 11(Bullseye) case the above 3 package list gets defined and it's require is undef.
  • For any other debian case, the single package gets defined and require is set to ensure that the additional unstable apt source is setup properly.

The wireguard-dkms package only existed in the debian 11(Bullseye) release, before it's inclusion in the main kernel package. The wireguard-tools package has existed in all releases.

What I think happened:

This module was developed when most people were using debian 10(buster) and 11(Bullseye). Bullseye had everything that was needed, but if you were on buster then you need to install from unstable to make things work. So the case statements were setup to test for 11 but the default was assuming the buster release (or older?).

Now the problem is the case statement default will apply to the 12(Bookworm) and newer releases as well. This might not fail outright, but instead would pull in the unstable versions on these releases as well, which is probably not what is wanted. But also wireguard-dkms no longer exists, so that would fail if not already installed.

So probably what need to happen is that the default case should now assume that everything needed is present in debian and instead test for 10(Buster) and treat that one differently. But also buster is old enough now that it might be ok to drop it entirely.

Also I'm not sure why buster was including wireguard-tools, maybe there was something critical in there needed for setup and that moved into the wireguard package in bullseye? Or maybe it was just a "nice to have" in which case maybe it should be included for all debian releases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant