Passing --cookies-from-browser firefox to --yt-dlp-args throws exception
#2242
Labels
Bug
Unexpected problem or unintended behavior that needs to be fixed
Comments
jessicah
added
the
Bug
|
It appears that Was able to manually workaround the issue by adding the following in Not sure if this is an issue on spotDL's side, or yt-dlp's side. |
Looks like spotdl issue. If you want I can merge a PR with a fix from you. Otherwise I will fix it soon. |
|
I think this is yt-dlp's issue: yt-dlp/yt-dlp#10196 (comment) |
jessicah
added a commit
to jessicah/spotify-downloader
that referenced
this issue
Nov 28, 2024
As mentioned in yt-dlp/yt-dlp#10196, `yt_dlp.parse_options` should be used for parsing command line flags. However, as this API doesn't take in a set of configured options, the defaults handling is a little bit messier. Basically checks for any non-default values after parsing the command line flags, and skips setting them from the `defaults` dictionary. This fixes spotDL#2242.
Silverarmor
added a commit
that referenced
this issue
Jan 16, 2025
As mentioned in yt-dlp/yt-dlp#10196, `yt_dlp.parse_options` should be used for parsing command line flags. However, as this API doesn't take in a set of configured options, the defaults handling is a little bit messier. Basically checks for any non-default values after parsing the command line flags, and skips setting them from the `defaults` dictionary. This fixes #2242. # Title <!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Screenshots (if appropriate) ## Types of Changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] My code follows the code style of this project - [ ] My change requires a change to the documentation - [ ] I have updated the documentation accordingly - [ ] I have read the [CONTRIBUTING](/docs/CONTRIBUTING.md) document - [ ] I have read the [CORE VALUES](/docs/CORE_VALUES.md) document - [ ] I have added tests to cover my changes - [ ] All new and existing tests passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
System OS
Windows
Python Version
3.10 (CPython)
Install Source
pip / PyPi
Install version / commit hash
4.2.10
Expected Behavior vs Actual Behavior
Download songs with cookies fetched from browser. Instead, an exception is thrown, failing to parse the browser specification.
Steps to reproduce - Ensure to include actual links!
spotdl.exe --format m4a --bitrate disable --user-auth --m3u "{list}" --save-file metadata.spotdl --save-errors errors.txt --print-errors --archive archive.json --max-retries 10 --log-level DEBUG --preload --overwrite skip --yt-dlp-args "--cookies-from-browser firefox" download flipsideTraceback
Other details
Was trying to use a cookies.txt file before this, but the cookies appear to expire after five minutes, so quality silently drops to 128kbit.
The text was updated successfully, but these errors were encountered: