Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo path doesn't work in 2.1 #35

Open
szechyjs opened this issue Nov 3, 2013 · 6 comments
Open

Logo path doesn't work in 2.1 #35

szechyjs opened this issue Nov 3, 2013 · 6 comments

Comments

@szechyjs
Copy link

szechyjs commented Nov 3, 2013

Logo path is set to prepend /public/assets to the logo path. This does not work with the asset pipeline in 2.1

@radar
Copy link
Contributor

radar commented Nov 8, 2013

Hi @szechyjs, have you been able to investigate this issue since you posted about it? Would you please be able to do that and submit a patch to fix the problem?

@dpritchett
Copy link
Contributor

/Users/daniel/.rvm/rubies/ruby-2.0.0-p353/lib/ruby/gems/2.0.0/bundler/gems/spree-1fad15562f17/backend/app/assets/images/global/logo.png not found

Using Spree 2-0-master and this gem 2-0-master. I have a file at app/assets/images/global/logo.png that works, but this gem is missing it.

@peterberkenbosch
Copy link
Member

Can you show how you set the logo setting @dpritchett ? I cannot reproduce the error with a 2-0-stable clean sandbox and this in config/initializer/spree.rb https://gist.github.com/peterberkenbosch/7807412

@dpritchett
Copy link
Contributor

I'm messing with it locally now, I think I did something dumb with bundler. I'll update again in a while.

FWIW here's my current config:

Spree::PrintInvoice.config do |config|
  config.print_buttons = %w[invoice packaging_slip]
  config.print_invoice_logo_path = "global/logo.png"
end

@peterberkenbosch
Copy link
Member

That looks good to me.

@radar
Copy link
Contributor

radar commented Mar 20, 2014

@dpritchett Do you know if this issue is still ... an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants