How do you actually expire store credits?

[jasonfb]

I noticed that the implementation has expiring and non-expiring store credits, (implemented via the spree_store_credit_types table), but how do you actually mark a store credit as expired?

I was expecting to see an expires_at field on the store credits table but I see none. Am I missing something already implemented?

[athal7]

@jasonfb that hasn't been implemented yet. We are currently just using it for accounting segmentation of when to count the store credits against liability (issuance for non-expiring, and usage for expiring). Your approach seems like a good one to me.

[jasonfb]

Interesting. So, just to clarify, in terms of company debt (liability), you count the non-expiring SC at the time you issue them, but don't take expiring store credits as a loss (business expense) until they actually used? Does this follow some sort of GAAP guidelines?

I'm asking because we just recently went over this with our accountants and were a little confused as to the best way to approach it.

As far implementing the actual expiration of the store credit itself in the code, I will see if we can put this on our roadmap and make a pull request against this Gem.

thanks.