Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Add Linux aarch64, ppc64, and macOS arm64 builds #19

Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jan 14, 2025

Resolves ssl-hep/ServiceX_frontend#539

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • [N/A] Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@matthewfeickert matthewfeickert self-assigned this Jan 14, 2025
@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@matthewfeickert matthewfeickert force-pushed the mnt/add-aarch64-builds branch 2 times, most recently from 7d0fbca to d0f2e81 Compare January 14, 2025 00:42
@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

* Add support for linux-aarch64, linux-ppc64le, and osx-arm64 builds.
   - Add python and cross-python as build requirements for cross-compilation.
     c.f. https://conda-forge.org/docs/maintainer/knowledge_base/#cross-compilation-examples
   - Apply '-Wno-implicit-function-declaration' patch to all osx builds.
* Bump build number.
@matthewfeickert
Copy link
Member Author

@conda-forge-admin, please rerender

@matthewfeickert matthewfeickert marked this pull request as ready for review January 14, 2025 01:11
@matthewfeickert
Copy link
Member Author

@thewchan as this just adds additional builds and supports cross-compilation I'm going to go ahead and merge this and then go on to get PR #17 and PR #18 merged in. If in the future you'd like to do a review (apologies!) I'll wait for you. Just let me know. 👍

@matthewfeickert matthewfeickert merged commit 75de409 into conda-forge:main Jan 14, 2025
33 checks passed
@matthewfeickert matthewfeickert deleted the mnt/add-aarch64-builds branch January 14, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment solving for servicex from conda-forge
2 participants