Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge_overlaps loses values #21

Open
jeffutter opened this issue Dec 5, 2023 · 1 comment · May be fixed by #23
Open

merge_overlaps loses values #21

jeffutter opened this issue Dec 5, 2023 · 1 comment · May be fixed by #23
Labels
enhancement New feature or request

Comments

@jeffutter
Copy link

merge_overlaps seems to take the value from the first Interval that overlaps and the other value is lost. I'm not sure the best way to handle this? Maybe a user-provided merge function that lets you create a new value when merging two ranges?
@sstadick sstadick added the enhancement New feature or request label Dec 6, 2023
@sstadick
Copy link
Owner

sstadick commented Dec 6, 2023

Thanks for making an issue! That is a good point. a user provided merge function might be the way to go. I'm not planning on doing any work on this soon, always open to PRs, but will make sure something is included when a future release happens!

bennobuilder added a commit to bennobuilder/rust-lapper that referenced this issue Mar 19, 2024
@bennobuilder
sstadick#21 added merge_overlaps_with method
c86adc9
@bennobuilder bennobuilder linked a pull request Mar 19, 2024 that will close this issue
Open
bennobuilder added a commit to bennobuilder/rust-lapper that referenced this issue Mar 19, 2024
@bennobuilder
sstadick#21 fixed typo
ac47eb7
bennobuilder added a commit to bennobuilder/rust-lapper that referenced this issue Mar 19, 2024
@bennobuilder
sstadick#21 fixed typo
261fb61
bennobuilder added a commit to bennobuilder/rust-lapper that referenced this issue Mar 19, 2024
@bennobuilder
sstadick#21 wip split_and_merge_overlaps_with
67655be
bennobuilder added a commit to bennobuilder/rust-lapper that referenced this issue Mar 19, 2024
@bennobuilder
sstadick#21 fixed typo
e0f533e
bennobuilder added a commit to bennobuilder/rust-lapper that referenced this issue Mar 19, 2024
@bennobuilder
sstadick#21 reference instead of owned value in merge_fn
f1c838c
bennobuilder added a commit to bennobuilder/rust-lapper that referenced this issue Mar 19, 2024
@bennobuilder
sstadick#21 fixed test
69a4721
bennobuilder added a commit to bennobuilder/rust-lapper that referenced this issue Mar 20, 2024
@bennobuilder
sstadick#21 made devide_overlaps_with work exclusive end
f7430b7
bennobuilder added a commit to bennobuilder/rust-lapper that referenced this issue Mar 28, 2024
@bennobuilder
sstadick#21 rermoved eq as it doesn't seem necessary?
d9547b0
bennobuilder added a commit to bennobuilder/rust-lapper that referenced this issue Mar 28, 2024
@bennobuilder
sstadick#21 added range to callback fn
13a1825
bennobuilder added a commit to bennobuilder/rust-lapper that referenced this issue Mar 29, 2024
@bennobuilder
sstadick#21 added find_mut
50d940b
bennobuilder added a commit to bennobuilder/rust-lapper that referenced this issue Mar 29, 2024
@bennobuilder
sstadick#21 added iter_mut
a03107f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#21 added merge_overlaps_with method bennobuilder/rust-lapper
2 participants
@jeffutter @sstadick