Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcmc_rank_overlay: d_bin_counts doesn't contain rows for cases with n = 0 #331

Closed
sims1253 opened this issue Dec 13, 2024 · 3 comments · Fixed by #332
Closed

mcmc_rank_overlay: d_bin_counts doesn't contain rows for cases with n = 0 #331

sims1253 opened this issue Dec 13, 2024 · 3 comments · Fixed by #332

Comments

@sims1253
Copy link
Contributor

See also: https://discourse.mc-stan.org/t/rank-plots-dont-save-you-from-symmetric-non-stationary-chains/37624

In my case the first 4 bins all have count of 100 for the second chain, so the first chain's rank plot begins at 501. I suppose this could be a design choice but I think there should be bin entries in case n= 0.

image

@jgabry
Copy link
Member

jgabry commented Dec 13, 2024

@sims1253 thanks, can you check if #332 fixes the issue for you? You can install that branch of bayesplot with:

remotes::install_github("stan-dev/bayesplot", ref = "rank-overlay-always-start-0")

@sims1253
Copy link
Contributor Author

Seems to do it :)

@jgabry
Copy link
Member

jgabry commented Dec 14, 2024

Great, thanks for checking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants