Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing color-convert #204

Open
RowanDZ opened this issue Jun 22, 2021 · 0 comments
Open

Missing color-convert #204

RowanDZ opened this issue Jun 22, 2021 · 0 comments

Comments

@RowanDZ
Copy link

RowanDZ commented Jun 22, 2021

const include = /[\\/]node_modules[\\/](@storybook\/node-logger|are-you-es5|better-opn|boxen|chalk|commander|find-cache-dir|find-up|fs-extra|json5|node-fetch|pkg-dir|resolve-from|semver)/;

After a lot of swearing, headaches etc, figured out that Storybook 6.3.0-rc11 contained code originally from color-convert, which is not transpiled/has no es5. I copied this file, added color-convert to the include, made it es5 and added locally to our Storybook, and it's finally working again.

const include = /[\\/]node_modules[\\/](@storybook\/node-logger|are-you-es5|better-opn|boxen|chalk|commander|find-cache-dir|find-up|fs-extra|json5|node-fetch|pkg-dir|resolve-from|semver|color-convert)/;

Also, the preset-env gives an error about duplicated presets.

const ie11Preset = [
  '@babel/preset-env',
  {
    targets: {
      ie: '11',
    },
  },
  'SPECIALLY-FOR-IE11',
];

solves that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant