From 97cb13ce2d973b1c2cc4ea30048d47d3d43dc83a Mon Sep 17 00:00:00 2001 From: mulhern Date: Mon, 23 Dec 2024 09:48:58 -0500 Subject: [PATCH 1/5] Remove GitHub weekly.yml file It isn't really helpful these days. Signed-off-by: mulhern --- .github/workflows/weekly.yml | 33 --------------------------------- 1 file changed, 33 deletions(-) delete mode 100644 .github/workflows/weekly.yml diff --git a/.github/workflows/weekly.yml b/.github/workflows/weekly.yml deleted file mode 100644 index 97c9553..0000000 --- a/.github/workflows/weekly.yml +++ /dev/null @@ -1,33 +0,0 @@ ---- -name: dbus-python-client-gen weekly - -# yamllint disable-line rule:truthy -on: - schedule: - - cron: 20 5 * * 0 - workflow_dispatch: - -jobs: - next-fedora-python-checks: - strategy: - matrix: - include: - - dependencies: black python3-isort - task: make -f Makefile fmt-travis - - dependencies: yamllint - task: make -f Makefile yamllint - - dependencies: pylint python3-into-dbus-python - task: PYTHONPATH=./src make -f Makefile lint - - dependencies: python python3-build twine - task: make -f Makefile package - runs-on: ubuntu-latest - container: fedora:41 # NEXT DEVELOPMENT ENVIRONMENT - steps: - - uses: actions/checkout@v4 - - name: Install dependencies - run: > - dnf install -y - make - ${{ matrix.dependencies }} - - name: ${{ matrix.task }} - run: ${{ matrix.task }} From fba4ce20b3d5a48044ad4ded7210d5e786b60366 Mon Sep 17 00:00:00 2001 From: mulhern Date: Mon, 23 Dec 2024 09:53:21 -0500 Subject: [PATCH 2/5] Require python3-setuptools for current development environment Signed-off-by: mulhern --- .github/workflows/main.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index e6d102c..7d5337d 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -20,11 +20,14 @@ jobs: task: make -f Makefile fmt-travis - dependencies: yamllint task: make -f Makefile yamllint - - dependencies: pylint python3-into-dbus-python + - dependencies: pylint python3-into-dbus-python python3-setuptools task: PYTHONPATH=./src make -f Makefile lint - - dependencies: python3-into-dbus-python + - dependencies: python3-into-dbus-python python3-setuptools task: PYTHONPATH=./src make -f Makefile test - - dependencies: python3-coverage python3-into-dbus-python + - dependencies: > + python3-coverage + python3-into-dbus-python + python3-setuptools task: PYTHONPATH=./src make -f Makefile coverage runs-on: ubuntu-latest container: fedora:40 # CURRENT DEVELOPMENT ENVIRONMENT From 60872617172c26348f7a0ad88d95d6ca1dc55878 Mon Sep 17 00:00:00 2001 From: Bryan Gurney Date: Fri, 6 Dec 2024 14:43:45 -0500 Subject: [PATCH 3/5] Advance current development environment to Fedora 41 Signed-off-by: Bryan Gurney --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 7d5337d..d525ace 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -30,7 +30,7 @@ jobs: python3-setuptools task: PYTHONPATH=./src make -f Makefile coverage runs-on: ubuntu-latest - container: fedora:40 # CURRENT DEVELOPMENT ENVIRONMENT + container: fedora:41 # CURRENT DEVELOPMENT ENVIRONMENT steps: - uses: actions/checkout@v4 - name: Install dependencies From bb0bcfea8dcd80e9b66faa8e9d327cae45a1c0dd Mon Sep 17 00:00:00 2001 From: mulhern Date: Mon, 23 Dec 2024 10:00:02 -0500 Subject: [PATCH 4/5] pylint: Allow too-many-positional-arguments Signed-off-by: mulhern --- src/dbus_python_client_gen/_errors.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dbus_python_client_gen/_errors.py b/src/dbus_python_client_gen/_errors.py index 221ecb9..54c8b50 100644 --- a/src/dbus_python_client_gen/_errors.py +++ b/src/dbus_python_client_gen/_errors.py @@ -164,7 +164,7 @@ def __init__( method_name, expected, actual, - ): # pylint: disable=too-many-arguments + ): # pylint: disable=too-many-arguments, too-many-positional-arguments """ Initialize a DPClientKeywordError with the mismatched arguments. From 6670d54eb17de116024eee746e920f7a9987ace8 Mon Sep 17 00:00:00 2001 From: mulhern Date: Mon, 23 Dec 2024 10:37:59 -0500 Subject: [PATCH 5/5] Remove lint task on lowest development environment The lower version of pylint doesn't recognize the too-many-positional-arguments lint. It is not that useful to have this lint check for the lowest development environment since this code never changes. Signed-off-by: mulhern --- .github/workflows/main.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d525ace..6c8be34 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -45,8 +45,6 @@ jobs: strategy: matrix: include: - - dependencies: pylint python3-into-dbus-python - task: PYTHONPATH=./src make -f Makefile lint - dependencies: python3-into-dbus-python task: PYTHONPATH=./src make -f Makefile test - dependencies: python-setuptools python3-into-dbus-python