Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider combining some of the github action files #1272

Open
jbesraa opened this issue Dec 6, 2024 · 1 comment
Open

Consider combining some of the github action files #1272

jbesraa opened this issue Dec 6, 2024 · 1 comment
Labels
ci/cd CI/CD

Comments

@jbesraa
Copy link
Contributor

jbesraa commented Dec 6, 2024

Currently we add each new action to a new file in workflows. I think we should consider combining some of those flows into a single file.

For example: test.yaml, rust-msrv.yaml, semver-check.yaml, lockfiles.yaml, fmt.yaml, clippy-lint.yaml can probably be combined into a single file

@plebhash plebhash changed the title Cosnider combining some of the github action files Consider combining some of the github action files Dec 6, 2024
@plebhash plebhash added the ci/cd CI/CD label Dec 6, 2024
@jbesraa
Copy link
Contributor Author

jbesraa commented Dec 20, 2024

Consider running each job with twice once with rust 1.75(our MSRV) and once with rust stable, beside the MSRV check job which should run just with 1.75. This will make sure we always build on rust stable which is usually what people work with, and with our MSRV that we promise not to break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd CI/CD
Projects
None yet
Development

No branches or pull requests

2 participants