-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rust toolchain #1335
base: main
Are you sure you want to change the base?
Add rust toolchain #1335
Conversation
Bencher Report
Click to view all benchmark results
|
Bencher Report
Click to view all benchmark results
|
Bencher Report
Click to view all benchmark results
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1335 +/- ##
==========================================
+ Coverage 0.00% 19.29% +19.29%
==========================================
Files 18 164 +146
Lines 982 10852 +9870
==========================================
+ Hits 0 2094 +2094
- Misses 982 8758 +7776
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nack, our formatting works with nightly and always was. Also, you didnt provide any example where your statement is correct, your pr was not formatted with nightly and thats why you had so many changes. We had this discussion a couple of times already with adding/not the rust-toolchain file, not sure why we are back at it again. |
Not quite. While the code is formatted with nightly, the issue lies in the specific version of nightly used. My version, |
The workflow uses always latest nightly https://github.com/stratum-mining/stratum/blob/main/.github/workflows/fmt.yaml |
Not only the formatting but even clippy throws error locally when I run it, because of versioning.
I remember one of the new contributors added these clippy mentioned changes in his PR. |
let's investigate on the need for using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made myself almost the exact same file in order to have my shell.nix synced with toolchain version
closes: #1333