Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

need to clarify SetCustomMiningJob.Success description #115

Closed
plebhash opened this issue Dec 13, 2024 · 0 comments · Fixed by #116
Closed

need to clarify SetCustomMiningJob.Success description #115

plebhash opened this issue Dec 13, 2024 · 0 comments · Fixed by #116

Comments

@plebhash
Copy link
Contributor

while reviewing stratum-mining/stratum#1243 I noticed we missed a tiny detail on #98

current wording for the description of SetCustomMiningJob.Success is a bit misleading

Response from the server when it accepts the custom mining job. Client can start to mine on the job immediately (by using the job_id provided within this response).

it should be:

Response from the server when it accepts the custom mining job. Client can start submitting shares for this job immediately (by using the job_id provided within this response).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clarify SetCustomMiningJob.Success plebhash/sv2-spec
1 participant
@plebhash