-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some recent "ends of songs" are played randomly #1582
Comments
I suspect this is the same bug as.: I can't reproduce this. |
Not sure about #1535.
But +1 likely for those two.
I cannot say which ones exactly. I have mp3s, oggs, flacs, and even some m4as.
Just a hint, maybe not relevant. But sometimes I rename folders or remove songs, so I (properly) get:
Cannot this make the previous song streams alive, while jumping to another (existing) song? |
It is relevant. I played:
Now pipewire has two sinks:
So I enqueued Na Kralovej Holi once again (by Ctrl+D). After finishing the current song, I have now three sinks:
|
I've set up pipewire and set output to PulseAudio, tested playing for many hours a playlist on repeat containing MP3 and MP4 files, I still can't reproduce this, I've checked that no more than 1 file is open at a time.
If cross fading is disabled, it's hard to understand why several files are kept open at the same time. But surely there must be a case where there is an error leading to the previous pipeline is stuck, I still don't understand why it's fading if automatic cross-fading is disabled, unless the issue occurs only when manually switching track. |
I confirm this behaviour happening here too, but I could not reproduce. |
@jirislaby Do you have any of the features replay gain, ebur128 or bs2b enabled in the backend settings? |
I have "No Audio Normalization" set.
Have you enqueued a bad file as I wrote above? Like the attached file.zip (sorry, I had to pack the file due to github restrictions)? |
Can reproduce with that file |
The playbin pipeline is unrefed and the engine pipeline is deleted, but the file is still open, so unless I'm missing something basic here this seems like a GStreamer bug. |
I see the issue now, the problem is that the pipeline isn't set to NULL correctly before unrefing because |
Could you please test the latest master branch and check if the issue is gone? |
Yes, seems to be fixed. Thanks! |
BTW, are you aware of [1] https://en.opensuse.org/openSUSE:Build_Service_Concept_SourceService |
@jirislaby I'm aware of it, but haven't studied it enough yet. |
Will make a release candidate this weekend, and hopefully a stable release next week. |
Describe the bug
Running strawberry for a couple of days. Sometimes, it plays the last ~ 10 seconds of some past song incl. fade-out. Strawberry needs not be playing currently. It just starts playing randomly. This is somewhat new bug, I updated like:
To Reproduce
Just use strawberry for some time. Likely fade-out needs to be enabled? And using pipewire?
Expected behavior
To not play the ends randomly.
Screenshots:
Note these pipewire streams:
Usually only one playing a song is present. All the other are to play these ends of songs.
System Information:
Operating System: openSUSE Tumbleweed 20241018
KDE Plasma Version: 6.2.1
KDE Frameworks Version: 6.7.0
Qt Version: 6.8.0
Kernel Version: 6.11.5-rc1-1.g8c2e67f-default (64-bit)
Graphics Platform: Wayland
Processors: 16 × AMD Ryzen 7 PRO 7840U w/ Radeon 780M Graphics
Memory: 58.4 GiB of RAM
Graphics Processor: AMD Radeon 780M
Manufacturer: LENOVO
Product Name: 21K6S0A006
System Version: ThinkPad P14s Gen 4
The text was updated successfully, but these errors were encountered: