Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review creation and logging of SuperToken list #203

Open
d10r opened this issue Apr 18, 2023 · 0 comments
Open

Review creation and logging of SuperToken list #203

d10r opened this issue Apr 18, 2023 · 0 comments
Assignees
Labels
Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps

Comments

@d10r
Copy link
Collaborator

d10r commented Apr 18, 2023

On startup, the sentinel logs a list of SuperTokens.
First, there's an info log of all SuperTokens it's aware of (?), followed by a debug log of the same with 3Ps info attached.

This list seems to not be in sync with the list of tokens configured for the sentinel.
There's currently 3 ways to affect the list of tokens taken into consideration (lets call it "watched SuperTokens") by a sentinel instance:

If none of those are set - which is the default - all SuperToken are in the set of watched SuperTokens.

2 issues to be investigated:

  • Currently, the report outputs a set of SuperTokens which doesn't reflect the set of watched SuperTokens.
  • It doesn't reflect the set of all SuperTokens either. E.g. on some instances running for Polygon I see the SuperToken EURSx (0x02ef6868d69707b6093a2962bb5fe5661fcc0deb) missing, despite it not being included, despite it being a listed token. (may be related to the handling of the listed flag in previous sentinel versions) (this is likely a snapshot creation issue, to be dealt with separately) it's because no CFA event happened yet, keeping the token invisible for the sentinel

Goal:
going forward, the report item protocol.supertokens should reflect the current list of watched SuperTokens, such that sentinel operators can easily verify it's reflecting the intended configuration.

@ngmachado ngmachado added the Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps
Projects
None yet
Development

No branches or pull requests

2 participants