Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Critical but missing certificate verification #307

Open
KristiforMilchev opened this issue Dec 17, 2024 · 0 comments
Open

Not Critical but missing certificate verification #307

KristiforMilchev opened this issue Dec 17, 2024 · 0 comments

Comments

@KristiforMilchev
Copy link

const res = await axios.post(graphAPI, { query });

const response = await axios.get(manifestUrl);

const response = await axios({

Usually shouldn't cause any issues and looking at the code it's just fetching data from GraphQL, but still a good idea to verify that the certificate on the other end matches with what's expected to prevent any MiTM attacks on that vector.

Considering there are calls that open streams and download files it's a good idea to validate the certificates on the other hand either with a public key or the PEM, to prevent malicious actors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant