Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategy for the JUCE 5.3.0 patches file #19

Open
baconpaul opened this issue Dec 12, 2021 · 1 comment
Open

Strategy for the JUCE 5.3.0 patches file #19

baconpaul opened this issue Dec 12, 2021 · 1 comment
Labels
Code Cleanup General code cleanup issues like names, unused variables, warnings, fixme Infrastructure

Comments

@baconpaul
Copy link
Collaborator

The last production monique built against a patched JUCE 5.3.0. We need to figure out a strategy for those in JUCE 6 land, and if possible, a strategy without patches I hope!

The patches are

  1. Slider trigger clicked etc.. which is a separate issue The Slider API, Juce patches, and sldierClicked/triggerClick #12
  2. Tooltip class changes
  3. A few assertion supressions

we can probably get most of these with some subclassing, but the assertion supressions need some time

I think we would close this issue when the patch file gets deleted from the home dir of the repo :)

@baconpaul
Copy link
Collaborator Author

The XML assert is because the DARK.mcol xml with names like 0_button_off is actually invalid XML since XML identifiers can't start with a number.

I wonder if we want to make that something like c_0_button_off one day?

@mkruselj mkruselj added Code Cleanup General code cleanup issues like names, unused variables, warnings, fixme Infrastructure labels Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup General code cleanup issues like names, unused variables, warnings, fixme Infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants