Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in readme / example usage #54

Open
GarethCabournDavies opened this issue Sep 23, 2024 · 1 comment
Open

Error in readme / example usage #54

GarethCabournDavies opened this issue Sep 23, 2024 · 1 comment

Comments

@GarethCabournDavies
Copy link

Using the example https://github.com/sxs-collaboration/gwsurrogate/tree/master?tab=readme-ov-file#download-surrogate-data-and-load-it

I found that once the surrogate has been evaluated, dyn is returned as None, this is at odds with the comment statement dyn stands for dynamics, do dyn.keys() to see contents

Looking into help(sur) for the NRSur7dq4 surrogate, it says This is None for nonprecessing models, so I think this is just a case of updating that comment

@GarethCabournDavies
Copy link
Author

This was found in openjournals/joss-reviews#7073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant