Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detection of markers out of frame #45

Open
shardros opened this issue Apr 19, 2022 · 1 comment
Open

Detection of markers out of frame #45

shardros opened this issue Apr 19, 2022 · 1 comment
Labels
low-priority Things which would be nice to do but don't really effect the user

Comments

@shardros
Copy link
Member

It was observed at robocon 2022 that markers which were out of frame could be detected on the screens therefore the image is shown is a cropped view of what the robot can actually see.

Need to work out where in the pipeline this is happening.

@shardros shardros added the low-priority Things which would be nice to do but don't really effect the user label Apr 19, 2022
@WillMunns
Copy link
Contributor

This is probably not in Shepherd/Robot, but in the shephered resize helper (run on the brain to reduce arena network traffic) OR in the TK code that resizes images for display.

In both places the image is resized to fit inside a 4:3 window but keep the original aspect ratio. IIRC we set the res to a 4:3 res, but people can change it manually. If this scaling is done wrong, or the TK decides to zoom the image incorrectly then it might cause this.

This error is most likely in the final stage of putting the image onto a screen.

If this is a correct assumption, the to trigger this you will need to fiddle with the camera resolution to alter the aspect ratio while displaying it on an arena screen (or other 800x600 resolution output)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-priority Things which would be nice to do but don't really effect the user
Projects
None yet
Development

No branches or pull requests

2 participants