Fix .textlintignore support
#72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #68.
.textlintignoresupport has broken at 8ee34bc becauseTextLintEngine.executeOnText()does not consider ignore file.The same goes for
linter.lintText(), which was added later.This pull request will fix
.textlintignoresupport usinglinter.scanFilePath()API which was added in textlint v14.1.0.If user's textlint version is lower than v14.1.0,
.textlintignoreis simply ignored and other features works fine.Related textlint issue:
.textlintignoresupport tolintText()textlint/textlint#1408