Replies: 1 comment 1 reply
-
Please see my partial untested re-implementation in: |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The current
PreconfTaskManager
implementation contains both lookahead management code and general Taiko interaction logic. It might be a good idea to split off aLookahead.sol
file and move all lookahead-related code there, including theproveIncorrectLookahead
function.Additionally, I recommend moving
proveIncorrectPreconfirmation
toReceiptProver.sol
, as its logic is largely decoupled from the rest of the code inPreconfTaskManager
. You may also consider renamingPreconfirmationHeader
toPreconfReceipt
to better reflect its purpose.Smaller files make it easy for third-parties to review the code.
Beta Was this translation helpful? Give feedback.
All reactions