From 476e2c991e7f7e5c54c5e99c58f0758292aa5466 Mon Sep 17 00:00:00 2001 From: Tamino Bauknecht Date: Thu, 28 Mar 2024 00:10:59 +0100 Subject: [PATCH] cmake: Remove Boost.Python dependency Since some of the required functionality is not supported, it was supersided by own python C API wrappers. This is to avoid weird bugs due to GIL and Python's internal global states and the Boost.Python library and custom functions interfering with each other. --- CMakeLists.txt | 2 +- src/CMakeLists.txt | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index c240940..fa5b942 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -24,7 +24,7 @@ option(PPPLUGIN_ENABLE_UNDEFINED_SANITIZE option(PPPLUGIN_ENABLE_UNREACHABLE_SANITIZE "Enable compilation with unreachable sanitize flags" OFF) -find_package(Boost 1.61.0 REQUIRED COMPONENTS headers filesystem python) +find_package(Boost 1.61.0 REQUIRED COMPONENTS headers filesystem) find_package(Python 3.0 REQUIRED COMPONENTS Development) find_package(Lua 5.2 REQUIRED) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 116bba6..9a02424 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -16,7 +16,6 @@ add_library(${LIBRARY_TARGET} ${LIBRARY_SOURCES}) target_link_libraries( ${LIBRARY_TARGET} PUBLIC Boost::filesystem - PUBLIC Boost::python PUBLIC Python::Python PRIVATE ${LUA_LIBRARIES}) if(${PPPLUGIN_ENABLE_CPP17_COMPATIBILITY})