Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Delete old transfer code #869

Open
1xstj opened this issue Jan 3, 2025 · 0 comments
Open

[TASK] Delete old transfer code #869

1xstj opened this issue Jan 3, 2025 · 0 comments
Assignees
Labels

Comments

@1xstj
Copy link
Contributor

1xstj commented Jan 3, 2025

Currently we have two seperate places where we handle substrate/evm transfers

// origin check.
let evm_origin = evm_origin.ok_or(Error::<T>::MissingEVMOrigin)?;
let mapped_origin = T::EvmAddressMapping::into_account_id(evm_origin);
ensure!(mapped_origin == caller, DispatchError::BadOrigin);

and

Asset::Erc20(asset_address) => {

We should unify this code to a single place, easier to test

@1xstj 1xstj self-assigned this Jan 3, 2025
@1xstj 1xstj added the p1 🟠 label Jan 3, 2025
@github-project-automation github-project-automation bot moved this to Not Started 🕧 in Webb Universe Jan 3, 2025
@1xstj 1xstj moved this from Not Started 🕧 to Planning 🗺️ in Webb Universe Jan 3, 2025
@shekohex shekohex assigned shekohex and unassigned 1xstj Jan 6, 2025
@github-project-automation github-project-automation bot moved this from Planning 🗺️ to Completed ✅ in Webb Universe Jan 13, 2025
@drewstone drewstone reopened this Jan 13, 2025
@github-project-automation github-project-automation bot moved this from Completed ✅ to Planning 🗺️ in Webb Universe Jan 13, 2025
@drewstone drewstone changed the title [TASK] Unify evm/substrate transfer code [TASK] Delete old transfer code Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Planning 🗺️
Development

No branches or pull requests

3 participants